Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support KeyboardEvent.code #76

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: support KeyboardEvent.code #76

merged 1 commit into from
Mar 13, 2023

Conversation

kyletsang
Copy link
Collaborator

Fixes #75

@kyletsang kyletsang requested a review from jquense March 13, 2023 06:30
jquense
jquense approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably could just support the key case at this point but this is simple enough to cover both in case 👍

@kyletsang kyletsang merged commit 6fe458f into main Mar 13, 2023
@kyletsang kyletsang deleted the fix-esc branch March 13, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support KeyboardEvent.key in Modal
2 participants
@kyletsang @jquense