0.58.x Discussion

[grabbou]

Conversation on this thread are limited to 0.58 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[grabbou]

Making this issue as a placeholder for upcoming 0.58.x release candidate. Going to cut a new release once 0.57 goes stable (which should happen later today). We can now all go and watch WWDC in the meantime.

[aaronschubert0]

Would be good to cherry pick facebook/react-native@22cf5dc to match the iOS support already in place for text transform.

[kelset]

We haven't cut 0.58 yet, so everything that you see on master at the moment will be in the 0.58 branch.

[aaronschubert0]

@kelset Ah awesome, sorry about that, thanks for clarifying 👍

[kelset]

NP - as a rough estimate, we'll probably try to first get a 0.57.1 up & running and then cut 0.58.

[grabbou]

If there's nothing major holding us from doing it now, I think we can cut it on Friday and release by Monday. That shouldn't interfere with Facebook window, unless someone's working over the weekend.

…

On Tue, 18 Sep 2018 at 17:29 Lorenzo Sciandra ***@***.***> wrote: NP - as a rough estimate, we'll probably try to first get a 0.57.1 up & running and then cut 0.58. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#41 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxtiy8azHG1rqLCacQfoESp808pYMks5ucRE-gaJpZM4WlO4g> .

[kelset]

Quick update: after some conversation with the Core and the internal FB team, we decided to delay the cut and release of 0.58.x until the JSI feature lands into master - this also allow us to treat 0.57.x as as more "long term support" release (for, probably, at least another month) so that most developers will have time to update to it without the anxiety of having to do yet another upgrade right after.

[kelset]

@iljadaderko please limit the conversation to commits already on master.

@rafaellincoln there are a couple issues in the dedicated discussion repo (react-native-community/discussions-and-proposals#7 and react-native-community/discussions-and-proposals#11), and I'm sure that after it lands, some more content will be produced to explain more.

[EdwardDrapkin]

Will the flow upgrade (to 0.85) make it into 0.58?

[kelset]

@EdwardDrapkin yes. Since JSI landed, we are just waiting for the React sync to 16.6.0 commit to land and then we'll cut the first RC for 0.58.

So basically everything you see on master right now will be on that rc.

[Monte9]

@kelset just curious, is there an eta for 0.58 stable release? Even a rough timeline based on current release velocity would help. 30-45 days or sooner?

[kelset]

No idea on my side tbh, because 0.58 will have a lot of changes 🤷‍♂️

So the 0.58.0 I don't know when will land - likely that it will be before end of the year, but no real ideas on it. (once rc0 will be out and we gather some feedback on it we'll surely have a better understanding)

[kelset]

Hey everyone - quick update. The reason why currently there is not yet an 0.58 rc is because a PR 'broke' Android - but, as weird as it may sound, this is sort of good: we are now discussing how to upgrade to new & better Android, supporting 64bits and a new JSC.

The discussion & PRs related to that are still ongoing, but probably next week we'll reach a decision of 'how much' 0.58 will jump forward in terms of Android support, and cut the rc.

[grabbou]

We already cut the 0.58-stable branch that serves as a base for upcoming 0.58.0-rc.0 version. Right now, as it's been already mentioned, there is an issue related to Android and the way JSC version is specified that breaks all freshly created React Native apps.

Once the above issue gets addressed, we will most likely sync the 0.58-stable branch once again with the master as long as there are no in-progress rewrites happening at that time.

[grabbou]

0.58.0-rc.0 is now out on npm.

Note to Xcode 10 users: It still requires you to use legacy build system. We have a fix in place and will ship as a part of rc.1 soon.

[mjmasn]

@grabbou React is still at 16.6.1 for this rc right?

[kelset]

@mjmasn yes, there have not been new React sync commits since the one to 16.6.1

[pedpess]

Nice gals/guys! Good work you all involved 💯

[EdwardDrapkin]

A couple of the other recent RN point releases have been pinned to alpha React releases, 0.57.1 iirc... are there plans for the latest React (with hooks support) to make it to the 58 series or is that something that will likely have to wait for 59 or 60?

[jakst]

@EdwardDrapkin that is answered by @kelset two comments above. You'll have to wait unfortunately

[grabbou]

We have cherry-picked
facebook/react-native@19a7ecc to fix Xcode 10 build issues.

I am going to cherry-pick remaining commits tomorrow (including a fix for broken TextInput that is being worked on in 0.57 release) and will push next RC.

Let me know how it works for you and whether there's anything we should fix or pay extra attention to.

[jp928]

I would like to have suspense and lazy working in 0.58.

[grabbou]

If React sync commit lands in master branch before we promote the current RC to stable, we will try to cherry pick it. Unfortunately it’s not something that community can do. We depend on Facebook team to do that. Since they are extremely busy right now, it’s hard for me to give you any estimates as to when this could happen.

…

On Thu, 29 Nov 2018 at 09:18, Jing Tai Piao ***@***.***> wrote: I would like to have suspense and lazy working in 0.58. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxp-sUuz1I55hExSujROselJoSBHgks5uz5hVgaJpZM4WlO4g> .

[grabbou]

Unfortunately, the Detox tests are still failing. I am pretty sure the fix is quite easy, but it's going to take a bit of time due to Christmas break.

The issues are due to cherry-picking additional tests that has helped us identify additional issues present in this release (and master branch too).

I am going to post an update regarding that later this week (around Friday).

Meanwhile, I wish everyone following this thread - Merry Christmas and a Happy new Year!

[grabbou]

Due to Facebook team being on the break, we have decided to postpone the release till the team is back tomorrow.

Will keep you updated. We need to chat and see when 0.58 can be promoted to a stable released. I think this can happen around week or two from 0.58.0-rc.2

[grabbou]

Managed to fix Detox and iOS snapshot tests. CircleCI is now processing 0.58.0-rc.2 build -> https://circleci.com/gh/facebook/react-native/tree/0.58-stable. If it goes green, the release will be available in around 30 minutes from this comment.

Will check in the morning. It's up on npm.

I think this is the last RC before 0.58 hits stable. We are considering cherry-picking one more commit into 0.58.0-rc.3 (facebook/react-native@f3e5cce) in the meantime.

[abbasfreestyle]

Just a heads up, building a fresh react-native init with 0.58.0-rc.2 causes the app to crash on a real OnePlus 6 device.

Device	Builds	Crashes
Android real device (OnePlus 6)	Yes	Yes
Android simulators	Yes	No
iOS simulators	Yes	No
iOS real device	Not tested	N/A

However, building a fresh react-native init with 0.57.8 works on OnePlus 6

This is all i see with react-native log-android

01-10 09:05:28.034 26227 26227 D ReactNative: ReactInstanceManager.ctor()
01-10 09:05:28.073 26227 26227 D ReactNative: ReactInstanceManager.createReactContextInBackground()
01-10 09:05:28.073 26227 26227 D ReactNative: ReactInstanceManager.recreateReactContextInBackgroundInner()
01-10 09:05:28.517 26227 26227 D ReactNative: ReactInstanceManager.onJSBundleLoadedFromServer()
01-10 09:05:28.518 26227 26227 D ReactNative: ReactInstanceManager.recreateReactContextInBackground()
01-10 09:05:28.518 26227 26227 D ReactNative: ReactInstanceManager.runCreateReactContextOnNewThread()

Phone specs

Hopefully, that might be of some use to you guys 👍

[mjmasn]

I can also replicate the crash discovered by @abbasfreestyle. Seems to be a problem in all the rc versions.

Logs from my Samsung S9+ (Android 8.0.0):

E SoLoader: Error when loading lib: dlopen failed: library "libicu_common.so" not found lib hash: 84bb138b763a0f08c540b9e8b55b1fb0 search path is /data/app/com.x-paJWHXc7oE5jhXyBULvxmg==/lib/arm64
E SoLoader: couldn't find DSO to load: libreactnativejni.so caused by: dlopen failed: library "libicu_common.so" not found
E AndroidRuntime: FATAL EXCEPTION: create_react_context
E AndroidRuntime: Process: com.x, PID: 16386
E AndroidRuntime: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libreactnativejni.so caused by: dlopen failed: library "libicu_common.so" not found
E AndroidRuntime: 	at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:703)
E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:564)
E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:500)
E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:455)
E AndroidRuntime: 	at com.facebook.react.bridge.ReactBridge.staticInit(ReactBridge.java:30)
E AndroidRuntime: 	at com.facebook.react.bridge.NativeMap.<clinit>(NativeMap.java:19)
E AndroidRuntime: 	at com.facebook.react.jscexecutor.JSCExecutorFactory.create(JSCExecutorFactory.java:25)
E AndroidRuntime: 	at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:944)
E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:764)

[dulmandakh]

Cherry picks:

• facebook/react-native@abfd563 - adds support for App Bundling
• facebook/react-native@64de0c0 - bumps OkHTTP version

[Monte9]

Cherry pick:

• facebook/react-native@7fbccde - RedBox Screen has new dark mode design to improve readability.

[dulmandakh]

Cherry picks:

• facebook/react-native@f76164f - WebView deprecation warning

[dulmandakh]

cherry picks:

• facebook/react-native@e3ff150 - Android Crash fix

[grabbou]

@dulmandakh is the last "Android Crash fix" solving the issue presented by @abbasfreestyle?

BTW, thank you @abbasfreestyle and @mjmasn for doing research and being on top of this! It's really valuable to be able to rely on the community and that we can work together on making the next release even better!

If there's anything we can do to make RC testing even smoother, please let me know!

==

Meanwhile, I am going to cherry-pick all the aforementioned commits and will release another RC for a while, before it is promoted to stable.

Regarding 0.59 - we are wrapping up remaining pieces of CLI work that are holding us off. This is also to land later today or tomorrow.

[dulmandakh]

Yes, it RNTester app runs on 64bit device. But tested it on master, not 0.58-RC.

[dulmandakh]

Cherry picks:

• facebook/react-native@cf85d0e - Android HTTP cache

[grabbou]

Didn't cherry-pick the last commit and this one as it was depending on other non-trivial commit.

0.58.0-rc.3 is out on Circle, waiting for tests to pass.

[mjmasn]

Thanks @grabbou, looks good re the UnsatisfiedLinkError - I can now get to the Welcome to React Native! screen with a freshly react-native inited app 👍 🎉

[grabbou]

Great @mjmasn!

0.58.0-rc.3 is out on npm. This is the last RC - please no more cherry-picks. We are moving straight to the stable channel.

I am going to open 0.59 thread in the meantime.

[EdwardDrapkin]

So the new JSC (facebook/react-native@f3e5cce) won't be available without the 3rd party package until 0.59? :(

[dulmandakh]

last cherry pick:

• facebook/react-native@cf85d0e - add HTTP cache to Android

[kelset]

@EdwardDrapkin yes we prefer to take it slow with it - but 0.59 is not as far as you may think: 0.58 won't have the "long term" approach used for 0.57 :)

[danielgindi]

Something about the changes around jschelpers in the podspec should be mentioned in the changelog. If people don't know what to do with it, it breaks the next pod update command.

[grabbou]

Waiting for few commits to fix the bugs we have just discovered. Generally speaking it's "few days" away.

Just cherry-picked another round of Android-related fixes.

[estevaolucas]

@grabbou we have this new Text/TextField's maxFontSizeMultiplier prop for iOS in v0.58.0-rc.3 facebook/react-native@01d5eff

Could we cherry-pick the Android commit for 0.58 as well? facebook/react-native@4936d28.

Thanks

[grabbou]

CI is processing 0.58.0 build right now.

@elucaswork, unfortunately, the commit you requested was non-trivial to cherry-pick (it depends on another Android commit which is quite heavy).

I have discussed this with the team and we have came to the conclusion that although keeping APIs in sync and as cross-platform as possible is our priority, this feature wasn't added to both platforms concurrently either. There was a fair gap in between landing them and we have decided to move it into 0.59.

I hope it's not a deal breaker for you! Thank you for raising this question :)

[Monte9]

Excited to finally see 0.58 in action. 🎉

Wanted to thank @grabbou for all your work on RN OSS and coordinating these releases. 💪 It's not an easy task, but you manage to do a fantastic job at it! 👏 You are a real asset to the community! 🥇 🙌

[grabbou]

Thank you @Monte9 - I really appreciate your feedback, it's encouraging! It's worth mentioning it's not just me working on the releases - I just happen to be the one facing the community end of it!

I wanted to thank everyone, especially @dulmandakh for helping with Android so much! We would be stuck few days or weeks if it wasn't for your help!

Going to close this issue for now and open up a new one for stable channel.