Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.57.8 Discussion #75

Closed
kelset opened this issue Dec 13, 2018 · 21 comments
Closed

0.57.8 Discussion #75

kelset opened this issue Dec 13, 2018 · 21 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@kelset
Copy link
Member

kelset commented Dec 13, 2018

Conversation on this thread are limited to 0.57.8 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.9 release in the near future. Unless some serious bugs pops up, the release will happen after Jan 6th 2019.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.8 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

@kelset kelset added stable Stable version backport request Cherry picking a change into an existing release labels Dec 13, 2018
@estevaolucas
Copy link

Accessibility Escape facebook/react-native@ee7c702 (facebook/react-native#22047)

@Eyesonly88
Copy link

Fix NPE when opening Google Search Assistant facebook/react-native@69c8aa6

@radeno
Copy link

radeno commented Jan 3, 2019

Happy new year all. Wish to whole community all the best!

Two more fixes:

@kelset
Copy link
Member Author

kelset commented Jan 14, 2019

Hey everyone, thanks for the suggestions, I'll do a new release next week or the one after that 💪

I've also seen that this commit got requested here.

@radeno
Copy link

radeno commented Jan 14, 2019

Hey @kelset thanks for everything.

There are some new potential cherry-picks.

@chrisnojima
Copy link

@kelset
Copy link
Member Author

kelset commented Jan 21, 2019

TY everyone, I'll try to make this happen this week 🤞

@estevaolucas
Copy link

estevaolucas commented Jan 24, 2019

maybe one more feature?

@grabbou
Copy link
Member

grabbou commented Jan 24, 2019

Closing as 0.58 is already out. @elucaswork you will be able to have this feature in 0.59 right away.

@grabbou grabbou closed this as completed Jan 24, 2019
@kelset
Copy link
Member Author

kelset commented Jan 25, 2019

(reopening as we are still discussing if we will still do 0.57.x patch releases for a few months)

@kelset kelset reopened this Jan 25, 2019
@thymikee
Copy link
Member

thymikee commented Jan 25, 2019

If that's still feasible, would be nice to back-port this to 0.57.x:

@fungilation
Copy link

So 0.57.x would be a special LTS release then, overlapping with patches in new releases?

@kelset
Copy link
Member Author

kelset commented Jan 25, 2019

That was the original idea when we started doing 0.57 - but it seems that, minor hiccups aside, the upgrade process to 0.58 is fairly quick & smooth. So we may opt to not proceed with 0.57.9.

It will also require a couple tweaks to our current scripting/CD structure so we are trying to evaluate the options.

@thymikee
Copy link
Member

No biggie if it's too much burden from maintenance side. The fix I proposed to cherry-pick is related to react-native init which from now on refers to 0.58 most of the time so it's not anything critical.

@fungilation
Copy link

Agreed in not wasting effort patching 0.57, if 0.58 upgrade is smooth without many breaking changes, which I don't see afaik from changelog.

LTS releases are a good idea though, in the future for upcoming releases with major breaking changes like with release of Fabric.

@kelset
Copy link
Member Author

kelset commented Jan 28, 2019

if 0.58 upgrade is smooth without many breaking changes

absolutely - we are still on the lookout because it seems that there is still one small issue with git-upgrade when going from 0.57.8 -> 0.58.1 but aside from that all the feedback has been that the upgrade was smooth.

That said, it would also be super useful to know which version of RN the devs are using but I can't think of any 😅 (maybe an npm filter by version tool? 🤔not sure it exists)

@grabbou
Copy link
Member

grabbou commented Jan 28, 2019

The impression I have from the recent comments here is that we have agreed to not proceed with 0.57 cherry-picks anymore and move onto 0.58, right?

If yes, I think we can close the issue again and jump onto 0.58 bandwagon all together!

@ithustle
Copy link

ithustle commented Jan 28, 2019

Any chances to have audio api and support for svg images?

@kelset
Copy link
Member Author

kelset commented Jan 28, 2019

@ithustle this is not the issue to discuss those things, there are already libraries to add those functionalities - you can also use Canny to submit a feature request.

@ithustle
Copy link

@kelset my bad. Okay.

@kelset
Copy link
Member Author

kelset commented Feb 5, 2019

Hey everyone, after some internal discussion - given that the transition to 0.58.3 is fairly smooth and the release is pretty stable, we have decided to end support to 0.57 to try and dedicate our “work hours” for 0.58 & next releases.
Please refer to the dedicated issues in this same repo for cherry-picks & discussions!

@kelset kelset closed this as completed Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests

9 participants