0.59.x Discussion

[grabbou]

Conversation on this thread are limited to 0.59.0 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

[grabbou]

Since we have decided to postpone 0.60 release over a week, I am going to do cherry-picking today and release a new version.

[grabbou]

The release is ready to go. However, since it’s Friday, let’s wait till Monday morning to release it.

[grabbou]

0.59.2 is on CircleCI. Will hit npm in around 30 minutes.

[sunnylqm]

Please cherry pick
facebook/react-native@9db347f

[kelset]

This would be good to cherry pick too facebook/react-native@c13f5d4

and this too facebook/react-native@f149426

[radeno]

My two cents:

• facebook/react-native@aad4dbb
• facebook/react-native@395197d supplement to RN 0.59.2 which adds eslint
• facebook/react-native@15619c2 very handy
• facebook/react-native@b3c7496
• facebook/react-native@02e8e53
• facebook/react-native@bbd98d5
• facebook/react-native@b943db4
• facebook/react-native@56679ed

[kelset]

hey everyone - I've cherry-picked most of the requests, and CI is green. Expect 0.59.3 later today or tomorrow.

[grabbou]

Can you outline @kelset what commits you have not cherry-picked? Would help to maintain this thread and also see what we can do with them (reject, ask authors to send a PR, see if they depend on another commit that can easily resolve the conflict).

[kelset]

Sure - sorry I totally forgot: I've cherry picked

• facebook/react-native@b3c7496
• facebook/react-native@02e8e53
• facebook/react-native@aad4dbb
• facebook/react-native@15619c2
• facebook/react-native@1741593
• facebook/react-native@9db347f (which required facebook/react-native@581dc3e)
• facebook/react-native@b943db4
• facebook/react-native@c13f5d4

And I've added on top

• facebook/react-native@ff66600

Which should fix some issues devs are experiencing in Swift.

I couldn't cherry pick the others.

I'm waiting on CI to be green again after the last cherry pick, then I'll do the bump.

[Bardiamist]

Why facebook/react-native@56679ed not included?
I'm just trying to implement universal link in my project:)

[kelset]

@Bardiamist there was a conflict that looked fairly complex to solve. If you want to try and fix it for yourself (which is the procedure we follow in these scenarios) you can fork the main repo, switch to the 0.59 branch and try the cherry pick, and then submit a pr against that branch.

[Bardiamist]

@kelset I tried and no have conflitct on cherry pick. I think I should not create pr for this.

[kelset]

Uhm, weird. Ok let's try again that commit for 0.59.4

[kelset]

Anyway, now that 0.59.3 is out, let's move to a new issue to clean up the history & remove some noise -> #109