fix: resolves react snapshot undefined warning #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
Resolves React warning being displayed when the
regionprop inMapViewisundefined. React requires a snapshot value (or null) to be provided (see warning message below). This PR modifiesgetSnapshotBeforeUpdateinMapViewto returnnullifprops.regionisundefined.How did you test this PR?
Change is JS only and only affects library's interaction with React. However, the change was also tested on Android (on device) and iOS (device and simulator) to confirm warning is no longer triggered.
Steps to recreate and test for change:
MapViewwithoutregionprop defined, e.g.:Run react native app and observe React warning in debug mode.
Now test with changes in this PR, warning should disappear.