Bugfix/accessibility #2826
Merged
Bugfix/accessibility #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
pohnean
pushed a commit
to pohnean/react-native-maps
that referenced
this pull request
Jul 28, 2020
* Fixed string passed for booleans * Added missing accessibility properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
Nope. But a recent one did this partially: #2253
It missed the MapViewManager for both Air and Google, and the MarkerManager for Air.
Also the boolean bugs which prevent the markers from being accessible in Xcode.
What issue is this PR fixing?
#2252, #1104
How did you test this PR?
By creating automation. Markers are still a pain point in XCUI, especially tapping them, so it is not solved completely. But at least they have their ids.