Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix CalloutSubview on Apple maps #2794

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

nabehide
Copy link
Contributor

@nabehide nabehide commented Apr 5, 2019

Does any other open PR do the same thing?

No

What issue is this PR fixing?

When using Apple maps and CalloutSubview, the following error happens.

Simulator Screen Shot - iPhone X - 2019-04-06 at 02 08 50

It seemed that CalloutSubview was added but the probject file wasn't updated.

How did you test this PR?

I tested this PR with Apple maps on iOS in a simulator.

@rborn
Copy link
Collaborator

rborn commented Apr 6, 2019

LGTM @alvelig 🐽

@alvelig alvelig merged commit 4ee5d78 into react-native-maps:master Apr 6, 2019
@romainleduc
Copy link

I have exactly the same error but on android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants