This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
Android: Improve surface destroy handling. #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents UI freezes due to the lock being acquired on the surface destroyed callback.
cristianoccazinsp
changed the title
MateusAndrade
approved these changes
Aug 17, 2021
n1ru4l
pushed a commit
that referenced
this pull request
Aug 17, 2021
## [4.0.2](v4.0.1...v4.0.2) (2021-08-17) ### Bug Fixes * Improve surface destroy handling. ([#3316](#3316)) ([5d36cf1](5d36cf1))
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents UI freezes due to the lock being acquired on the surface destroyed callback. This also prevents a warning when the camera unmounts due to multiple calls to
stop, and the first one destroying the background handler.This issue becomes more visible when using react-native-screens, and I pinned it down to this lock being acquired.