Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on upstream RN styles for SpinnerTimePickerDialog and SpinnerTimePickerStyle #424

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

klandell
Copy link
Contributor

@klandell klandell commented Mar 25, 2021

Resolves #411.

Closes #258

Changes tested in the sample repo (https://github.com/klandell/time-spinner-bug) in both the main and rn-64 branches on a physical Android device.

Copy link
Member

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vonovak vonovak merged commit fcf5943 into react-native-datetimepicker:master Mar 25, 2021
vonovak pushed a commit that referenced this pull request Mar 25, 2021
## [3.4.3](v3.4.2...v3.4.3) (2021-03-25)

### Bug Fixes

* remove dependency on upstream RN styles for SpinnerTimePickerDialog and SpinnerTimePickerStyle ([#424](#424)) ([fcf5943](fcf5943))
@vonovak
Copy link
Member

vonovak commented Mar 25, 2021

🎉 This PR is included in version 3.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants