From be64bad088d3a327d3d8b67917e82093db3120e6 Mon Sep 17 00:00:00 2001 From: Abraham Elmahrek Date: Sun, 22 Sep 2019 11:10:08 -0700 Subject: [PATCH 1/2] Android Studio synchronization fix Use output of subprocess in gradle file instead of input --- packages/platform-android/native_modules.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/platform-android/native_modules.gradle b/packages/platform-android/native_modules.gradle index 598f36e89..7913b5e85 100644 --- a/packages/platform-android/native_modules.gradle +++ b/packages/platform-android/native_modules.gradle @@ -188,7 +188,7 @@ class ReactNativeModules { try { cmdProcess = Runtime.getRuntime().exec(command, null, root) - def bufferedReader = new BufferedReader(new InputStreamReader(cmdProcess.getInputStream())) + def bufferedReader = new BufferedReader(new InputStreamReader(cmdProcess.getOutputStream())) def buff = "" def readBuffer = new StringBuffer() while ((buff = bufferedReader.readLine()) != null){ From cb9f6cb6e3c67ec8776497cb9170e4d19494ee66 Mon Sep 17 00:00:00 2001 From: Abraham Elmahrek Date: Thu, 26 Sep 2019 12:46:03 -0700 Subject: [PATCH 2/2] #741: Print out errors in command execution --- packages/platform-android/native_modules.gradle | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/platform-android/native_modules.gradle b/packages/platform-android/native_modules.gradle index 7913b5e85..f9bf5dd7a 100644 --- a/packages/platform-android/native_modules.gradle +++ b/packages/platform-android/native_modules.gradle @@ -188,7 +188,7 @@ class ReactNativeModules { try { cmdProcess = Runtime.getRuntime().exec(command, null, root) - def bufferedReader = new BufferedReader(new InputStreamReader(cmdProcess.getOutputStream())) + def bufferedReader = new BufferedReader(new InputStreamReader(cmdProcess.getInputStream())) def buff = "" def readBuffer = new StringBuffer() while ((buff = bufferedReader.readLine()) != null){ @@ -198,6 +198,15 @@ class ReactNativeModules { } catch (Exception exception) { this.logger.warn("${LOG_PREFIX}${exception.message}") this.logger.warn("${LOG_PREFIX}Automatic import of native modules failed.") + + def bufferedErrorReader = new BufferedReader(new InputStreamReader(cmdProcess.getErrorStream())) + def buff = "" + def readBuffer = new StringBuffer() + while ((buff = bufferedErrorReader.readLine()) != null){ + readBuffer.append(buff) + } + this.logger.warn("${LOG_PREFIX}${readBuffer.toString()}") + return reactNativeModules }