Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Studio - Required for building and installing your app on Android #2354

Closed
hcweb opened this issue Apr 6, 2024 · 22 comments
Closed
Labels
question Further information is requested

Comments

@hcweb
Copy link

hcweb commented Apr 6, 2024

Android Studio - Required for building and installing your app on Android

PS D:\android_workspace\reactstudy> npx react-native doctor
Common
✓ Node.js - Required to execute JavaScript code
✓ yarn - Required to install NPM dependencies
✓ Metro - Required for bundling the JavaScript code

Android
✓ Adb - Required to verify if the android device is attached correctly
✓ JDK - Required to compile Java code
✖ Android Studio - Required for building and installing your app on Android
✓ ANDROID_HOME - Environment variable that points to your Android SDK installation
✓ Gradlew - Build tool required for Android builds
✓ Android SDK - Required for building and installing your app on Android
微信截图_20240406192231
微信截图_20240406192257

Errors: 1
Warnings: 0

Usage
› Press f to try to fix issues.
› Press e to try to fix errors.
› Press w to try to fix warnings.
› Press Enter to exit.

When I run npx react native doctor and receive an error message Android Studio - Required for building and installing your app on Android, I have already installed Android Studio, Windows 11 operating system, Java 17 version. How do I handle this issue? Thank you

@hcweb hcweb added the question Further information is requested label Apr 6, 2024
@thymikee
Copy link
Member

thymikee commented Apr 7, 2024

It’s likely a bug on our end, nothing to worry about, unless you face issues building for Android from the CLI.

Since we miss Windows contributors, we’d appreciate any help resolving this AS resolution bug

@Kailash23
Copy link

Kailash23 commented Apr 11, 2024

Fixed by installing command line tools

image

And adding this line
export PATH=$PATH:$ANDROID_HOME/cmdline-tools\latest\bin
in

image

Close and reopen the terminal

yarn react-native doctor

@matej-podzemny
Copy link

@Kailash23 Why the path has \ ? 🤔

@matej-podzemny
Copy link

matej-podzemny commented Apr 11, 2024

Same issue here, I have the android studio installed via JetBrain Toolbox and the doctor cannot found it at all, everything else works fine.

I tried to set this, but no luck so far..

export STUDIO_JDK=~/Applications/Android\ Studio.app
export PATH="$STUDIO_JDK:$PATH"

@GoldenBilly
Copy link

I have the same issue, but app building and running just fine on my android device, so it's only doctor's issue.

@GoldenBilly
Copy link

GoldenBilly commented May 12, 2024

I think issue is here
image
because in windows (or at least in windows that support 64 bits) android studio's bin is studio64.exe, not studio.exe

@GoldenBilly
Copy link

maybe if we replace it with that:

const prefix = process.arch === 'x64' ? '64' : '';
const androidStudioPath = join(
        getUserAndroidPath(),
        'android-studio',
        'bin',
        `studio${prefix}.exe`
        )

it will be fixed but I'm not sure about that

@GoldenBilly
Copy link

or maybe its because of wmic, when I've tried to execute it with
wmic datafile where name="C:\\Users\va126\\AppData\\Local\\Android\\android-studio\\bin\\studio64.exe" get Version
It gave me this error:
Unexpected switch at this level.

But when I've tried this:
wmic datafile where "Name='C:\\Users\\va126\\AppData\\Local\\Android\\android-studio\\bin\\studio64.exe'" get version
It worked just fine and gave me this version:
2022.3.0.0

So I think it can be also because of wmic.

@GoldenBilly
Copy link

first command is similar to command in code
image

@wy-service
Copy link

Same question

@wy-service
Copy link

What should I do

@matej-podzemny
Copy link

It is doctor issue, actually in its dependecy envinfo. The issue was raised here, and is already merged: tabrindle/envinfo#252 (review)

SOLUTION: If you still struggle, you can create alias folder to help doctor found it, for mac use this command:

ln -s /Applications/Android\ Studio.app/Contents ~/Applications/Android\ Studio.app/Contents

@GoldenBilly
Copy link

What about windows?

@GoldenBilly
Copy link

image
I've tried my fix, and it worked just fine for me.
All what I've changed is:

      const prefix = process.arch === 'x64' ? '64' : '';
      const androidStudioPath = join(
        getUserAndroidPath(),
        'android-studio',
        'bin',
        `studio${prefix}.exe`
        ).replace(/\\/g, '\\\\');
      const {stdout} = await executeCommand(
        `wmic datafile where "Name='${androidStudioPath}'" get version`,
      );

In /packages/cli-doctor/src/tools/healthchecks/androidStudio.ts

@GoldenBilly
Copy link

@thymikee

@GoldenBilly
Copy link

No one cares...

@szymonrybczak
Copy link
Collaborator

@matej-podzemny thank you for raising this fix! I've created bump PR inside CLI #2428 🙌

@GoldenBilly this fix makes sense to me! I've a PR with your diff 🙏

@GoldenBilly
Copy link

you should probably include in your fix also this:

const {stdout} = await executeCommand(
        `wmic datafile where "Name='${androidStudioPath}'" get version`,
      );

because I dont know why, but at least my windows had a problem with that (I think because of "-" in android studio path)

@szymonrybczak
Copy link
Collaborator

@GoldenBilly I'm fine with this change, do you mind submitting separate PR? :)

@GoldenBilly
Copy link

okay, but later, because I dont have PC with me right now

@lianzhy
Copy link

lianzhy commented Oct 13, 2024

when i use 'npx react-native doctor' maybe happen this problem? What should I do?My Android Studio is also installed in toolbox, but IDEA doesn't find it either, please help me!!! I don't think it's due to the path of the toolbox installation
image
image
image

@GoldenBilly
Copy link

it happens because it seems your android studio installed on "D:", not in a user directory, this is why doctor can't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants