Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing help for commands without description #214

Closed
grabbou opened this issue Mar 11, 2019 · 3 comments
Closed

Printing help for commands without description #214

grabbou opened this issue Mar 11, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@grabbou
Copy link
Member

grabbou commented Mar 11, 2019

Follow up to: facebook/react-native#22045 - investigate the patch.

@grabbou grabbou added the bug Something isn't working label Mar 11, 2019
@grabbou grabbou reopened this Mar 11, 2019
@grabbou
Copy link
Member Author

grabbou commented Mar 11, 2019

Yes. Maybe I wasn't clear but following up my comment here, the fix on line 55 (to conditionally check for description) is hacky.

We are setting noHelp in a different place to avoid calling this function w/o description set. In other words, this function should be called only when description is defined. If that's not the case, our assumptions somewhere in the code are invalid and we should track that down.

@thymikee
Copy link
Member

I foolishly assumed this was merged. We need to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants