From 08b140afb6128d4b05efcbecb48b22d6b3c6524e Mon Sep 17 00:00:00 2001 From: Arushi Kesarwani Date: Mon, 6 Mar 2023 17:37:42 +0000 Subject: [PATCH] doctor : Modifying the version ranges to keep up to date with RN 0.72 (#1858) * Modifying the version to keep up to date * Modifying the version to keep up to date --- .../src/tools/healthchecks/__tests__/androidNDK.test.ts | 4 ++-- packages/cli-doctor/src/tools/versionRanges.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/cli-doctor/src/tools/healthchecks/__tests__/androidNDK.test.ts b/packages/cli-doctor/src/tools/healthchecks/__tests__/androidNDK.test.ts index f8add4a5b..3fabe51ad 100644 --- a/packages/cli-doctor/src/tools/healthchecks/__tests__/androidNDK.test.ts +++ b/packages/cli-doctor/src/tools/healthchecks/__tests__/androidNDK.test.ts @@ -33,7 +33,7 @@ describe('androidNDK', () => { // To avoid having to provide fake versions for all the Android SDK tools // @ts-ignore environmentInfo.SDKs['Android SDK'] = { - 'Android NDK': '18', + 'Android NDK': '22', }; const diagnostics = await androidNDK.getDiagnostics(environmentInfo); expect(diagnostics.needsToBeFixed).toBe(true); @@ -43,7 +43,7 @@ describe('androidNDK', () => { // To avoid having to provide fake versions for all the Android SDK tools // @ts-ignore environmentInfo.SDKs['Android SDK'] = { - 'Android NDK': '19', + 'Android NDK': '23', }; const diagnostics = await androidNDK.getDiagnostics(environmentInfo); expect(diagnostics.needsToBeFixed).toBe(false); diff --git a/packages/cli-doctor/src/tools/versionRanges.ts b/packages/cli-doctor/src/tools/versionRanges.ts index 80eba6955..03301da91 100644 --- a/packages/cli-doctor/src/tools/versionRanges.ts +++ b/packages/cli-doctor/src/tools/versionRanges.ts @@ -6,8 +6,8 @@ export default { RUBY: '>= 2.7.6', JAVA: '>= 11', // Android - ANDROID_SDK: '>= 31.x', - ANDROID_NDK: '>= 19.x', + ANDROID_SDK: '>= 33.x', + ANDROID_NDK: '>= 23.x', // iOS XCODE: '>= 12.x', COCOAPODS: '>= 1.10.0',