Revert "Revert "Feature/GitHub auth"" #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird. I’ll take a look at this over the next few days. |
|
Just to confirm, this behaviour you observed roughly matches the following:
|
|
Correct |
|
I'm going to refactor this in a bit more depth now that I have a better understanding on how to structure function code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #99
After merging #97 and changing the oauth redirect address, redirect works fine, but it does not display as logged in after the redirect.
Since I could not quickly figure out what was happening, I reverted the merge. Then revert the revert is the fastest way I figured out to get another preview up. Now that the redirect URL pointing at this PR's preview address, and it's working fine.
Very dubious