Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: effect-ts resolver #676

Merged
merged 7 commits into from
May 11, 2024

Conversation

binaryartifex
Copy link
Contributor

Initial submission of an effect-ts compatible react-hook-form resolver that accepts schemas from the @effect/schema library.

bluebill1049
bluebill1049 previously approved these changes May 7, 2024
Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bluebill1049
bluebill1049 previously approved these changes May 7, 2024
@binaryartifex
Copy link
Contributor Author

binaryartifex commented May 7, 2024

@bluebill1049 cheers for the approvals mate. but im at a loss now as to how to fix this last failing check...generate a whole new pnpm-lock file maybe? im cautious of doing that as its bitten me in the ass in the past, especially with older or legacy transient packages in the mix...

@binaryartifex
Copy link
Contributor Author

so it looks like the lockfile pnpm version got bumped from 6 to 9. the github workflows in the lib that leverage pnpm/action-setup@v2 are all set to use version 7. According to a few discussions, namely here and here, this might be the issue...

@bluebill1049
Copy link
Member

@bluebill1049 cheers for the approvals mate. but im at a loss now as to how to fix this last failing check...generate a whole new pnpm-lock file maybe? im cautious of doing that as its bitten me in the ass in the past, especially with older or legacy transient packages in the mix...

@jorisre do you have any idea on this issue? 🙏

@binaryartifex
Copy link
Contributor Author

@bluebill1049 looks like that last commit bumping the pnpm versions in the github ci scripts fixed it 👍

@bluebill1049
Copy link
Member

nice, let's go~

bluebill1049
bluebill1049 previously approved these changes May 8, 2024
@binaryartifex
Copy link
Contributor Author

@bluebill1049 all good to go mate. are there scheduled releases or anything further needed from me with this pull request? when can we expect this to be merged?

@bluebill1049
Copy link
Member

Let's release this Saturday, if something wrong I can still action it.

@bluebill1049 bluebill1049 merged commit 9ba2f89 into react-hook-form:master May 11, 2024
4 checks passed
@bluebill1049
Copy link
Member

looks like need to upgrade node to 20:
image

Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jorisre added a commit that referenced this pull request Jul 2, 2024
* feat: effect-ts resolver

* refactor(effect-ts): replace spread operator with explicit assignment

* fix(effect-ts): provide build aliases for globals

* fix(effect-ts): include effect-ts in node-13-exports config

* fix(ci): bumped workflow pnpm action setups to version 9

* docs(effect-ts): add quickstart guide to readme

* refactor(effect-ts): optimize imports for better tree shaking, add encode generic, allow for async transforms

---------

Co-authored-by: Trent Cox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants