Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should react-dnd try to overcome Parcel bundling issues? #945

Closed
youknowriad opened this issue Jan 7, 2018 · 2 comments
Closed

Should react-dnd try to overcome Parcel bundling issues? #945

youknowriad opened this issue Jan 7, 2018 · 2 comments

Comments

@youknowriad
Copy link

Related discussion https://twitter.com/riadbenguella/status/949932743810535424

React DnD is not usable right now with the parcel bundler. This is not an issue with "react-dnd" but more about how Parcel handles/transpiles dependencies. If it finds a .babelrc file on the dependency, it tries to transpile the said package using this config.

React DnD (in parcel) suffers from this issue due to the disposable package here gaearon/disposables#7

I just wanted to ask if you think it's a good idea to try to overcome this by ignoring .babelrc while publishing the modules or should we just wait on a decision from the parcel bundler maintainers. Discussion here parcel-bundler/parcel#13

Thanks

@gaearon
Copy link
Member

gaearon commented Jan 7, 2018

I wanted to transfer disposables to this org but forgot my password and github locked me out. So I just went ahead and published [email protected] without .babelrc.

I wish we did a better job educating people in the issues about this instead of treating it as a real problem. Just explaining that you're not supposed to be compiling node_modules with Babel would probably be a good idea and save people some confusion in those threads. :-) I understand if the current maintainers didn't have time for this (maybe somebody wants to help?)

@youknowriad
Copy link
Author

Closing as this not an issue anymore with [email protected]. Thanks Dan, continuing the discussion about parcel in parcel-bundler/parcel#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants