Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the duplicated aria-hidden element being attached to DOM #419

Open
patrickomeara opened this issue Jul 28, 2021 · 3 comments
Open

Comments

@patrickomeara
Copy link

Thanks for your work on #385 @zombieJ.

Is there a way to prevent the aria-hidden element being added to the DOM?

The upgrade to antd 4.16 has caused many issues in our app. Our component and browsers tests now fail due to duplicate elements and nested Modals that use portals within the Menu.Items now display twice.

Preventing the hidden component being attached to the DOM would prevent both of these issues.

Originally posted by @patrickomeara in #385 (comment)

@HardDoer
Copy link

HardDoer commented Feb 25, 2022

Same problem here. This completely breaks our browser tests as there are now duplicate id:s in the menu. Please fix ASAP.

@michael-vasyliv
Copy link

+1, I have the same issue, it does not work well for automation testing because it selects two elements instead of one

@michael-vasyliv
Copy link

is it possible to add a flag to avoid this line?

<div style={{ display: 'none' }} aria-hidden>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants