fix: root-close firing immediately in react 17 #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyletsang do we know what the deal is with the macOS brew failures in CI here? |
|
I'm not sure. I've seen this error about a week ago, but thought it resolved itself as subsequent jobs were run successfully. I'll take a look later when I get some time. |
|
@jquense, found this upstream issue: actions/runner-images#1811 |
kyletsang
added a commit
to kyletsang/react-overlays
that referenced
this pull request
Nov 6, 2020
kyletsang
added a commit
that referenced
this pull request
Nov 6, 2020
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
love getting to used ancient janky DOM APIs. I think this is a nice simple fix