Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #294

Closed
nip3o opened this issue May 13, 2019 · 12 comments
Closed

New release #294

nip3o opened this issue May 13, 2019 · 12 comments

Comments

@nip3o
Copy link

nip3o commented May 13, 2019

It's been a while and a couple of bug fixes since the latest release, maybe it's time for a new one?

@bpas247
Copy link
Member

bpas247 commented Jul 21, 2019

@taion @jquense how do we feel about this? We're currently experiencing a block for react-bootstrap at this PR because we haven't published a new release yet.

Is there anything left we should do before releasing the next version?

@jquense
Copy link
Member

jquense commented Jul 22, 2019

we need to get #299 in

@jquense
Copy link
Member

jquense commented Jul 22, 2019

we could maybe release a prerelease v3 tho here

@nip3o
Copy link
Author

nip3o commented Aug 26, 2019

@jquense the popper PR is merged now, any more stuff that we need to wait on?

@mxschmitt
Copy link
Member

mxschmitt commented Aug 26, 2019

Maybe we can release our first version with semantic-release once #372 is merged. @bpas247

@boxfoot
Copy link

boxfoot commented Aug 27, 2019

I also ran into this -- saw a tag v2 and tried to use the code as written here, but it kept failing and it took me a while to figure out I was still running v1.2 which is the most recent version on npm.

Since v2 has been tagged in this repo, would you be open to publishing to npm (even as pre-release) so we can have access to it?

@TrySound
Copy link
Contributor

@taion @jquense @bpas247 Is there a problem with new release? Would be good to get rid from commonjs dom-helpers.

@boxfoot
Copy link

boxfoot commented Sep 12, 2019

As a work-around, I forked the repo and set up a branch that includes the compiled versions of scripts so I could install the new version as a git dependency. Feel free to use it until the new version is published on npm. https://github.com/boxfoot/react-overlays/tree/include-build

npm install --save github:boxfoot/react-overlays#include-build

@bpas247
Copy link
Member

bpas247 commented Sep 13, 2019

wasn't v2.0.0-0 already released though? you could just bump your version to that.

@boxfoot
Copy link

boxfoot commented Sep 13, 2019

@bpas247 it's been tagged here in the repo, but hasn't been published to npm

image

But ye: Given that the release has been tagged here, and the code as tagged is working for me in my fork, it seems like publishing would be pretty easy.

@TrySound
Copy link
Contributor

TrySound commented Sep 13, 2019

@boxfoot It's published
image

@bpas247
Copy link
Member

bpas247 commented Oct 8, 2019

Closing this now as the new release was published 😃

@bpas247 bpas247 closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants