Fix modal focus #277
Merged
Fix modal focus #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an annoying bug that deserves a better solution but i've no time for that :P What happens is that in the stacked case the lower modal's enforceFocus runs before the new modal is added to the modal stack so the lower one still thinks it's on top.
taion
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
so the pattern is something like:
- user clicks on a button in modal 1
- this button opens modal 2
- before modal 2 mounts, the focus callback handler fires and drops the focus in modal 1
- autofocus is disabled on modal 2, so nothing moves the focus into modal 2
i don't suppose there's a straightforward way to add a test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.