Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

IdentityManager should reject promise or return nothing, if no user information was found #48

Closed
Endebert opened this issue Jun 22, 2016 · 1 comment

Comments

@Endebert
Copy link
Contributor

If discoverUserRegistered is called and no user information was found, i.e. registry returns with "No information could be found", the IdentityManager should not return this string, and instead either reject the promise or resolve it without anything.

In the code I see that the IdentityManager doesn't check the message code when handling the reply, which might be the reason for this problem. However, if the registry returns the string "No information could be found" with the code 200, it should be changed to use an error code in such case instead.

@gamdias
Copy link
Contributor

gamdias commented Jul 13, 2016

Thanks for the bug detection.

The IdentityManager lib now throws reject, when no user is found.

If you see any other bug or problem, please open the issue and report :)

@gamdias gamdias closed this as completed Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants