Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find package.json for @react-rxjs/* #198

Closed
cabello opened this issue May 17, 2021 · 2 comments
Closed

Unable to find package.json for @react-rxjs/* #198

cabello opened this issue May 17, 2021 · 2 comments

Comments

@cabello
Copy link

cabello commented May 17, 2021

Hi @josepot 👋

I hope you are doing great!

I noticed while running yarn storybook the following warning:

WARN unable to find package.json for @react-rxjs/core
WARN unable to find package.json for @react-rxjs/utils

I know is just a warning and probably does not affect anything, I am also unsure how to address it because I did check your source files and I found the package.json for utils.

Nonetheless I thought you should know about this warning!

Take care,
🙇

@josepot
Copy link
Member

josepot commented May 21, 2021

Hi @cabello 👋

Thanks a lot for reporting this! Yeah, there is something definitely off with our current builds, we've also noticed some oddities while using @react-rxjs/core with node.js 🤔

If you could please set up a basic repo that reproduces this issue, that would be a huge help for us 🙏 Otherwise, I'm going to hope that the changes that we want to make for fixing the SSR issue also address this... 😬

@voliva
Copy link
Collaborator

voliva commented Jun 9, 2021

Hey, I looked a bit into this issue, and I think it's on storybook.

There's quite a few issues there that show this same warning for different libraries, and in this one storybookjs/storybook#13099 they recently fixed it.

I coudn't find what's the reason storybook would show this warning for some libraries, there were some workarounds but I didn't understand what was the underlying problem.

Anyway, I just tried it by upgrading storybook to the next version with npx sb upgrade --prerelease and the warning is gone 🎉 - I'm closing this issue, but let's open it back if we see it still causes other problems.

@voliva voliva closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants