Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pandoc formats from integration tests #1113

Open
jochenklar opened this issue Aug 11, 2024 · 4 comments
Open

Remove pandoc formats from integration tests #1113

jochenklar opened this issue Aug 11, 2024 · 4 comments
Labels
type:maintenance

Comments

@jochenklar
Copy link
Member

jochenklar commented Aug 11, 2024 •
edited
Loading

I think it would suffice to test the different pandoc formats once in a unit test (rdmo/core/tests/test_pandoc.py) and remove the parametrization from the other tests (and use only html as format). This should save some time.
@afuetterer
Copy link
Member

I think the most expensive scenario is the pdf generation.

@afuetterer
Copy link
Member

Related #1092

@jochenklar
Copy link
Member Author

Great, mocking the test is actually more elegant than just leaving it out.

@afuetterer
Copy link
Member

See related PR #1117, let's discuss details in the PR, alright?

@afuetterer afuetterer changed the title Remove pandoc formats from intergration tests Remove pandoc formats from integration tests Aug 13, 2024
@afuetterer afuetterer mentioned this issue Aug 15, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jochenklar @afuetterer