Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement range of text edit in completion items is too broad #93

Closed
rcjsuen opened this issue Sep 19, 2021 · 0 comments
Closed

Replacement range of text edit in completion items is too broad #93

rcjsuen opened this issue Sep 19, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Sep 19, 2021

This seems to be a regression introduced by the fix for #60.

const lib = require("dockerfile-language-service");
const service = lib.DockerfileLanguageServiceFactory.createLanguageService();
const items = service.computeCompletionItems("FROM node\nMAIN", { line: 1, character: 4 });
console.log(items[0].textEdit.range);
{ start: { line: 0, character: 9 }, end: { line: 1, character: 4 } }

start should be { line: 1, character: 0 } instead.

@rcjsuen rcjsuen added the bug Something isn't working label Sep 19, 2021
@rcjsuen rcjsuen self-assigned this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant