Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest working directories when editing the last argument of an ADD or COPY instruction #77

Closed
rcjsuen opened this issue Feb 27, 2021 · 1 comment
Closed

Suggest working directories when editing the last argument of an ADD or COPY instruction #77

rcjsuen opened this issue Feb 27, 2021 · 1 comment
Assignees
@rcjsuen
Labels
enhancement New feature or request

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Feb 27, 2021

The final argument of an ADD or COPY instruction is either the name of a file or a folder. While it is not possible to deduce what folders exist on an image, we know with certainty that any directory defined by a prior WORKDIR instruction is valid. We should suggest these paths when we compute completion items.
@rcjsuen rcjsuen added the enhancement New feature or request label Feb 27, 2021
@rcjsuen rcjsuen self-assigned this Feb 27, 2021
@rcjsuen rcjsuen mentioned this issue Feb 28, 2021
Open
@rcjsuen
Copy link
Owner Author

rcjsuen commented Feb 28, 2021

This has now been implemented. ADD and COPY instructions written in JSON form will be handled in #79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen