Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build stages should not be included as a link #68

Closed
rcjsuen opened this issue Jun 5, 2020 · 0 comments
Closed

Build stages should not be included as a link #68

rcjsuen opened this issue Jun 5, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jun 5, 2020

FROM alpine AS base
FROM base
import { DockerfileLanguageServiceFactory } from 'dockerfile-language-service';
const service = DockerfileLanguageServiceFactory.createLanguageService();
let items = service.computeLinks("FROM alpine AS base\nFROM base");
console.log(items);
[ { range: { start: [Object], end: [Object] }, data: '_/alpine/' },
  { range: { start: [Object], end: [Object] }, data: '_/base/' } ]

Only the first line should be a valid link to Docker Hub. We shouldn't be returning two items here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant