Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded comments with a trailing escape character disables hovers for variables that follow it #62

Closed
rcjsuen opened this issue Mar 8, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Mar 8, 2020

FROM alpine
ENV var=value
RUN a \
#c \
$var

Hovering over $var should resolve to value.

import { DockerfileLanguageServiceFactory } from './main'
const service = DockerfileLanguageServiceFactory.createLanguageService();
let content =
    `FROM alpine
ENV var=value
RUN a \\
#c \\
$var`;
let items = service.computeHover(content, { line: 4, character: 3 });
console.log(items);

However, null is returned instead.

null
@rcjsuen rcjsuen added the bug Something isn't working label Mar 8, 2020
@rcjsuen rcjsuen self-assigned this Mar 8, 2020
@rcjsuen rcjsuen closed this as completed in b7960e6 Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant