Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover cannot be displayed for an instruction keyword that spans multiple lines #59

Closed
rcjsuen opened this issue Mar 7, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Mar 7, 2020

FR\

OM scratch
$ docker build .
Sending build context to Docker daemon  38.15MB
[WARNING]: Empty continuation line found in:
    FROM scratch
[WARNING]: Empty continuation lines will become errors in a future release.
Step 1/1 : FROM scratch
 ---> 
No image was generated. Is your Dockerfile empty?

No one will create the above Dockerfile but it is valid despite the empty continuation line. All that extra space should be collapsed into a FROM but we're not accounting for this in the hover code.

import { DockerfileLanguageServiceFactory } from 'dockerfile-language-service';
const service = DockerfileLanguageServiceFactory.createLanguageService();
const hover = service.computeHover("FR\\\n\nOM scratch", { line: 0, character: 1 });
console.log(hover);
undefined
@rcjsuen rcjsuen added the bug Something isn't working label Mar 7, 2020
@rcjsuen rcjsuen self-assigned this Mar 7, 2020
@rcjsuen rcjsuen closed this as completed in 12fd31f Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant