Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code completion support for the --start-interval HEALTHCHECK flag #117

Closed
prikhi opened this issue Jul 12, 2023 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@prikhi
Copy link

prikhi commented Jul 12, 2023

The HEALTHCHECK command supports a --start-interval=<duration> flag that controls the check's interval during the specified --start-period:

https://docs.docker.com/engine/reference/builder/#healthcheck

@rcjsuen
Copy link
Owner

rcjsuen commented Sep 9, 2023

Hello, @prikhi. What feature or features are you looking for with regards to this new flag?

@prikhi
Copy link
Author

prikhi commented Sep 9, 2023

The autocompletion doesn't include it & if I put it in manually I get an Unknown flag: start-interval error

@rcjsuen
Copy link
Owner

rcjsuen commented Sep 9, 2023

The autocompletion doesn't include it & if I put it in manually I get an Unknown flag: start-interval error

Thank you for clarifying what features you are interested in.

The false positive in the linter is tracked by rcjsuen/dockerfile-utils#115. I will make sure support for code completion is implemented as well.

@rcjsuen rcjsuen changed the title Add Support for --start-interval HEALTHCHECK Flag Add code completion support for the --start-interval HEALTHCHECK flag Sep 9, 2023
@rcjsuen rcjsuen self-assigned this Sep 9, 2023
@rcjsuen rcjsuen added the enhancement New feature or request label Sep 9, 2023
@rcjsuen rcjsuen closed this as completed in c6972a1 Sep 9, 2023
@rcjsuen
Copy link
Owner

rcjsuen commented Sep 10, 2023

@prikhi This is now included in 0.11.0 of the language service and 0.11.0 of the language server. Thank you for bringing this to our attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants