Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a diagnostic if HEALTHCHECK's retries flag is not a positive integer #89

Closed
rcjsuen opened this issue Jul 19, 2017 · 0 comments
Closed
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 19, 2017

The value for the retries flag must be a positive integer. We should create a diagnostic for this error.

FROM alpine
HEALTHCHECK --retries=0 CMD ls
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM alpine
 ---> 7328f6f8b418
Step 2/2 : HEALTHCHECK --retries=0 CMD ls
--retries must be at least 1 (not 0)
FROM alpine
HEALTHCHECK --retries=-1 CMD ls
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM alpine
 ---> 7328f6f8b418
Step 2/2 : HEALTHCHECK --retries=-1 CMD ls
--retries must be at least 1 (not -1)
@rcjsuen rcjsuen self-assigned this Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant