Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completion items for HEALTHCHECK CMD flags #69

Closed
rcjsuen opened this issue Jul 14, 2017 · 0 comments
Closed

Add completion items for HEALTHCHECK CMD flags #69

rcjsuen opened this issue Jul 14, 2017 · 0 comments
Assignees
@rcjsuen

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 14, 2017

If a HEALTHCHECK instruction is in the CMD form, the instruction supports four flags for modifying the CMD invocation.

--interval=DURATION (default: 30s)
--timeout=DURATION (default: 30s)
--start-period=DURATION (default: 0s)
--retries=N (default: 3)

We should provide completion items for these four flags.
rcjsuen added a commit that referenced this issue Jul 17, 2017
@rcjsuen
WIP #69 Suggest completion items for HEALTHCHECK flags
fcf3c20 
First pass at providing completion items for HEALTHCHECK flags.

Also made the space character a trigger character for
textDocument/completion as it will likely be invoked in succession
for HEALTHCHECK instructions.

Signed-off-by: Remy Suen <[email protected]>
This was referenced Jul 19, 2017
Closed
Closed
@rcjsuen rcjsuen assigned rcjsuen and unassigned rcjsuen Jul 25, 2017
rcjsuen added a commit that referenced this issue Jan 17, 2018
@rcjsuen
Fix #69 Refactor code to depend on dockerfile-utils
cc4d893 
Signed-off-by: Remy Suen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen