Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion items should suggest build stage names #44

Closed
rcjsuen opened this issue Jul 7, 2017 · 0 comments
Closed

Completion items should suggest build stage names #44

rcjsuen opened this issue Jul 7, 2017 · 0 comments
Assignees
@rcjsuen

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 7, 2017 

FROM alpine as setup
FROM alpine
COPY --from=

Given this Dockerfile, we should suggest setup as a completion item. Suggesting 1 is questionable as you're not supposed to refer to the current build stage but perhaps it is worth suggesting for the sake of completeness.
rcjsuen added a commit that referenced this issue Jul 16, 2017
@rcjsuen
WIP #44 Suggest build stage completion items in COPY
aa03ea0 
When copying content from a build stage, users need to enter in the
build stage's into the --from= flag of a COPY instruction. We should
parse the Dockerfile and suggest any build stage names that are found
as completion items.

Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Jul 16, 2017
@rcjsuen
WIP #44 Trigger completion if equals is pressed
0e0fe58 
As the --from= flag has an equals sign at the end, we should trigger
completion when the equals sign is pressed by the user.

Signed-off-by: Remy Suen <[email protected]>
@rcjsuen rcjsuen assigned rcjsuen and unassigned rcjsuen Jul 25, 2017
@rcjsuen rcjsuen mentioned this issue Aug 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen