Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackoverflow for invalid ENV statement #246

Closed
RunDevelopment opened this issue Nov 30, 2020 · 4 comments
Closed

Stackoverflow for invalid ENV statement #246

RunDevelopment opened this issue Nov 30, 2020 · 4 comments
Assignees
Labels

Comments

@RunDevelopment
Copy link

I'm using VS Code's Docker extension which uses your language server. I noticed that syntax highlighting breaks for the input:

ENV DEBIAN_FRONTEND \
noninteractive

The output panel logs:

[Error - 2:50:00 PM] Request textDocument/semanticTokens failed.
  Message: Request textDocument/semanticTokens failed with message: Maximum call stack size exceeded
  Code: -32603 

This is invalid code, so I can understand if this issue was closed as a non-issue. I reported it anyway because the underlying issue might also affect valid code.

@rcjsuen
Copy link
Owner

rcjsuen commented Dec 18, 2020

@RunDevelopment Thank you for opening this bug report. Apologies for not getting back to you until now. I am able to reproduce this issue in VS Code.

Looks like this has been fixed by rcjsuen/dockerfile-language-service#76 so the Docker extension will be able to pick this up when I make a new release.

I'll leave this open for now until the change gets rolled into the language server itself.

@rcjsuen rcjsuen self-assigned this Dec 18, 2020
@rcjsuen rcjsuen added the bug label Dec 18, 2020
@rcjsuen
Copy link
Owner

rcjsuen commented Dec 25, 2020

@RunDevelopment The fix is now live in master. Thanks again for your bug report!

@rcjsuen
Copy link
Owner

rcjsuen commented Dec 26, 2020

@RunDevelopment I've opened a pull request with VS Code's Docker extension to get the new release adopted, see microsoft/vscode-docker#2585.

@RunDevelopment
Copy link
Author

Thank you @rcjsuen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants