Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a reasonable default for folding options' range limit if unset or incorrect #229

Closed
rcjsuen opened this issue Aug 22, 2018 · 0 comments
Assignees
Labels

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 22, 2018

https://github.com/rcjsuen/dockerfile-language-server-nodejs/blob/e20b891200d825e0e1de2dfad047034639cdfc80/src/server.ts#L141-L145

Instead of returning some undefined value (if unset) or a random string/boolean (if the value is wrong type), we should return Number.MAX_VALUE instead.

@rcjsuen rcjsuen self-assigned this Aug 22, 2018
@rcjsuen rcjsuen added bug and removed enhancement labels Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant