Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret language client's support for deprecated fields in CompletionItem #224

Closed
rcjsuen opened this issue Jul 6, 2018 · 0 comments
Closed
Assignees
Labels

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 6, 2018

At the moment, CompletionItems are sent back to the language client with the deprecated field unfilled even though we claim we support it. Although dockerfile-language-service 0.0.5 was adopted when fixing #223, the service's corresponding capability must be set in order to get the field filled in.

We need to inspect the language client's support for deprecated fields in CompletionItem and then flag it as such to the service so that we get the right stuff returning back to the client.

This is technically a new feature but going to set this as a bug since we claimed we supported something when we actually didn't.

@rcjsuen rcjsuen added the bug label Jul 6, 2018
@rcjsuen rcjsuen self-assigned this Jul 6, 2018
@rcjsuen rcjsuen closed this as completed in 6f2cd01 Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant