Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instructionJSONInSingleQuotes setting is ignored #218

Closed
rcjsuen opened this issue Apr 14, 2018 · 1 comment
Closed

instructionJSONInSingleQuotes setting is ignored #218

rcjsuen opened this issue Apr 14, 2018 · 1 comment
Assignees
@rcjsuen
Labels
bug

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Apr 14, 2018

Due to a bad case of copy/paste in a0ee572, the instructionJSONInSingleQuotes setting doesn't work because instructionJSONInSingleQuotes is incorrectly reading and using the value of instructionHealthcheckMultiple.

https://github.com/rcjsuen/dockerfile-language-server-nodejs/blob/d34e4f250b25a1d1e015a14acd32ee76599b8741/src/server.ts#L174-L182
@rcjsuen rcjsuen added the bug label Apr 14, 2018
@rcjsuen rcjsuen self-assigned this Apr 14, 2018
@rcjsuen
Copy link
Owner Author

rcjsuen commented Apr 14, 2018

It seems like I also completely forgot to consider the case where the client does not support workspace/configuration requests. I did not add code to support the instructionJSONInSingleQuotes in the global settings case.

@rcjsuen rcjsuen mentioned this issue Jan 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen