Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for textDocument/documentLink #204

Closed
rcjsuen opened this issue Feb 10, 2018 · 2 comments
Closed

Add support for textDocument/documentLink #204

rcjsuen opened this issue Feb 10, 2018 · 2 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Feb 10, 2018

We should create links to images hosted in Docker Hub based on their names in a FROM instruction.

FROM node
FROM microsoft/dotnet:sdk

Given the above Dockerfile, it should be possible to click on node to navigate to hub.docker.com/_/node and clicking on microsoft/dotnet-sdk should navigate to hub.docker.com/r/microsoft/dotnet.
@rcjsuen rcjsuen changed the title Add support for textDocument/documentLink and documentLink/resolve Add support for textDocument/documentLink Feb 10, 2018
@rcjsuen rcjsuen self-assigned this Feb 10, 2018
@rcjsuen
Copy link
Owner Author

rcjsuen commented Feb 10, 2018

Not really sure how to implement documentLink/resolve (see microsoft/language-server-protocol#401) so we're going to only implement textDocument/documentLink for now.

@rcjsuen
Copy link
Owner Author

rcjsuen commented Feb 10, 2018

Fixed by b5cfca9. I forgot to include the issue in the commit message's summary. :(

@rcjsuen rcjsuen closed this as completed Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen