Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature help appears in a comment contained in a multiline instruction #195

Closed
rcjsuen opened this issue Dec 6, 2017 · 0 comments
Closed

Signature help appears in a comment contained in a multiline instruction #195

rcjsuen opened this issue Dec 6, 2017 · 0 comments
Assignees
@rcjsuen
Labels
bug

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Dec 6, 2017 

ENV key=value \
# 
ENV key=value \
# 
key2=value2

If you enter spaces in the embedded comment on the second line of the ENV instruction, signature help will be provided even though the user is currently in a comment. Signature help should instead not be provided or shown in this scenario.
@rcjsuen rcjsuen added the bug label Dec 6, 2017
@rcjsuen rcjsuen self-assigned this Dec 6, 2017
@rcjsuen rcjsuen closed this as completed in 92ed982 Dec 6, 2017
rcjsuen added a commit that referenced this issue Dec 7, 2017
@rcjsuen
Fix #195 Update CHANGELOG.md
df9314b 
Signed-off-by: Remy Suen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen