Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables in singly quoted LABEL values should be ignored #191

Closed
rcjsuen opened this issue Nov 10, 2017 · 0 comments
Closed

Variables in singly quoted LABEL values should be ignored #191

rcjsuen opened this issue Nov 10, 2017 · 0 comments
Assignees
Labels

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Nov 10, 2017

Variables that are referred in singly quoted LABEL values are having features enabled for them when they shouldn't be. For example, selecting it will cause other instances to be highlighted and hovering over it will display a value even though the actual label in the built Docker image uses the raw string instead of the variable's expanded value. Similarly, textDocument/definition requests will be honoured to jump to the variable's definition even though it shouldn't actually be identified as a variable.

FROM scratch
ARG arg="a"
ENV var="value"
ENV var2='value2'
LABEL a=$var b="$var" c='$var'
LABEL d=$var2 e="$var2" f='$var2'
LABEL g=$arg h="$arg" i='$arg'
"Labels": {
	"a": "value",
	"b": "value",
	"c": "$var",
	"d": "value2",
	"e": "value2",
	"f": "$var2",
	"g": "a",
	"h": "a",
	"i": "$arg"
}
@rcjsuen rcjsuen added the bug label Nov 10, 2017
@rcjsuen rcjsuen self-assigned this Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant