Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Docker image for running the language server #189

Closed
rcjsuen opened this issue Oct 25, 2017 · 1 comment
Closed

Create Docker image for running the language server #189

rcjsuen opened this issue Oct 25, 2017 · 1 comment
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Oct 25, 2017

Now that the CLI has improved with the closure of #79, we should create a Docker image for running the docker-langserver binary.
rcjsuen added a commit that referenced this issue Oct 27, 2017
@rcjsuen
WIP #189 Add a Dockerfile to build the language server
6876664 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Oct 27, 2017
@rcjsuen
WIP #189 Make the docker-langserver binary executable
7f73c71 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Oct 27, 2017
@rcjsuen
WIP #189 Build and push the Docker image
d27f56b 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Oct 27, 2017
@rcjsuen
WIP #189 Ensure that the Docker image has node_modules/
2a81640 
Signed-off-by: Remy Suen <[email protected]>
@rcjsuen
Copy link
Owner Author

rcjsuen commented Oct 27, 2017

There is now an rcjsuen/docker-langserver image available on Docker Hub.

rcjsuen added a commit that referenced this issue Nov 13, 2017
@rcjsuen
Update the CHANGELOG.md with the fix for #189
9655bca 
Signed-off-by: Remy Suen <[email protected]>
@rcjsuen rcjsuen self-assigned this Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen