Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot connect server with socket #178

Closed
afrikaan-official opened this issue Sep 20, 2017 · 6 comments
Closed

cannot connect server with socket #178

afrikaan-official opened this issue Sep 20, 2017 · 6 comments
Assignees
Labels

Comments

@afrikaan-official
Copy link

afrikaan-official commented Sep 20, 2017

i'm trying to play with this language server but i've got a problem

cloned the repo build with the command npm run build and runned the server node .\out\src\server.js --socket 4001 and tried to connect with html5 web sockets server dropped with no error.

any suggestions?

@rcjsuen
Copy link
Owner

rcjsuen commented Sep 20, 2017

Hi @kyurdakok, thank you for your interest in this project and for opening this bug report.

To be completely, I am not sure if the socket support is working properly. Please see microsoft/vscode-languageserver-node#245 and Microsoft/vscode-languageserver-node-example#37.

@rcjsuen
Copy link
Owner

rcjsuen commented Oct 2, 2017

Looks like this problem has supposedly been fixed upstream per the closing of microsoft/vscode-languageserver-node#245. Will have to do some testing to verify the fix.

@rcjsuen rcjsuen added the bug label Oct 7, 2017
@rcjsuen
Copy link
Owner

rcjsuen commented Oct 7, 2017

I believe the fix that upstream has delivered is incorrect. I have posted my findings on Microsoft/vscode-languageserver-node#245.

@rcjsuen
Copy link
Owner

rcjsuen commented Oct 12, 2017

Looks like the fix was actually fine. The client needs to be the one listening for connections instead of trying to connect to the language server. The language server will attempt to connect to the specified port so the client needs to listen for connections on the specified port before starting up the language server.

@rcjsuen rcjsuen self-assigned this Oct 13, 2017
@rcjsuen
Copy link
Owner

rcjsuen commented Oct 13, 2017

@kyurdakok Socket support should now be working with dd63ee9. Don't forget to update your dependencies with npm install. You can refer to the README.md file for some sample code that shows how to talk to the language server using sockets.

Thank you again for bringing this bug to our attention!

@rcjsuen
Copy link
Owner

rcjsuen commented Oct 14, 2017

I have published version 0.0.9 to npm which includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants