Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish diagnostic if HEALTHCHECK has flags but no arguments #174

Closed
rcjsuen opened this issue Sep 12, 2017 · 0 comments
Closed

Publish diagnostic if HEALTHCHECK has flags but no arguments #174

rcjsuen opened this issue Sep 12, 2017 · 0 comments
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Sep 12, 2017

The validator currently considers a flag as an argument so it doesn't warn about HEALTHCHECK instructions that don't specify a CMD or a NONE. If a HEALTHCHECK instruction has flags but no arguments, a diagnostic should be published.

FROM alpine
HEALTHCHECK --retries=3
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM alpine
 ---> 7328f6f8b418
Step 2/2 : HEALTHCHECK --retries=3
HEALTHCHECK requires at least one argument
@rcjsuen rcjsuen changed the title Publish diagnostic if HEALTHCHECK has no arguments Publish diagnostic if HEALTHCHECK has flags but no no arguments Sep 14, 2017
@rcjsuen rcjsuen changed the title Publish diagnostic if HEALTHCHECK has flags but no no arguments Publish diagnostic if HEALTHCHECK has flags but no arguments Sep 14, 2017
@rcjsuen rcjsuen self-assigned this Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant