Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add textDocument/signatureHelp support for Dockerfile instructions #162

Closed
18 tasks done
rcjsuen opened this issue Aug 23, 2017 · 1 comment
Closed
18 tasks done

Add textDocument/signatureHelp support for Dockerfile instructions #162

rcjsuen opened this issue Aug 23, 2017 · 1 comment
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 23, 2017 •
edited
Loading

Based on the state of the Dockerfile and the current cursor position, we should offer contextual signature help about an instruction and its argument(s).

  • ADD
  • ARG
  • CMD
  • COPY
  • ENTRYPOINT
  • ENV
  • EXPOSE
  • FROM
  • HEALTHCHECK
  • LABEL
  • MAINTAINER
  • ONBUILD
  • RUN
  • SHELL
  • STOPSIGNAL
  • USER
  • VOLUME
  • WORKDIR
@rcjsuen rcjsuen self-assigned this Aug 23, 2017
rcjsuen added a commit that referenced this issue Aug 23, 2017
@rcjsuen
WIP #162 Implement signature help for instructions
cad55bc 
Signature help for instruction arguments have been added for:
- ARG
- SHELL
- STOPSIGNAL
- USER
- WORKDIR

Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 23, 2017
@rcjsuen
WIP #162 Add signature help support for EXPOSE
4c41fdb 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 25, 2017
@rcjsuen
WIP #162 Add signature help for FROM
81ca03d 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 26, 2017
@rcjsuen
WIP #162 Add signature help for LABEL
139d2c9 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 27, 2017
@rcjsuen
WIP #162 Add signature help for ONBUILD
79f3c04 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 29, 2017
@rcjsuen
WIP #162 Add signature help for ENV
e108eba 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 30, 2017
@rcjsuen
WIP #162 Fix argument handling of ENV and LABEL
f10d85a 
When multiple whitespace characters are used to delimit multiple ENV
variables or LABEL metadata properties, the parser will incorrectly
identify extra arguments in the instruction. This causes an issue
when trying to process the signature information at the current text
cursor because the extra argument's range will conflict with the
expected signature parameter at the current position. The parser will
now ignore multiple whitespace characters when trying to process the
arguments of an ENV or LABEL instruction and not automatically assume
that there is a new argument to process.

Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 31, 2017
@rcjsuen
WIP #162 Add signature help for MAINTAINER
be26523 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 31, 2017
@rcjsuen
WIP #162 Add signature help for ENTRYPOINT
5928a86 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 31, 2017
@rcjsuen
WIP #162 Remove a duplicated test
3755ddf 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Aug 31, 2017
@rcjsuen
WIP #162 Add signature help for VOLUME
35db4ea 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Sep 1, 2017
@rcjsuen
WIP #162 Add signature help for RUN
0445be1 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Sep 1, 2017
@rcjsuen
WIP #162 Add signature help for ADD
a744e5d 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Sep 2, 2017
@rcjsuen
WIP #162 Add signatureHelp for COPY
41a33e9 
Signed-off-by: Remy Suen <[email protected]>
@rcjsuen rcjsuen closed this as completed in 4247173 Sep 3, 2017
@rcjsuen
Copy link
Owner Author

rcjsuen commented Sep 3, 2017

Whoops. Reopening as it's not quite done just yet. Still need to add support for the HEALTHCHECK instruction itself.

@rcjsuen rcjsuen reopened this Sep 3, 2017
@rcjsuen rcjsuen closed this as completed in 4c5b995 Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen