From b7fee48d99c844396a8cc2de61b4a91cecca02c7 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 19 May 2019 12:35:45 -0700 Subject: [PATCH 01/41] Fix issue #1282 where "rush build" did not detect changes to projects with an empty build script --- apps/rush-lib/src/logic/taskRunner/ProjectTask.ts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts b/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts index 95a7ba38a6e..2332936cf71 100644 --- a/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts +++ b/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts @@ -128,9 +128,15 @@ export class ProjectTask implements ITaskDefinition { FileSystem.deleteFile(currentDepsPath); if (!taskCommand) { - // tslint:disable-next-line:max-line-length - writer.writeLine(`The task command ${this._commandToRun} was registered in the package.json but is blank, so no action will be taken.`); - return Promise.resolve(TaskStatus.Skipped); + writer.writeLine(`The task command ${this._commandToRun} was registered in the package.json but is blank,` + + ` so no action will be taken.`); + + // Write deps on success. + if (currentPackageDeps) { + JsonFile.save(currentPackageDeps, currentDepsPath); + } + + return Promise.resolve(TaskStatus.Success); } // Run the task @@ -166,7 +172,7 @@ export class ProjectTask implements ITaskDefinition { return new Promise((resolve: (status: TaskStatus) => void, reject: (error: TaskError) => void) => { task.on('close', (code: number) => { - this._writeLogsToDisk(writer); + this._writeLogsToDisk(writer); if (code !== 0) { reject(new TaskError('error', `Returned error code: ${code}`)); From 5c1028cd035df89b643e2d7c7a0f54ac313ef085 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 19 May 2019 12:54:17 -0700 Subject: [PATCH 02/41] Improve the reporting for projects whose build script is an empty string --- apps/rush-lib/src/logic/taskRunner/ITask.ts | 6 ++++++ apps/rush-lib/src/logic/taskRunner/ProjectTask.ts | 4 ++++ apps/rush-lib/src/logic/taskRunner/TaskRunner.ts | 9 +++++++-- .../src/logic/taskRunner/test/TaskRunner.test.ts | 15 ++++++++++----- 4 files changed, 27 insertions(+), 7 deletions(-) diff --git a/apps/rush-lib/src/logic/taskRunner/ITask.ts b/apps/rush-lib/src/logic/taskRunner/ITask.ts index 01ccb88a7e8..d7c8cac06b9 100644 --- a/apps/rush-lib/src/logic/taskRunner/ITask.ts +++ b/apps/rush-lib/src/logic/taskRunner/ITask.ts @@ -21,6 +21,12 @@ export interface ITaskDefinition { */ isIncrementalBuildAllowed: boolean; + /** + * Assigned by execute(). True if the build script was an empty string. Operationally an empty string is + * like a shell command that succeeds instantly, but e.g. it would be odd to report build time statistics for it. + */ + hadEmptyScript: boolean; + /** * Method to be executed for the task. */ diff --git a/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts b/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts index 2332936cf71..8fa5c883c86 100644 --- a/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts +++ b/apps/rush-lib/src/logic/taskRunner/ProjectTask.ts @@ -42,6 +42,7 @@ export class ProjectTask implements ITaskDefinition { } public isIncrementalBuildAllowed: boolean; + public hadEmptyScript: boolean = false; private _hasWarningOrError: boolean; private _rushProject: RushConfigurationProject; @@ -64,6 +65,9 @@ export class ProjectTask implements ITaskDefinition { public execute(writer: ITaskWriter): Promise { try { const taskCommand: string = this._getScriptToRun(); + if (!taskCommand) { + this.hadEmptyScript = true; + } const deps: IPackageDependencies | undefined = this._getPackageDependencies(taskCommand, writer); return this._executeTask(taskCommand, writer, deps); } catch (error) { diff --git a/apps/rush-lib/src/logic/taskRunner/TaskRunner.ts b/apps/rush-lib/src/logic/taskRunner/TaskRunner.ts index 630f1b6691d..ba8ac88af0b 100644 --- a/apps/rush-lib/src/logic/taskRunner/TaskRunner.ts +++ b/apps/rush-lib/src/logic/taskRunner/TaskRunner.ts @@ -272,8 +272,13 @@ export class TaskRunner { * Marks a task as being completed, and removes it from the dependencies list of all its dependents */ private _markTaskAsSuccess(task: ITask): void { - this._terminal.writeLine(Colors.green(`${this._getCurrentCompletedTaskString()}` + if (task.hadEmptyScript) { + this._terminal.writeLine(Colors.green(`${this._getCurrentCompletedTaskString()}` + + `[${task.name}] had an empty script`)); + } else { + this._terminal.writeLine(Colors.green(`${this._getCurrentCompletedTaskString()}` + `[${task.name}] completed successfully in ${task.stopwatch.toString()}`)); + } task.status = TaskStatus.Success; task.dependents.forEach((dependent: ITask) => { @@ -417,7 +422,7 @@ export class TaskRunner { case TaskStatus.SuccessWithWarning: case TaskStatus.Blocked: case TaskStatus.Failure: - if (task.stopwatch) { + if (task.stopwatch && !task.hadEmptyScript) { const time: string = task.stopwatch.toString(); this._terminal.writeLine(headingColor(`${task.name} (${time})`)); } else { diff --git a/apps/rush-lib/src/logic/taskRunner/test/TaskRunner.test.ts b/apps/rush-lib/src/logic/taskRunner/test/TaskRunner.test.ts index 43d19537c6a..ce6b74212ad 100644 --- a/apps/rush-lib/src/logic/taskRunner/test/TaskRunner.test.ts +++ b/apps/rush-lib/src/logic/taskRunner/test/TaskRunner.test.ts @@ -14,7 +14,8 @@ function createDummyTask(name: string, action?: () => void): ITaskDefinition { action(); } return Promise.resolve(TaskStatus.Success); - } + }, + hadEmptyScript: false }; } @@ -95,7 +96,8 @@ describe('TaskRunner', () => { writer.write('Build step 1' + EOL); writer.writeError('Error: step 1 failed' + EOL); return Promise.resolve(TaskStatus.Failure); - } + }, + hadEmptyScript: false }); return taskRunner .execute() @@ -117,7 +119,8 @@ describe('TaskRunner', () => { writer.write('Build step 1' + EOL); writer.write('Error: step 1 failed' + EOL); return Promise.resolve(TaskStatus.Failure); - } + }, + hadEmptyScript: false }); return taskRunner .execute() @@ -139,7 +142,8 @@ describe('TaskRunner', () => { writer.write(` - unit #${i};${EOL}`); } return Promise.resolve(TaskStatus.Failure); - } + }, + hadEmptyScript: false }); return taskRunner .execute() @@ -162,7 +166,8 @@ describe('TaskRunner', () => { writer.writeError(` - error #${i}; ${EOL}`); } return Promise.resolve(TaskStatus.Failure); - } + }, + hadEmptyScript: false }); return taskRunner .execute() From 01f7a5cff85c1a4ec62e4bebb7b5ed4673c46976 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 19 May 2019 12:55:21 -0700 Subject: [PATCH 03/41] rush change --- .../octogonz-rush-issue1282_2019-05-19-19-55.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/rush/octogonz-rush-issue1282_2019-05-19-19-55.json diff --git a/common/changes/@microsoft/rush/octogonz-rush-issue1282_2019-05-19-19-55.json b/common/changes/@microsoft/rush/octogonz-rush-issue1282_2019-05-19-19-55.json new file mode 100644 index 00000000000..57e39e42f54 --- /dev/null +++ b/common/changes/@microsoft/rush/octogonz-rush-issue1282_2019-05-19-19-55.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "Fix an issue where \"rush build\" ignored changes to a project with an empty build script (GitHub #1282)", + "packageName": "@microsoft/rush", + "type": "none" + } + ], + "packageName": "@microsoft/rush", + "email": "4673363+octogonz@users.noreply.github.com" +} \ No newline at end of file From 9d6cf97f18d678de7a5a127207727a064d9c6b04 Mon Sep 17 00:00:00 2001 From: Evgeniy Timokhov Date: Tue, 21 May 2019 10:18:49 +0300 Subject: [PATCH 04/41] [api-extractor] Fixed incorrect handling "extends" tsconfig's option Fixes #1284 --- apps/api-extractor/src/api/CompilerState.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/api-extractor/src/api/CompilerState.ts b/apps/api-extractor/src/api/CompilerState.ts index f30cdd29a1e..56d3e28c1ee 100644 --- a/apps/api-extractor/src/api/CompilerState.ts +++ b/apps/api-extractor/src/api/CompilerState.ts @@ -50,15 +50,17 @@ export class CompilerState { public static create(extractorConfig: ExtractorConfig, options?: ICompilerStateCreateOptions): CompilerState { let tsconfig: {} | undefined = extractorConfig.overrideTsconfig; + let configBasePath: string = extractorConfig.projectFolder; if (!tsconfig) { // If it wasn't overridden, then load it from disk tsconfig = JsonFile.load(extractorConfig.tsconfigFilePath); + configBasePath = path.resolve(path.dirname(extractorConfig.tsconfigFilePath)); } const commandLine: ts.ParsedCommandLine = ts.parseJsonConfigFileContent( tsconfig, ts.sys, - extractorConfig.projectFolder + configBasePath ); if (!commandLine.options.skipLibCheck && extractorConfig.skipLibCheck) { From 141a1e785861d71b12be1a0ca0a2c0754baae3c7 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Fri, 24 May 2019 10:32:59 -0700 Subject: [PATCH 05/41] Added tests for generateScopedName. Made the method public for testing (let me know if there's a better way). --- core-build/gulp-core-build-sass/gulpfile.js | 1 - core-build/gulp-core-build-sass/package.json | 3 + .../gulp-core-build-sass/src/SassTask.ts | 15 +++-- .../src/test/SassTask.test.ts | 58 +++++++++++++++++++ core-build/gulp-core-build-sass/tsconfig.json | 7 ++- 5 files changed, 77 insertions(+), 7 deletions(-) create mode 100644 core-build/gulp-core-build-sass/src/test/SassTask.test.ts diff --git a/core-build/gulp-core-build-sass/gulpfile.js b/core-build/gulp-core-build-sass/gulpfile.js index 37aa39ec67b..bd411a7b85e 100644 --- a/core-build/gulp-core-build-sass/gulpfile.js +++ b/core-build/gulp-core-build-sass/gulpfile.js @@ -1,5 +1,4 @@ 'use strict'; let build = require('@microsoft/node-library-build'); -build.mocha.enabled = false; build.initialize(require('gulp')); diff --git a/core-build/gulp-core-build-sass/package.json b/core-build/gulp-core-build-sass/package.json index 433427e4ea0..3b082776a28 100644 --- a/core-build/gulp-core-build-sass/package.json +++ b/core-build/gulp-core-build-sass/package.json @@ -18,6 +18,8 @@ "dependencies": { "@microsoft/gulp-core-build": "3.9.26", "@microsoft/load-themed-styles": "1.9.1", + "@types/chai": "3.4.34", + "@types/mocha": "5.2.5", "@types/node": "8.5.8", "@types/gulp": "3.8.32", "autoprefixer": "~9.1.3", @@ -34,6 +36,7 @@ "@types/glob": "5.0.30", "@types/node-sass": "3.10.32", "@types/clean-css": "4.2.1", + "chai": "~3.5.0", "gulp": "~3.9.1" } } diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index 5d32e3e6a23..b4394eeeb42 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -91,7 +91,7 @@ export class SassTask extends GulpTask { private _modulePostCssAdditionalPlugins: postcss.AcceptedPlugin[] = [ cssModules({ getJSON: this._generateModuleStub.bind(this), - generateScopedName: this._generateScopedName.bind(this) + generateScopedName: this.generateScopedName.bind(this) }) ]; @@ -127,12 +127,17 @@ export class SassTask extends GulpTask { }).then(() => { /* collapse void[] to void */ }); } - private _generateModuleStub(cssFileName: string, json: Object): void { - _classMaps[cssFileName] = json; + public generateScopedName(name: string, fileName: string, css: string): string { + const fileBaseName: string = path.basename(fileName); + const hash: string = crypto.createHmac('sha1', fileBaseName) + .update(css) + .digest('hex') + .substring(0, 8); + return `${name}_${hash}`; } - private _generateScopedName(name: string, fileName: string, css: string): string { - return name + '_' + crypto.createHmac('sha1', fileName).update(css).digest('hex').substring(0, 8); + private _generateModuleStub(cssFileName: string, json: Object): void { + _classMaps[cssFileName] = json; } private _processFile(filePath: string): Promise { diff --git a/core-build/gulp-core-build-sass/src/test/SassTask.test.ts b/core-build/gulp-core-build-sass/src/test/SassTask.test.ts new file mode 100644 index 00000000000..71ba7b900c8 --- /dev/null +++ b/core-build/gulp-core-build-sass/src/test/SassTask.test.ts @@ -0,0 +1,58 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license. +// See LICENSE in the project root for license information. +import * as path from 'path'; +import { expect } from 'chai'; + +import { SassTask } from '../SassTask'; + +interface IScopedNameArgs { + name: string; + fileName: string; + css: string; +} + +describe('class name hashing', () => { + it('will generate different hashes for different content', (done) => { + const version1: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), + css: 'color: blue;' + }; + const version2: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), + css: 'color: pink;' + }; + const sassTask: SassTask = new SassTask(); + const output1: string = sassTask.generateScopedName( + version1.name, version1.fileName, version1.css + ); + const output2: string = sassTask.generateScopedName( + version2.name, version2.fileName, version2.css + ); + expect(output1).to.not.equal(output2); + done(); + }); + + it('will generate the same hash in a different path', (done) => { + const version1: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), + css: 'color: blue;' + }; + const version2: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Suzan', 'workspace', 'src', 'main.sass'), + css: 'color: blue;' + }; + const sassTask: SassTask = new SassTask(); + const output1: string = sassTask.generateScopedName( + version1.name, version1.fileName, version1.css + ); + const output2: string = sassTask.generateScopedName( + version2.name, version2.fileName, version2.css + ); + expect(output1).to.equal(output2); + done(); + }); +}); diff --git a/core-build/gulp-core-build-sass/tsconfig.json b/core-build/gulp-core-build-sass/tsconfig.json index c690935203f..177c7384f50 100644 --- a/core-build/gulp-core-build-sass/tsconfig.json +++ b/core-build/gulp-core-build-sass/tsconfig.json @@ -1,3 +1,8 @@ { - "extends": "./node_modules/@microsoft/rush-stack-compiler-3.2/includes/tsconfig-node.json" + "extends": "./node_modules/@microsoft/rush-stack-compiler-3.2/includes/tsconfig-node.json", + "compilerOptions": { + "types": [ + "mocha" + ] + } } From 1e2847f66044b762d59f3e1ccb73cdc4de5dc24c Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Fri, 24 May 2019 10:39:03 -0700 Subject: [PATCH 06/41] Update minor version. --- .../jowedeki-hash-fix_2019-05-24-17-37.json | 11 +++++++++++ core-build/gulp-core-build-sass/package.json | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json diff --git a/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json b/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json new file mode 100644 index 00000000000..6ac5a5a76a9 --- /dev/null +++ b/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@microsoft/gulp-core-build-sass", + "comment": "Make class name hashes consistent regardless of path.", + "type": "patch" + } + ], + "packageName": "@microsoft/gulp-core-build-sass", + "email": "halfnibble@users.noreply.github.com" +} \ No newline at end of file diff --git a/core-build/gulp-core-build-sass/package.json b/core-build/gulp-core-build-sass/package.json index 3b082776a28..1ccad9b0d21 100644 --- a/core-build/gulp-core-build-sass/package.json +++ b/core-build/gulp-core-build-sass/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/gulp-core-build-sass", - "version": "4.6.34", + "version": "4.6.35", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", From 7e5f9240ad129b9c531b916d2ba35b53f593d50b Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Fri, 24 May 2019 16:20:53 -0700 Subject: [PATCH 07/41] Make generateModuleStub public too. Both are accessed by exertnal code and should be public. Also update dependencies. --- common/config/rush/pnpm-lock.yaml | 4 ++++ core-build/gulp-core-build-sass/src/SassTask.ts | 10 +++++----- core-build/web-library-build/package.json | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml index 9c6df8ca159..5e6db32dcd8 100644 --- a/common/config/rush/pnpm-lock.yaml +++ b/common/config/rush/pnpm-lock.yaml @@ -9313,12 +9313,15 @@ packages: version: 0.0.0 'file:projects/gulp-core-build-sass.tgz': dependencies: + '@types/chai': 3.4.34 '@types/clean-css': 4.2.1 '@types/glob': 5.0.30 '@types/gulp': 3.8.32 + '@types/mocha': 5.2.5 '@types/node': 8.5.8 '@types/node-sass': 3.10.32 autoprefixer: 9.1.5 + chai: 3.5.0 clean-css: 4.2.1 glob: 7.0.6 gulp: 3.9.1 @@ -9949,6 +9952,7 @@ packages: version: 0.0.0 'file:projects/web-library-build-test.tgz': dependencies: + '@microsoft/gulp-core-build-sass': 4.6.35 '@types/jest': 23.3.11 gulp: 3.9.1 ts-jest: 22.4.6 diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index b4394eeeb42..5ab66e01b5a 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -90,7 +90,7 @@ export class SassTask extends GulpTask { private _modulePostCssAdditionalPlugins: postcss.AcceptedPlugin[] = [ cssModules({ - getJSON: this._generateModuleStub.bind(this), + getJSON: this.generateModuleStub.bind(this), generateScopedName: this.generateScopedName.bind(this) }) ]; @@ -127,6 +127,10 @@ export class SassTask extends GulpTask { }).then(() => { /* collapse void[] to void */ }); } + public generateModuleStub(cssFileName: string, json: Object): void { + _classMaps[cssFileName] = json; + } + public generateScopedName(name: string, fileName: string, css: string): string { const fileBaseName: string = path.basename(fileName); const hash: string = crypto.createHmac('sha1', fileBaseName) @@ -136,10 +140,6 @@ export class SassTask extends GulpTask { return `${name}_${hash}`; } - private _generateModuleStub(cssFileName: string, json: Object): void { - _classMaps[cssFileName] = json; - } - private _processFile(filePath: string): Promise { // Ignore files that start with underscores if (path.basename(filePath).match(/^\_/)) { diff --git a/core-build/web-library-build/package.json b/core-build/web-library-build/package.json index c9d34a8dd18..09e924e31d3 100644 --- a/core-build/web-library-build/package.json +++ b/core-build/web-library-build/package.json @@ -19,7 +19,7 @@ }, "dependencies": { "@microsoft/gulp-core-build": "3.9.26", - "@microsoft/gulp-core-build-sass": "4.6.34", + "@microsoft/gulp-core-build-sass": "4.6.35", "@microsoft/gulp-core-build-serve": "3.3.35", "@microsoft/gulp-core-build-typescript": "8.1.11", "@microsoft/gulp-core-build-webpack": "3.4.102", From e376a8d8d10de758f4529a9d14a66991a342bbc7 Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Fri, 24 May 2019 17:12:06 -0700 Subject: [PATCH 08/41] Add support for TypeScript constructors --- .../src/documenters/MarkdownDocumenter.ts | 7 +++++++ .../constructor-tsdocs_2019-05-25-03-52.json | 11 +++++++++++ 2 files changed, 18 insertions(+) create mode 100644 common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json diff --git a/apps/api-documenter/src/documenters/MarkdownDocumenter.ts b/apps/api-documenter/src/documenters/MarkdownDocumenter.ts index b664b717bca..9c6acbe0d3f 100644 --- a/apps/api-documenter/src/documenters/MarkdownDocumenter.ts +++ b/apps/api-documenter/src/documenters/MarkdownDocumenter.ts @@ -98,6 +98,10 @@ export class MarkdownDocumenter { case ApiItemKind.Interface: output.appendNode(new DocHeading({ configuration, title: `${scopedName} interface` })); break; + case ApiItemKind.Constructor: + case ApiItemKind.ConstructSignature: + output.appendNode(new DocHeading({ configuration, title: `${scopedName} constructor` })); + break; case ApiItemKind.Method: case ApiItemKind.MethodSignature: output.appendNode(new DocHeading({ configuration, title: `${scopedName} method` })); @@ -182,6 +186,8 @@ export class MarkdownDocumenter { case ApiItemKind.Interface: this._writeInterfaceTables(output, apiItem as ApiInterface); break; + case ApiItemKind.Constructor: + case ApiItemKind.ConstructSignature: case ApiItemKind.Method: case ApiItemKind.MethodSignature: case ApiItemKind.Function: @@ -387,6 +393,7 @@ export class MarkdownDocumenter { for (const apiMember of apiClass.members) { switch (apiMember.kind) { + case ApiItemKind.Constructor: case ApiItemKind.Method: { methodsTable.addRow( new DocTableRow({ configuration }, [ diff --git a/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json b/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json new file mode 100644 index 00000000000..d9736bf424e --- /dev/null +++ b/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@microsoft/api-documenter", + "comment": "allow constructor tsdocs to be generated", + "type": "patch" + } + ], + "packageName": "@microsoft/api-documenter", + "email": "enjoyjava@gmail.com" +} \ No newline at end of file From 7c249edcd84b89b2e551ba17047f1c0dbf04c8c1 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 13:34:02 -0700 Subject: [PATCH 09/41] Update changelog --- .../api-documenter/constructor-tsdocs_2019-05-25-03-52.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json b/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json index d9736bf424e..3e7a151a449 100644 --- a/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json +++ b/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json @@ -2,10 +2,10 @@ "changes": [ { "packageName": "@microsoft/api-documenter", - "comment": "allow constructor tsdocs to be generated", + "comment": "Improve the markdown generator to document class constructors", "type": "patch" } ], "packageName": "@microsoft/api-documenter", - "email": "enjoyjava@gmail.com" + "email": "raymondfeng@users.noreply.github.com" } \ No newline at end of file From 570b4fbc308b0d88a0cde741622d09ad3820cfad Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 14:23:15 -0700 Subject: [PATCH 10/41] Make the strings returned by ApiItem.displayName less verbose; improve formatting of ApiItem.getScopedNameWithinPackage() --- apps/api-extractor-model/src/items/ApiItem.ts | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/apps/api-extractor-model/src/items/ApiItem.ts b/apps/api-extractor-model/src/items/ApiItem.ts index c6abce9612e..a8e27d7ecff 100644 --- a/apps/api-extractor-model/src/items/ApiItem.ts +++ b/apps/api-extractor-model/src/items/ApiItem.ts @@ -107,9 +107,9 @@ export class ApiItem { */ public get displayName(): string { switch (this.kind) { - case ApiItemKind.CallSignature: return '(call signature)'; + case ApiItemKind.CallSignature: return '(call)'; case ApiItemKind.Constructor: return '(constructor)'; - case ApiItemKind.ConstructSignature: return '(construct signature)'; + case ApiItemKind.ConstructSignature: return '(new)'; case ApiItemKind.IndexSignature: return '(indexer)'; case ApiItemKind.Model: return '(model)'; } @@ -166,8 +166,19 @@ export class ApiItem { } if (reversedParts.length !== 0) { reversedParts.push('.'); - } else if (ApiParameterListMixin.isBaseClassOf(current)) { // tslint:disable-line:no-use-before-declare - reversedParts.push('()'); + } else { + switch (current.kind) { + case ApiItemKind.CallSignature: + case ApiItemKind.ConstructSignature: + case ApiItemKind.Constructor: + case ApiItemKind.IndexSignature: + // These functional forms don't have a proper name, so we don't append the "()" suffix + break; + default: + if (ApiParameterListMixin.isBaseClassOf(current)) { // tslint:disable-line:no-use-before-declare + reversedParts.push('()'); + } + } } reversedParts.push(current.displayName); } From 07afd0acb754360ac6c517db2abe52b52dd617e2 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 14:24:22 -0700 Subject: [PATCH 11/41] rush change --- .../constructor-tsdocs_2019-05-26-21-23.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json diff --git a/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json b/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json new file mode 100644 index 00000000000..0cd9590e51a --- /dev/null +++ b/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@microsoft/api-extractor-model", + "comment": "Make the strings returned by ApiItem.displayName less verbose", + "type": "patch" + } + ], + "packageName": "@microsoft/api-extractor-model", + "email": "4673363+octogonz@users.noreply.github.com" +} \ No newline at end of file From 33a4baccb2f8c2f748f98a7d2c274051c4d9d04f Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 14:25:17 -0700 Subject: [PATCH 12/41] rush change --- .../constructor-tsdocs_2019-05-26-21-24.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json diff --git a/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json b/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json new file mode 100644 index 00000000000..0e9b082a2ba --- /dev/null +++ b/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@microsoft/api-extractor-model", + "comment": "Improve formatting of the strings returned by ApiItem.getScopedNameWithinPackage()", + "type": "patch" + } + ], + "packageName": "@microsoft/api-extractor-model", + "email": "4673363+octogonz@users.noreply.github.com" +} \ No newline at end of file From 767874a87602a18180752c41e27eaec9a148aa5b Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 14:26:04 -0700 Subject: [PATCH 13/41] Render constructors in their own "Constructors" section, rather than in the "Methods" section --- .../src/documenters/MarkdownDocumenter.ts | 25 +++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/apps/api-documenter/src/documenters/MarkdownDocumenter.ts b/apps/api-documenter/src/documenters/MarkdownDocumenter.ts index 9c6acbe0d3f..43515916b95 100644 --- a/apps/api-documenter/src/documenters/MarkdownDocumenter.ts +++ b/apps/api-documenter/src/documenters/MarkdownDocumenter.ts @@ -100,7 +100,7 @@ export class MarkdownDocumenter { break; case ApiItemKind.Constructor: case ApiItemKind.ConstructSignature: - output.appendNode(new DocHeading({ configuration, title: `${scopedName} constructor` })); + output.appendNode(new DocHeading({ configuration, title: scopedName })); break; case ApiItemKind.Method: case ApiItemKind.MethodSignature: @@ -382,6 +382,10 @@ export class MarkdownDocumenter { headerTitles: [ 'Property', 'Modifiers', 'Type', 'Description' ] }); + const constructorsTable: DocTable = new DocTable({ configuration, + headerTitles: [ 'Constructor', 'Modifiers', 'Description' ] + }); + const propertiesTable: DocTable = new DocTable({ configuration, headerTitles: [ 'Property', 'Modifiers', 'Type', 'Description' ] }); @@ -393,7 +397,18 @@ export class MarkdownDocumenter { for (const apiMember of apiClass.members) { switch (apiMember.kind) { - case ApiItemKind.Constructor: + case ApiItemKind.Constructor: { + constructorsTable.addRow( + new DocTableRow({ configuration }, [ + this._createTitleCell(apiMember), + this._createModifiersCell(apiMember), + this._createDescriptionCell(apiMember) + ]) + ); + + this._writeApiItemPage(apiMember); + break; + } case ApiItemKind.Method: { methodsTable.addRow( new DocTableRow({ configuration }, [ @@ -440,6 +455,11 @@ export class MarkdownDocumenter { output.appendNode(eventsTable); } + if (constructorsTable.rows.length > 0) { + output.appendNode(new DocHeading({ configuration: this._tsdocConfiguration, title: 'Constructors' })); + output.appendNode(constructorsTable); + } + if (propertiesTable.rows.length > 0) { output.appendNode(new DocHeading({ configuration: this._tsdocConfiguration, title: 'Properties' })); output.appendNode(propertiesTable); @@ -509,6 +529,7 @@ export class MarkdownDocumenter { for (const apiMember of apiClass.members) { switch (apiMember.kind) { + case ApiItemKind.ConstructSignature: case ApiItemKind.MethodSignature: { methodsTable.addRow( new DocTableRow({ configuration }, [ From 7daa6a7de236e1c18227591ee5f5c9bac3dfa641 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 14:26:33 -0700 Subject: [PATCH 14/41] Add unit tests for constructors and construct signatures --- .../etc/api-documenter-test.api.json | 57 ++++++++++++++++++- .../etc/api-documenter-test.api.md | 2 + ...umenter-test.docbaseclass.(constructor).md | 13 +++++ ...enter-test.docbaseclass.(constructor)_1.md | 20 +++++++ .../api-documenter-test.docbaseclass.md | 8 +++ ...pi-documenter-test.idocinterface3.(new).md | 17 ++++++ .../api-documenter-test.idocinterface3.md | 7 +++ .../yaml/api-documenter-test/docbaseclass.yml | 26 +++++++++ .../api-documenter-test/src/DocClass1.ts | 12 ++++ 9 files changed, 161 insertions(+), 1 deletion(-) create mode 100644 build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor).md create mode 100644 build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor)_1.md create mode 100644 build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.(new).md diff --git a/build-tests/api-documenter-test/etc/api-documenter-test.api.json b/build-tests/api-documenter-test/etc/api-documenter-test.api.json index 272ba683c18..5cc252aefe0 100644 --- a/build-tests/api-documenter-test/etc/api-documenter-test.api.json +++ b/build-tests/api-documenter-test/etc/api-documenter-test.api.json @@ -34,7 +34,62 @@ ], "releaseTag": "Public", "name": "DocBaseClass", - "members": [], + "members": [ + { + "kind": "Constructor", + "canonicalReference": "(:constructor,instance,0)", + "docComment": "/**\n * The simple constructor for `DocBaseClass`\n */\n", + "excerptTokens": [ + { + "kind": "Content", + "text": "constructor();" + } + ], + "isStatic": false, + "releaseTag": "Public", + "overloadIndex": 0, + "parameters": [] + }, + { + "kind": "Constructor", + "canonicalReference": "(:constructor,instance,1)", + "docComment": "/**\n * The overloaded constructor for `DocBaseClass`\n */\n", + "excerptTokens": [ + { + "kind": "Content", + "text": "constructor(" + }, + { + "kind": "Reference", + "text": "x" + }, + { + "kind": "Content", + "text": ": " + }, + { + "kind": "Content", + "text": "number" + }, + { + "kind": "Content", + "text": ");" + } + ], + "isStatic": false, + "releaseTag": "Public", + "overloadIndex": 1, + "parameters": [ + { + "parameterName": "x", + "parameterTypeTokenRange": { + "startIndex": 3, + "endIndex": 4 + } + } + ] + } + ], "implementsTokenRanges": [] }, { diff --git a/build-tests/api-documenter-test/etc/api-documenter-test.api.md b/build-tests/api-documenter-test/etc/api-documenter-test.api.md index 92eba78b06f..39a5caa6cd8 100644 --- a/build-tests/api-documenter-test/etc/api-documenter-test.api.md +++ b/build-tests/api-documenter-test/etc/api-documenter-test.api.md @@ -9,6 +9,8 @@ export const constVariable: number; // @public export class DocBaseClass { + constructor(); + constructor(x: number); } // @public diff --git a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor).md b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor).md new file mode 100644 index 00000000000..3ee89e8decd --- /dev/null +++ b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor).md @@ -0,0 +1,13 @@ + + +[Home](./index.md) > [api-documenter-test](./api-documenter-test.md) > [DocBaseClass](./api-documenter-test.docbaseclass.md) > [(constructor)](./api-documenter-test.docbaseclass.(constructor).md) + +## DocBaseClass.(constructor) + +The simple constructor for `DocBaseClass` + +Signature: + +```typescript +constructor(); +``` diff --git a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor)_1.md b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor)_1.md new file mode 100644 index 00000000000..9df618c5f6a --- /dev/null +++ b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.(constructor)_1.md @@ -0,0 +1,20 @@ + + +[Home](./index.md) > [api-documenter-test](./api-documenter-test.md) > [DocBaseClass](./api-documenter-test.docbaseclass.md) > [(constructor)](./api-documenter-test.docbaseclass.(constructor)_1.md) + +## DocBaseClass.(constructor) + +The overloaded constructor for `DocBaseClass` + +Signature: + +```typescript +constructor(x: number); +``` + +## Parameters + +| Parameter | Type | Description | +| --- | --- | --- | +| x | number | | + diff --git a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.md b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.md index 19a41e17a3f..d616a1efdce 100644 --- a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.md +++ b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.docbaseclass.md @@ -12,3 +12,11 @@ Example base class ```typescript export declare class DocBaseClass ``` + +## Constructors + +| Constructor | Modifiers | Description | +| --- | --- | --- | +| [(constructor)()](./api-documenter-test.docbaseclass.(constructor).md) | | The simple constructor for DocBaseClass | +| [(constructor)(x)](./api-documenter-test.docbaseclass.(constructor)_1.md) | | The overloaded constructor for DocBaseClass | + diff --git a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.(new).md b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.(new).md new file mode 100644 index 00000000000..c35f0387eb8 --- /dev/null +++ b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.(new).md @@ -0,0 +1,17 @@ + + +[Home](./index.md) > [api-documenter-test](./api-documenter-test.md) > [IDocInterface3](./api-documenter-test.idocinterface3.md) > [(new)](./api-documenter-test.idocinterface3.(new).md) + +## IDocInterface3.(new) + +Construct signature + +Signature: + +```typescript +new (): IDocInterface1; +``` +Returns: + +`IDocInterface1` + diff --git a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.md b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.md index 1ddbc4017c3..eb7a995ba86 100644 --- a/build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.md +++ b/build-tests/api-documenter-test/etc/markdown/api-documenter-test.idocinterface3.md @@ -12,3 +12,10 @@ Some less common TypeScript declaration kinds. ```typescript export interface IDocInterface3 ``` + +## Methods + +| Method | Description | +| --- | --- | +| [(new)()](./api-documenter-test.idocinterface3.(new).md) | Construct signature | + diff --git a/build-tests/api-documenter-test/etc/yaml/api-documenter-test/docbaseclass.yml b/build-tests/api-documenter-test/etc/yaml/api-documenter-test/docbaseclass.yml index 4c44aadc065..b2c0a2148db 100644 --- a/build-tests/api-documenter-test/etc/yaml/api-documenter-test/docbaseclass.yml +++ b/build-tests/api-documenter-test/etc/yaml/api-documenter-test/docbaseclass.yml @@ -8,3 +8,29 @@ items: - typeScript type: class package: api-documenter-test + children: + - api-documenter-test.DocBaseClass.(constructor) + - api-documenter-test.DocBaseClass.(constructor)_1 + - uid: api-documenter-test.DocBaseClass.(constructor) + summary: The simple constructor for `DocBaseClass` + name: (constructor)() + fullName: (constructor)() + langs: + - typeScript + type: constructor + syntax: + content: constructor(); + - uid: api-documenter-test.DocBaseClass.(constructor)_1 + summary: The overloaded constructor for `DocBaseClass` + name: (constructor)(x) + fullName: (constructor)(x) + langs: + - typeScript + type: constructor + syntax: + content: 'constructor(x: number);' + parameters: + - id: x + description: '' + type: + - number diff --git a/build-tests/api-documenter-test/src/DocClass1.ts b/build-tests/api-documenter-test/src/DocClass1.ts index a608f7dbd58..84dbdc5f835 100644 --- a/build-tests/api-documenter-test/src/DocClass1.ts +++ b/build-tests/api-documenter-test/src/DocClass1.ts @@ -18,6 +18,18 @@ export class SystemEvent { * {@docCategory DocBaseClass} */ export class DocBaseClass { + /** + * The simple constructor for `DocBaseClass` + */ + public constructor(); + + /** + * The overloaded constructor for `DocBaseClass` + */ + public constructor(x: number); + + public constructor(x?: number) { + } } /** From 10ca19f94a8e955ec1b1a8b437906461d34a2b8e Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 16:54:57 -0700 Subject: [PATCH 15/41] Fix typo --- apps/rush-lib/src/cli/actions/AddAction.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/rush-lib/src/cli/actions/AddAction.ts b/apps/rush-lib/src/cli/actions/AddAction.ts index 5ae2239e780..9fdfa112064 100644 --- a/apps/rush-lib/src/cli/actions/AddAction.ts +++ b/apps/rush-lib/src/cli/actions/AddAction.ts @@ -50,7 +50,7 @@ export class AddAction extends BaseRushAction { description: '(Required) The name of the package which should be added as a dependency.' + ' A SemVer version specifier can be appended after an "@" sign. WARNING: Symbol characters' + ' are usually interpreted by your shell, so it\'s recommended to use quotes.' - + ' For example, write "rush add --project "example@^1.2.3"" instead of "rush add --project example@^1.2.3".' + + ' For example, write "rush add --package "example@^1.2.3"" instead of "rush add --package example@^1.2.3".' }); this._exactFlag = this.defineFlagParameter({ parameterLongName: '--exact', From 63fbdb9c15982edc8b36f1435bddc10d8d93fc67 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 16:55:24 -0700 Subject: [PATCH 16/41] rush change --- .../rush/octogonz-fix-typo_2019-05-26-23-55.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/rush/octogonz-fix-typo_2019-05-26-23-55.json diff --git a/common/changes/@microsoft/rush/octogonz-fix-typo_2019-05-26-23-55.json b/common/changes/@microsoft/rush/octogonz-fix-typo_2019-05-26-23-55.json new file mode 100644 index 00000000000..03d426edbc2 --- /dev/null +++ b/common/changes/@microsoft/rush/octogonz-fix-typo_2019-05-26-23-55.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "Fix typo in command-line help for \"rush add\"", + "packageName": "@microsoft/rush", + "type": "none" + } + ], + "packageName": "@microsoft/rush", + "email": "4673363+octogonz@users.noreply.github.com" +} \ No newline at end of file From a5c3152503f70e15bc4f39f538dc1f03c29c966d Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 17:06:30 -0700 Subject: [PATCH 17/41] rush change --- .../api-extractor/fix-1284_2019-05-27-00-06.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json diff --git a/common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json b/common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json new file mode 100644 index 00000000000..eff41c8806c --- /dev/null +++ b/common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@microsoft/api-extractor", + "comment": "Fix incorrect path resolution for the \"extends\" field when loading tsconfig.json", + "type": "patch" + } + ], + "packageName": "@microsoft/api-extractor", + "email": "timocov@users.noreply.github.com" +} \ No newline at end of file From e0b78a99fa706ca6e8b0cd3623b220141c48d287 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 17:43:05 -0700 Subject: [PATCH 18/41] Commit updated test output from 10ca19f94a8e955ec1b1a8b437906461d34a2b8e --- .../src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap b/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap index e483597e140..0d336691175 100644 --- a/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap +++ b/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap @@ -73,8 +73,8 @@ Optional arguments: be appended after an \\"@\\" sign. WARNING: Symbol characters are usually interpreted by your shell, so it's recommended to use quotes. For example, write - \\"rush add --project \\"example@^1.2.3\\"\\" instead of - \\"rush add --project example@^1.2.3\\". + \\"rush add --package \\"example@^1.2.3\\"\\" instead of + \\"rush add --package example@^1.2.3\\". --exact If specified, the SemVer specifier added to the package.json will be an exact version (e.g. without tilde or caret). From a4fbb868fcfe73420f6128793cff2b1526049c50 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 20:57:32 -0700 Subject: [PATCH 19/41] Fix a broken URL in README.md (Issue #1285) --- libraries/ts-command-line/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libraries/ts-command-line/README.md b/libraries/ts-command-line/README.md index dac59b3d4d9..c6778a2c7d6 100644 --- a/libraries/ts-command-line/README.md +++ b/libraries/ts-command-line/README.md @@ -189,7 +189,7 @@ You can also mix the two models. For example, we could augment the `WidgetComma ### Further reading -The [API reference](http://rushstack.io/api/ts-command-line.html) has complete documentation for the library. +The [API reference](https://microsoft.github.io/web-build-tools/api/) has complete documentation for the library. Here are some real world GitHub projects that illustrate different use cases for **ts-command-line**: From e4121e6013e37526d586b3fed28da22bed203bc4 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Sun, 26 May 2019 20:57:59 -0700 Subject: [PATCH 20/41] rush change --- ...octogonz-tsc-fix-broken-link_2019-05-27-03-57.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json diff --git a/common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json b/common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json new file mode 100644 index 00000000000..7a7783fcefa --- /dev/null +++ b/common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@microsoft/ts-command-line", + "comment": "Fix a broken link in the README.md (GitHub issue #1285)", + "type": "patch" + } + ], + "packageName": "@microsoft/ts-command-line", + "email": "4673363+octogonz@users.noreply.github.com" +} \ No newline at end of file From 18b427aa2771371cfd6f410081f0d102fcd6d4a2 Mon Sep 17 00:00:00 2001 From: Rushbot Date: Mon, 27 May 2019 04:13:50 +0000 Subject: [PATCH 21/41] Deleting change files and updating change logs for package updates. --- apps/api-documenter/CHANGELOG.json | 26 ++++++++++++++++++ apps/api-documenter/CHANGELOG.md | 9 ++++++- apps/api-extractor-model/CHANGELOG.json | 15 +++++++++++ apps/api-extractor-model/CHANGELOG.md | 10 ++++++- apps/api-extractor/CHANGELOG.json | 20 ++++++++++++++ apps/api-extractor/CHANGELOG.md | 9 ++++++- .../constructor-tsdocs_2019-05-25-03-52.json | 11 -------- .../constructor-tsdocs_2019-05-26-21-23.json | 11 -------- .../constructor-tsdocs_2019-05-26-21-24.json | 11 -------- .../fix-1284_2019-05-27-00-06.json | 11 -------- ...-tsc-fix-broken-link_2019-05-27-03-57.json | 11 -------- .../gulp-core-build-sass/CHANGELOG.json | 18 +++++++++++++ core-build/gulp-core-build-sass/CHANGELOG.md | 7 ++++- .../gulp-core-build-serve/CHANGELOG.json | 15 +++++++++++ core-build/gulp-core-build-serve/CHANGELOG.md | 7 ++++- .../gulp-core-build-typescript/CHANGELOG.json | 15 +++++++++++ .../gulp-core-build-typescript/CHANGELOG.md | 7 ++++- .../gulp-core-build-webpack/CHANGELOG.json | 15 +++++++++++ .../gulp-core-build-webpack/CHANGELOG.md | 7 ++++- core-build/node-library-build/CHANGELOG.json | 15 +++++++++++ core-build/node-library-build/CHANGELOG.md | 7 ++++- core-build/web-library-build/CHANGELOG.json | 27 +++++++++++++++++++ core-build/web-library-build/CHANGELOG.md | 7 ++++- libraries/load-themed-styles/CHANGELOG.json | 15 +++++++++++ libraries/load-themed-styles/CHANGELOG.md | 7 ++++- libraries/package-deps-hash/CHANGELOG.json | 15 +++++++++++ libraries/package-deps-hash/CHANGELOG.md | 7 ++++- libraries/stream-collator/CHANGELOG.json | 15 +++++++++++ libraries/stream-collator/CHANGELOG.md | 7 ++++- libraries/ts-command-line/CHANGELOG.json | 12 +++++++++ libraries/ts-command-line/CHANGELOG.md | 9 ++++++- stack/rush-stack-compiler-2.4/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-2.4/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-2.7/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-2.7/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-2.8/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-2.8/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-2.9/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-2.9/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-3.0/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-3.0/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-3.1/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-3.1/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-3.2/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-3.2/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-3.3/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-3.3/CHANGELOG.md | 7 ++++- stack/rush-stack-compiler-3.4/CHANGELOG.json | 12 +++++++++ stack/rush-stack-compiler-3.4/CHANGELOG.md | 7 ++++- stack/rush-stack/CHANGELOG.json | 18 +++++++++++++ stack/rush-stack/CHANGELOG.md | 7 ++++- .../loader-load-themed-styles/CHANGELOG.json | 18 +++++++++++++ .../loader-load-themed-styles/CHANGELOG.md | 7 ++++- webpack/loader-raw-script/CHANGELOG.json | 15 +++++++++++ webpack/loader-raw-script/CHANGELOG.md | 7 ++++- .../CHANGELOG.json | 18 +++++++++++++ .../CHANGELOG.md | 7 ++++- webpack/resolve-chunk-plugin/CHANGELOG.json | 15 +++++++++++ webpack/resolve-chunk-plugin/CHANGELOG.md | 7 ++++- .../CHANGELOG.json | 15 +++++++++++ .../CHANGELOG.md | 7 ++++- 61 files changed, 607 insertions(+), 83 deletions(-) delete mode 100644 common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json delete mode 100644 common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json delete mode 100644 common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json delete mode 100644 common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json delete mode 100644 common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json diff --git a/apps/api-documenter/CHANGELOG.json b/apps/api-documenter/CHANGELOG.json index 709c810c956..6f6b14a7686 100644 --- a/apps/api-documenter/CHANGELOG.json +++ b/apps/api-documenter/CHANGELOG.json @@ -1,6 +1,32 @@ { "name": "@microsoft/api-documenter", "entries": [ + { + "version": "7.2.1", + "tag": "@microsoft/api-documenter_v7.2.1", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "patch": [ + { + "comment": "Improve the markdown generator to document class constructors" + } + ], + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor-model\" from `7.1.0` to `7.1.1`" + }, + { + "comment": "Updating dependency \"@microsoft/ts-command-line\" from `4.2.4` to `4.2.5`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "7.2.0", "tag": "@microsoft/api-documenter_v7.2.0", diff --git a/apps/api-documenter/CHANGELOG.md b/apps/api-documenter/CHANGELOG.md index 7e8557e9cec..8d3cfd5e90c 100644 --- a/apps/api-documenter/CHANGELOG.md +++ b/apps/api-documenter/CHANGELOG.md @@ -1,6 +1,13 @@ # Change Log - @microsoft/api-documenter -This log was last generated on Thu, 16 May 2019 22:15:20 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 7.2.1 +Mon, 27 May 2019 04:13:44 GMT + +### Patches + +- Improve the markdown generator to document class constructors ## 7.2.0 Thu, 16 May 2019 22:15:20 GMT diff --git a/apps/api-extractor-model/CHANGELOG.json b/apps/api-extractor-model/CHANGELOG.json index d903dc53411..7830e9eeef9 100644 --- a/apps/api-extractor-model/CHANGELOG.json +++ b/apps/api-extractor-model/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/api-extractor-model", "entries": [ + { + "version": "7.1.1", + "tag": "@microsoft/api-extractor-model_v7.1.1", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "patch": [ + { + "comment": "Make the strings returned by ApiItem.displayName less verbose" + }, + { + "comment": "Improve formatting of the strings returned by ApiItem.getScopedNameWithinPackage()" + } + ] + } + }, { "version": "7.1.0", "tag": "@microsoft/api-extractor-model_v7.1.0", diff --git a/apps/api-extractor-model/CHANGELOG.md b/apps/api-extractor-model/CHANGELOG.md index 00d5d226c3b..1b770235484 100644 --- a/apps/api-extractor-model/CHANGELOG.md +++ b/apps/api-extractor-model/CHANGELOG.md @@ -1,6 +1,14 @@ # Change Log - @microsoft/api-extractor-model -This log was last generated on Tue, 16 Apr 2019 11:01:37 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 7.1.1 +Mon, 27 May 2019 04:13:44 GMT + +### Patches + +- Make the strings returned by ApiItem.displayName less verbose +- Improve formatting of the strings returned by ApiItem.getScopedNameWithinPackage() ## 7.1.0 Tue, 16 Apr 2019 11:01:37 GMT diff --git a/apps/api-extractor/CHANGELOG.json b/apps/api-extractor/CHANGELOG.json index 79b8f219d1a..d365a1bbc37 100644 --- a/apps/api-extractor/CHANGELOG.json +++ b/apps/api-extractor/CHANGELOG.json @@ -1,6 +1,26 @@ { "name": "@microsoft/api-extractor", "entries": [ + { + "version": "7.1.6", + "tag": "@microsoft/api-extractor_v7.1.6", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "patch": [ + { + "comment": "Fix incorrect path resolution for the \"extends\" field when loading tsconfig.json" + } + ], + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor-model\" from `7.1.0` to `7.1.1`" + }, + { + "comment": "Updating dependency \"@microsoft/ts-command-line\" from `4.2.4` to `4.2.5`" + } + ] + } + }, { "version": "7.1.5", "tag": "@microsoft/api-extractor_v7.1.5", diff --git a/apps/api-extractor/CHANGELOG.md b/apps/api-extractor/CHANGELOG.md index 27d6f6a848a..b42b1b82ed0 100644 --- a/apps/api-extractor/CHANGELOG.md +++ b/apps/api-extractor/CHANGELOG.md @@ -1,6 +1,13 @@ # Change Log - @microsoft/api-extractor -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 7.1.6 +Mon, 27 May 2019 04:13:44 GMT + +### Patches + +- Fix incorrect path resolution for the "extends" field when loading tsconfig.json ## 7.1.5 Mon, 13 May 2019 02:08:35 GMT diff --git a/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json b/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json deleted file mode 100644 index 3e7a151a449..00000000000 --- a/common/changes/@microsoft/api-documenter/constructor-tsdocs_2019-05-25-03-52.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@microsoft/api-documenter", - "comment": "Improve the markdown generator to document class constructors", - "type": "patch" - } - ], - "packageName": "@microsoft/api-documenter", - "email": "raymondfeng@users.noreply.github.com" -} \ No newline at end of file diff --git a/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json b/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json deleted file mode 100644 index 0cd9590e51a..00000000000 --- a/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-23.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@microsoft/api-extractor-model", - "comment": "Make the strings returned by ApiItem.displayName less verbose", - "type": "patch" - } - ], - "packageName": "@microsoft/api-extractor-model", - "email": "4673363+octogonz@users.noreply.github.com" -} \ No newline at end of file diff --git a/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json b/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json deleted file mode 100644 index 0e9b082a2ba..00000000000 --- a/common/changes/@microsoft/api-extractor-model/constructor-tsdocs_2019-05-26-21-24.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@microsoft/api-extractor-model", - "comment": "Improve formatting of the strings returned by ApiItem.getScopedNameWithinPackage()", - "type": "patch" - } - ], - "packageName": "@microsoft/api-extractor-model", - "email": "4673363+octogonz@users.noreply.github.com" -} \ No newline at end of file diff --git a/common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json b/common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json deleted file mode 100644 index eff41c8806c..00000000000 --- a/common/changes/@microsoft/api-extractor/fix-1284_2019-05-27-00-06.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@microsoft/api-extractor", - "comment": "Fix incorrect path resolution for the \"extends\" field when loading tsconfig.json", - "type": "patch" - } - ], - "packageName": "@microsoft/api-extractor", - "email": "timocov@users.noreply.github.com" -} \ No newline at end of file diff --git a/common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json b/common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json deleted file mode 100644 index 7a7783fcefa..00000000000 --- a/common/changes/@microsoft/ts-command-line/octogonz-tsc-fix-broken-link_2019-05-27-03-57.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@microsoft/ts-command-line", - "comment": "Fix a broken link in the README.md (GitHub issue #1285)", - "type": "patch" - } - ], - "packageName": "@microsoft/ts-command-line", - "email": "4673363+octogonz@users.noreply.github.com" -} \ No newline at end of file diff --git a/core-build/gulp-core-build-sass/CHANGELOG.json b/core-build/gulp-core-build-sass/CHANGELOG.json index f29ecd6fbfd..df7d3c563d7 100644 --- a/core-build/gulp-core-build-sass/CHANGELOG.json +++ b/core-build/gulp-core-build-sass/CHANGELOG.json @@ -1,6 +1,24 @@ { "name": "@microsoft/gulp-core-build-sass", "entries": [ + { + "version": "4.6.35", + "tag": "@microsoft/gulp-core-build-sass_v4.6.35", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/load-themed-styles\" from `1.9.1` to `1.9.2`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "4.6.34", "tag": "@microsoft/gulp-core-build-sass_v4.6.34", diff --git a/core-build/gulp-core-build-sass/CHANGELOG.md b/core-build/gulp-core-build-sass/CHANGELOG.md index 7b5624d413f..0e4782f6057 100644 --- a/core-build/gulp-core-build-sass/CHANGELOG.md +++ b/core-build/gulp-core-build-sass/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/gulp-core-build-sass -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 4.6.35 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 4.6.34 Mon, 13 May 2019 02:08:35 GMT diff --git a/core-build/gulp-core-build-serve/CHANGELOG.json b/core-build/gulp-core-build-serve/CHANGELOG.json index 3a0307a399e..7de090e1619 100644 --- a/core-build/gulp-core-build-serve/CHANGELOG.json +++ b/core-build/gulp-core-build-serve/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/gulp-core-build-serve", "entries": [ + { + "version": "3.3.36", + "tag": "@microsoft/gulp-core-build-serve_v3.3.36", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "3.3.35", "tag": "@microsoft/gulp-core-build-serve_v3.3.35", diff --git a/core-build/gulp-core-build-serve/CHANGELOG.md b/core-build/gulp-core-build-serve/CHANGELOG.md index 5f94cb45334..6470802dbb4 100644 --- a/core-build/gulp-core-build-serve/CHANGELOG.md +++ b/core-build/gulp-core-build-serve/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/gulp-core-build-serve -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 3.3.36 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 3.3.35 Mon, 13 May 2019 02:08:35 GMT diff --git a/core-build/gulp-core-build-typescript/CHANGELOG.json b/core-build/gulp-core-build-typescript/CHANGELOG.json index c5c096234f0..73461f44a88 100644 --- a/core-build/gulp-core-build-typescript/CHANGELOG.json +++ b/core-build/gulp-core-build-typescript/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/gulp-core-build-typescript", "entries": [ + { + "version": "8.1.12", + "tag": "@microsoft/gulp-core-build-typescript_v8.1.12", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.1\" from `0.6.13` to `0.6.14`" + } + ] + } + }, { "version": "8.1.11", "tag": "@microsoft/gulp-core-build-typescript_v8.1.11", diff --git a/core-build/gulp-core-build-typescript/CHANGELOG.md b/core-build/gulp-core-build-typescript/CHANGELOG.md index eef0cb1a972..9d2b4777946 100644 --- a/core-build/gulp-core-build-typescript/CHANGELOG.md +++ b/core-build/gulp-core-build-typescript/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/gulp-core-build-typescript -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 8.1.12 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 8.1.11 Mon, 13 May 2019 02:08:35 GMT diff --git a/core-build/gulp-core-build-webpack/CHANGELOG.json b/core-build/gulp-core-build-webpack/CHANGELOG.json index a4012986e0c..af968a71535 100644 --- a/core-build/gulp-core-build-webpack/CHANGELOG.json +++ b/core-build/gulp-core-build-webpack/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/gulp-core-build-webpack", "entries": [ + { + "version": "3.4.103", + "tag": "@microsoft/gulp-core-build-webpack_v3.4.103", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "3.4.102", "tag": "@microsoft/gulp-core-build-webpack_v3.4.102", diff --git a/core-build/gulp-core-build-webpack/CHANGELOG.md b/core-build/gulp-core-build-webpack/CHANGELOG.md index 2f2327300b6..54b50f599b5 100644 --- a/core-build/gulp-core-build-webpack/CHANGELOG.md +++ b/core-build/gulp-core-build-webpack/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/gulp-core-build-webpack -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 3.4.103 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 3.4.102 Mon, 13 May 2019 02:08:35 GMT diff --git a/core-build/node-library-build/CHANGELOG.json b/core-build/node-library-build/CHANGELOG.json index 701d5315422..561373c0e69 100644 --- a/core-build/node-library-build/CHANGELOG.json +++ b/core-build/node-library-build/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/node-library-build", "entries": [ + { + "version": "6.0.62", + "tag": "@microsoft/node-library-build_v6.0.62", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/gulp-core-build-typescript\" from `8.1.11` to `8.1.12`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + } + ] + } + }, { "version": "6.0.61", "tag": "@microsoft/node-library-build_v6.0.61", diff --git a/core-build/node-library-build/CHANGELOG.md b/core-build/node-library-build/CHANGELOG.md index e1879b742fa..5d7efb4bf38 100644 --- a/core-build/node-library-build/CHANGELOG.md +++ b/core-build/node-library-build/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/node-library-build -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 6.0.62 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 6.0.61 Mon, 13 May 2019 02:08:35 GMT diff --git a/core-build/web-library-build/CHANGELOG.json b/core-build/web-library-build/CHANGELOG.json index 24546804387..9903f896ef3 100644 --- a/core-build/web-library-build/CHANGELOG.json +++ b/core-build/web-library-build/CHANGELOG.json @@ -1,6 +1,33 @@ { "name": "@microsoft/web-library-build", "entries": [ + { + "version": "7.0.39", + "tag": "@microsoft/web-library-build_v7.0.39", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/gulp-core-build-sass\" from `4.6.34` to `4.6.35`" + }, + { + "comment": "Updating dependency \"@microsoft/gulp-core-build-serve\" from `3.3.35` to `3.3.36`" + }, + { + "comment": "Updating dependency \"@microsoft/gulp-core-build-typescript\" from `8.1.11` to `8.1.12`" + }, + { + "comment": "Updating dependency \"@microsoft/gulp-core-build-webpack\" from `3.4.102` to `3.4.103`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + } + ] + } + }, { "version": "7.0.38", "tag": "@microsoft/web-library-build_v7.0.38", diff --git a/core-build/web-library-build/CHANGELOG.md b/core-build/web-library-build/CHANGELOG.md index 8a47442b1a0..df6bc717f72 100644 --- a/core-build/web-library-build/CHANGELOG.md +++ b/core-build/web-library-build/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/web-library-build -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 7.0.39 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 7.0.38 Mon, 13 May 2019 02:08:35 GMT diff --git a/libraries/load-themed-styles/CHANGELOG.json b/libraries/load-themed-styles/CHANGELOG.json index f4655932371..9eea4cab00b 100644 --- a/libraries/load-themed-styles/CHANGELOG.json +++ b/libraries/load-themed-styles/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/load-themed-styles", "entries": [ + { + "version": "1.9.2", + "tag": "@microsoft/load-themed-styles_v1.9.2", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "1.9.1", "tag": "@microsoft/load-themed-styles_v1.9.1", diff --git a/libraries/load-themed-styles/CHANGELOG.md b/libraries/load-themed-styles/CHANGELOG.md index a93697a0fb4..54a24e44f0f 100644 --- a/libraries/load-themed-styles/CHANGELOG.md +++ b/libraries/load-themed-styles/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/load-themed-styles -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 1.9.2 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 1.9.1 Mon, 13 May 2019 02:08:35 GMT diff --git a/libraries/package-deps-hash/CHANGELOG.json b/libraries/package-deps-hash/CHANGELOG.json index 3789c3caa8c..f6a92787727 100644 --- a/libraries/package-deps-hash/CHANGELOG.json +++ b/libraries/package-deps-hash/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/package-deps-hash", "entries": [ + { + "version": "2.2.153", + "tag": "@microsoft/package-deps-hash_v2.2.153", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "2.2.152", "tag": "@microsoft/package-deps-hash_v2.2.152", diff --git a/libraries/package-deps-hash/CHANGELOG.md b/libraries/package-deps-hash/CHANGELOG.md index 3533245c08c..fae10786c82 100644 --- a/libraries/package-deps-hash/CHANGELOG.md +++ b/libraries/package-deps-hash/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/package-deps-hash -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 2.2.153 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 2.2.152 Mon, 13 May 2019 02:08:35 GMT diff --git a/libraries/stream-collator/CHANGELOG.json b/libraries/stream-collator/CHANGELOG.json index 861468667d4..9405a44b53f 100644 --- a/libraries/stream-collator/CHANGELOG.json +++ b/libraries/stream-collator/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/stream-collator", "entries": [ + { + "version": "3.0.68", + "tag": "@microsoft/stream-collator_v3.0.68", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "3.0.67", "tag": "@microsoft/stream-collator_v3.0.67", diff --git a/libraries/stream-collator/CHANGELOG.md b/libraries/stream-collator/CHANGELOG.md index 8cf16dc033d..41c0f131838 100644 --- a/libraries/stream-collator/CHANGELOG.md +++ b/libraries/stream-collator/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/stream-collator -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 3.0.68 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 3.0.67 Mon, 13 May 2019 02:08:35 GMT diff --git a/libraries/ts-command-line/CHANGELOG.json b/libraries/ts-command-line/CHANGELOG.json index 33f8b835e9d..b741f7199f7 100644 --- a/libraries/ts-command-line/CHANGELOG.json +++ b/libraries/ts-command-line/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/ts-command-line", "entries": [ + { + "version": "4.2.5", + "tag": "@microsoft/ts-command-line_v4.2.5", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "patch": [ + { + "comment": "Fix a broken link in the README.md (GitHub issue #1285)" + } + ] + } + }, { "version": "4.2.4", "tag": "@microsoft/ts-command-line_v4.2.4", diff --git a/libraries/ts-command-line/CHANGELOG.md b/libraries/ts-command-line/CHANGELOG.md index 25d37753274..197ea8253d4 100644 --- a/libraries/ts-command-line/CHANGELOG.md +++ b/libraries/ts-command-line/CHANGELOG.md @@ -1,6 +1,13 @@ # Change Log - @microsoft/ts-command-line -This log was last generated on Mon, 06 May 2019 20:46:21 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 4.2.5 +Mon, 27 May 2019 04:13:44 GMT + +### Patches + +- Fix a broken link in the README.md (GitHub issue #1285) ## 4.2.4 Mon, 06 May 2019 20:46:21 GMT diff --git a/stack/rush-stack-compiler-2.4/CHANGELOG.json b/stack/rush-stack-compiler-2.4/CHANGELOG.json index 97233eb20fc..cf6e37c9bcb 100644 --- a/stack/rush-stack-compiler-2.4/CHANGELOG.json +++ b/stack/rush-stack-compiler-2.4/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-2.4", "entries": [ + { + "version": "0.6.14", + "tag": "@microsoft/rush-stack-compiler-2.4_v0.6.14", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.6.13", "tag": "@microsoft/rush-stack-compiler-2.4_v0.6.13", diff --git a/stack/rush-stack-compiler-2.4/CHANGELOG.md b/stack/rush-stack-compiler-2.4/CHANGELOG.md index 8e429c6ead9..b807d274d85 100644 --- a/stack/rush-stack-compiler-2.4/CHANGELOG.md +++ b/stack/rush-stack-compiler-2.4/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-2.4 -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.6.14 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.6.13 Mon, 13 May 2019 02:08:35 GMT diff --git a/stack/rush-stack-compiler-2.7/CHANGELOG.json b/stack/rush-stack-compiler-2.7/CHANGELOG.json index 2e688b11a31..56b9850cce0 100644 --- a/stack/rush-stack-compiler-2.7/CHANGELOG.json +++ b/stack/rush-stack-compiler-2.7/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-2.7", "entries": [ + { + "version": "0.6.14", + "tag": "@microsoft/rush-stack-compiler-2.7_v0.6.14", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.6.13", "tag": "@microsoft/rush-stack-compiler-2.7_v0.6.13", diff --git a/stack/rush-stack-compiler-2.7/CHANGELOG.md b/stack/rush-stack-compiler-2.7/CHANGELOG.md index 99abe7edd08..74bef215f40 100644 --- a/stack/rush-stack-compiler-2.7/CHANGELOG.md +++ b/stack/rush-stack-compiler-2.7/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-2.7 -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.6.14 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.6.13 Mon, 13 May 2019 02:08:35 GMT diff --git a/stack/rush-stack-compiler-2.8/CHANGELOG.json b/stack/rush-stack-compiler-2.8/CHANGELOG.json index 22386ea2aaa..da4e087cfb9 100644 --- a/stack/rush-stack-compiler-2.8/CHANGELOG.json +++ b/stack/rush-stack-compiler-2.8/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-2.8", "entries": [ + { + "version": "0.1.1", + "tag": "@microsoft/rush-stack-compiler-2.8_v0.1.1", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.1.0", "tag": "@microsoft/rush-stack-compiler-2.8_v0.1.0", diff --git a/stack/rush-stack-compiler-2.8/CHANGELOG.md b/stack/rush-stack-compiler-2.8/CHANGELOG.md index 491bf9eb43e..d8c3b1af17e 100644 --- a/stack/rush-stack-compiler-2.8/CHANGELOG.md +++ b/stack/rush-stack-compiler-2.8/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-2.8 -This log was last generated on Mon, 13 May 2019 21:46:26 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.1.1 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.1.0 Mon, 13 May 2019 21:46:26 GMT diff --git a/stack/rush-stack-compiler-2.9/CHANGELOG.json b/stack/rush-stack-compiler-2.9/CHANGELOG.json index 03b6b4c1e06..ffccfa5469c 100644 --- a/stack/rush-stack-compiler-2.9/CHANGELOG.json +++ b/stack/rush-stack-compiler-2.9/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-2.9", "entries": [ + { + "version": "0.7.14", + "tag": "@microsoft/rush-stack-compiler-2.9_v0.7.14", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.7.13", "tag": "@microsoft/rush-stack-compiler-2.9_v0.7.13", diff --git a/stack/rush-stack-compiler-2.9/CHANGELOG.md b/stack/rush-stack-compiler-2.9/CHANGELOG.md index 8c9db4648bb..2714f1ad066 100644 --- a/stack/rush-stack-compiler-2.9/CHANGELOG.md +++ b/stack/rush-stack-compiler-2.9/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-2.9 -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.7.14 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.7.13 Mon, 13 May 2019 02:08:35 GMT diff --git a/stack/rush-stack-compiler-3.0/CHANGELOG.json b/stack/rush-stack-compiler-3.0/CHANGELOG.json index 4f8c9ce9733..57340bc83b8 100644 --- a/stack/rush-stack-compiler-3.0/CHANGELOG.json +++ b/stack/rush-stack-compiler-3.0/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-3.0", "entries": [ + { + "version": "0.6.14", + "tag": "@microsoft/rush-stack-compiler-3.0_v0.6.14", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.6.13", "tag": "@microsoft/rush-stack-compiler-3.0_v0.6.13", diff --git a/stack/rush-stack-compiler-3.0/CHANGELOG.md b/stack/rush-stack-compiler-3.0/CHANGELOG.md index e172833ec8b..e62f02657dc 100644 --- a/stack/rush-stack-compiler-3.0/CHANGELOG.md +++ b/stack/rush-stack-compiler-3.0/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-3.0 -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.6.14 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.6.13 Mon, 13 May 2019 02:08:35 GMT diff --git a/stack/rush-stack-compiler-3.1/CHANGELOG.json b/stack/rush-stack-compiler-3.1/CHANGELOG.json index c3fd35010c3..9838e65f610 100644 --- a/stack/rush-stack-compiler-3.1/CHANGELOG.json +++ b/stack/rush-stack-compiler-3.1/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-3.1", "entries": [ + { + "version": "0.6.14", + "tag": "@microsoft/rush-stack-compiler-3.1_v0.6.14", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.6.13", "tag": "@microsoft/rush-stack-compiler-3.1_v0.6.13", diff --git a/stack/rush-stack-compiler-3.1/CHANGELOG.md b/stack/rush-stack-compiler-3.1/CHANGELOG.md index 2cd41555024..92ba5ec41af 100644 --- a/stack/rush-stack-compiler-3.1/CHANGELOG.md +++ b/stack/rush-stack-compiler-3.1/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-3.1 -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.6.14 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.6.13 Mon, 13 May 2019 02:08:35 GMT diff --git a/stack/rush-stack-compiler-3.2/CHANGELOG.json b/stack/rush-stack-compiler-3.2/CHANGELOG.json index a77da79578b..217ccd1af3e 100644 --- a/stack/rush-stack-compiler-3.2/CHANGELOG.json +++ b/stack/rush-stack-compiler-3.2/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-3.2", "entries": [ + { + "version": "0.3.14", + "tag": "@microsoft/rush-stack-compiler-3.2_v0.3.14", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.3.13", "tag": "@microsoft/rush-stack-compiler-3.2_v0.3.13", diff --git a/stack/rush-stack-compiler-3.2/CHANGELOG.md b/stack/rush-stack-compiler-3.2/CHANGELOG.md index a149b9274cc..80e384f2798 100644 --- a/stack/rush-stack-compiler-3.2/CHANGELOG.md +++ b/stack/rush-stack-compiler-3.2/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-3.2 -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.3.14 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.3.13 Mon, 13 May 2019 02:08:35 GMT diff --git a/stack/rush-stack-compiler-3.3/CHANGELOG.json b/stack/rush-stack-compiler-3.3/CHANGELOG.json index ec9bb7ec668..d92fe624164 100644 --- a/stack/rush-stack-compiler-3.3/CHANGELOG.json +++ b/stack/rush-stack-compiler-3.3/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-3.3", "entries": [ + { + "version": "0.2.14", + "tag": "@microsoft/rush-stack-compiler-3.3_v0.2.14", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.2.13", "tag": "@microsoft/rush-stack-compiler-3.3_v0.2.13", diff --git a/stack/rush-stack-compiler-3.3/CHANGELOG.md b/stack/rush-stack-compiler-3.3/CHANGELOG.md index 7430e62172b..4ca2dbcb595 100644 --- a/stack/rush-stack-compiler-3.3/CHANGELOG.md +++ b/stack/rush-stack-compiler-3.3/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-3.3 -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.2.14 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.2.13 Mon, 13 May 2019 02:08:35 GMT diff --git a/stack/rush-stack-compiler-3.4/CHANGELOG.json b/stack/rush-stack-compiler-3.4/CHANGELOG.json index 0d7f6ad8cfc..583ee99c789 100644 --- a/stack/rush-stack-compiler-3.4/CHANGELOG.json +++ b/stack/rush-stack-compiler-3.4/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/rush-stack-compiler-3.4", "entries": [ + { + "version": "0.1.1", + "tag": "@microsoft/rush-stack-compiler-3.4_v0.1.1", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/api-extractor\" from `7.1.5` to `7.1.6`" + } + ] + } + }, { "version": "0.1.0", "tag": "@microsoft/rush-stack-compiler-3.4_v0.1.0", diff --git a/stack/rush-stack-compiler-3.4/CHANGELOG.md b/stack/rush-stack-compiler-3.4/CHANGELOG.md index 663392e8a43..cb0e4310ffc 100644 --- a/stack/rush-stack-compiler-3.4/CHANGELOG.md +++ b/stack/rush-stack-compiler-3.4/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack-compiler-3.4 -This log was last generated on Mon, 13 May 2019 21:46:26 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.1.1 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.1.0 Mon, 13 May 2019 21:46:26 GMT diff --git a/stack/rush-stack/CHANGELOG.json b/stack/rush-stack/CHANGELOG.json index 7e48cb55f25..374a06dc92e 100644 --- a/stack/rush-stack/CHANGELOG.json +++ b/stack/rush-stack/CHANGELOG.json @@ -1,6 +1,24 @@ { "name": "@microsoft/rush-stack", "entries": [ + { + "version": "0.1.82", + "tag": "@microsoft/rush-stack_v0.1.82", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/ts-command-line\" from `4.2.4` to `4.2.5`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "0.1.81", "tag": "@microsoft/rush-stack_v0.1.81", diff --git a/stack/rush-stack/CHANGELOG.md b/stack/rush-stack/CHANGELOG.md index 4acd8405a11..05a4766319b 100644 --- a/stack/rush-stack/CHANGELOG.md +++ b/stack/rush-stack/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/rush-stack -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 0.1.82 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 0.1.81 Mon, 13 May 2019 02:08:35 GMT diff --git a/webpack/loader-load-themed-styles/CHANGELOG.json b/webpack/loader-load-themed-styles/CHANGELOG.json index e39fe38c98a..702c57b1742 100644 --- a/webpack/loader-load-themed-styles/CHANGELOG.json +++ b/webpack/loader-load-themed-styles/CHANGELOG.json @@ -1,6 +1,24 @@ { "name": "@microsoft/loader-load-themed-styles", "entries": [ + { + "version": "1.7.160", + "tag": "@microsoft/loader-load-themed-styles_v1.7.160", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/load-themed-styles\" from `1.9.1` to `1.9.2`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "1.7.159", "tag": "@microsoft/loader-load-themed-styles_v1.7.159", diff --git a/webpack/loader-load-themed-styles/CHANGELOG.md b/webpack/loader-load-themed-styles/CHANGELOG.md index 7251aa22c6c..70015d0ef31 100644 --- a/webpack/loader-load-themed-styles/CHANGELOG.md +++ b/webpack/loader-load-themed-styles/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/loader-load-themed-styles -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 1.7.160 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 1.7.159 Mon, 13 May 2019 02:08:35 GMT diff --git a/webpack/loader-raw-script/CHANGELOG.json b/webpack/loader-raw-script/CHANGELOG.json index 7894b97f05a..c19964c04a9 100644 --- a/webpack/loader-raw-script/CHANGELOG.json +++ b/webpack/loader-raw-script/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/loader-raw-script", "entries": [ + { + "version": "1.2.152", + "tag": "@microsoft/loader-raw-script_v1.2.152", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "1.2.151", "tag": "@microsoft/loader-raw-script_v1.2.151", diff --git a/webpack/loader-raw-script/CHANGELOG.md b/webpack/loader-raw-script/CHANGELOG.md index 4b30ee65a87..dfc6d363ff0 100644 --- a/webpack/loader-raw-script/CHANGELOG.md +++ b/webpack/loader-raw-script/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/loader-raw-script -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 1.2.152 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 1.2.151 Mon, 13 May 2019 02:08:35 GMT diff --git a/webpack/loader-set-webpack-public-path/CHANGELOG.json b/webpack/loader-set-webpack-public-path/CHANGELOG.json index 45a4e4c69b7..19bd605adc4 100644 --- a/webpack/loader-set-webpack-public-path/CHANGELOG.json +++ b/webpack/loader-set-webpack-public-path/CHANGELOG.json @@ -1,6 +1,24 @@ { "name": "@microsoft/loader-set-webpack-public-path", "entries": [ + { + "version": "3.2.154", + "tag": "@microsoft/loader-set-webpack-public-path_v3.2.154", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/set-webpack-public-path-plugin\" from `2.1.109` to `2.1.110`" + }, + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "3.2.153", "tag": "@microsoft/loader-set-webpack-public-path_v3.2.153", diff --git a/webpack/loader-set-webpack-public-path/CHANGELOG.md b/webpack/loader-set-webpack-public-path/CHANGELOG.md index 4a9c60a0031..27c290eef19 100644 --- a/webpack/loader-set-webpack-public-path/CHANGELOG.md +++ b/webpack/loader-set-webpack-public-path/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/loader-set-webpack-public-path -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 3.2.154 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 3.2.153 Mon, 13 May 2019 02:08:35 GMT diff --git a/webpack/resolve-chunk-plugin/CHANGELOG.json b/webpack/resolve-chunk-plugin/CHANGELOG.json index 8aed4cca002..a157578ddd0 100644 --- a/webpack/resolve-chunk-plugin/CHANGELOG.json +++ b/webpack/resolve-chunk-plugin/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/resolve-chunk-plugin", "entries": [ + { + "version": "2.0.110", + "tag": "@microsoft/resolve-chunk-plugin_v2.0.110", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "2.0.109", "tag": "@microsoft/resolve-chunk-plugin_v2.0.109", diff --git a/webpack/resolve-chunk-plugin/CHANGELOG.md b/webpack/resolve-chunk-plugin/CHANGELOG.md index 53add97f468..a91a9213b49 100644 --- a/webpack/resolve-chunk-plugin/CHANGELOG.md +++ b/webpack/resolve-chunk-plugin/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/resolve-chunk-plugin -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 2.0.110 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 2.0.109 Mon, 13 May 2019 02:08:35 GMT diff --git a/webpack/set-webpack-public-path-plugin/CHANGELOG.json b/webpack/set-webpack-public-path-plugin/CHANGELOG.json index cbfa40f1643..4991a82e8ce 100644 --- a/webpack/set-webpack-public-path-plugin/CHANGELOG.json +++ b/webpack/set-webpack-public-path-plugin/CHANGELOG.json @@ -1,6 +1,21 @@ { "name": "@microsoft/set-webpack-public-path-plugin", "entries": [ + { + "version": "2.1.110", + "tag": "@microsoft/set-webpack-public-path-plugin_v2.1.110", + "date": "Mon, 27 May 2019 04:13:44 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/rush-stack-compiler-3.2\" from `0.3.13` to `0.3.14`" + }, + { + "comment": "Updating dependency \"@microsoft/node-library-build\" from `6.0.61` to `6.0.62`" + } + ] + } + }, { "version": "2.1.109", "tag": "@microsoft/set-webpack-public-path-plugin_v2.1.109", diff --git a/webpack/set-webpack-public-path-plugin/CHANGELOG.md b/webpack/set-webpack-public-path-plugin/CHANGELOG.md index ac644cb617b..e81bb66a7c7 100644 --- a/webpack/set-webpack-public-path-plugin/CHANGELOG.md +++ b/webpack/set-webpack-public-path-plugin/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/set-webpack-public-path-plugin -This log was last generated on Mon, 13 May 2019 02:08:35 GMT and should not be manually modified. +This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. + +## 2.1.110 +Mon, 27 May 2019 04:13:44 GMT + +*Version update only* ## 2.1.109 Mon, 13 May 2019 02:08:35 GMT From 3355b5e5fb24913665e6e4de6cb680d2c03020ed Mon Sep 17 00:00:00 2001 From: Rushbot Date: Mon, 27 May 2019 04:13:57 +0000 Subject: [PATCH 22/41] Applying package updates. --- apps/api-documenter/package.json | 10 +++++----- apps/api-extractor-model/package.json | 2 +- apps/api-extractor/package.json | 6 +++--- apps/rush-lib/package.json | 10 +++++----- apps/rush/package.json | 4 ++-- build-tests/api-documenter-test/package.json | 4 ++-- build-tests/api-extractor-lib1-test/package.json | 2 +- build-tests/api-extractor-lib2-test/package.json | 2 +- build-tests/api-extractor-lib3-test/package.json | 2 +- build-tests/api-extractor-scenarios/package.json | 2 +- build-tests/api-extractor-test-01/package.json | 2 +- build-tests/api-extractor-test-02/package.json | 2 +- build-tests/api-extractor-test-04/package.json | 2 +- build-tests/node-library-build-test/package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- .../package.json | 4 ++-- build-tests/rush-stack-library-test/package.json | 4 ++-- build-tests/web-library-build-test/package.json | 6 +++--- core-build/gulp-core-build-sass/package.json | 8 ++++---- core-build/gulp-core-build-serve/package.json | 6 +++--- core-build/gulp-core-build-typescript/package.json | 6 +++--- core-build/gulp-core-build-webpack/package.json | 6 +++--- core-build/node-library-build/package.json | 6 +++--- core-build/web-library-build/package.json | 14 +++++++------- libraries/load-themed-styles/package.json | 6 +++--- libraries/package-deps-hash/package.json | 6 +++--- libraries/rushell/package.json | 4 ++-- libraries/stream-collator/package.json | 6 +++--- libraries/ts-command-line/package.json | 2 +- stack/rush-stack-compiler-2.4/package.json | 4 ++-- stack/rush-stack-compiler-2.7/package.json | 4 ++-- stack/rush-stack-compiler-2.8/package.json | 4 ++-- stack/rush-stack-compiler-2.9/package.json | 4 ++-- stack/rush-stack-compiler-3.0/package.json | 4 ++-- stack/rush-stack-compiler-3.1/package.json | 4 ++-- stack/rush-stack-compiler-3.2/package.json | 4 ++-- stack/rush-stack-compiler-3.3/package.json | 4 ++-- stack/rush-stack-compiler-3.4/package.json | 4 ++-- stack/rush-stack/package.json | 8 ++++---- webpack/loader-load-themed-styles/package.json | 8 ++++---- webpack/loader-raw-script/package.json | 6 +++--- .../loader-set-webpack-public-path/package.json | 8 ++++---- webpack/resolve-chunk-plugin/package.json | 6 +++--- .../set-webpack-public-path-plugin/package.json | 6 +++--- 51 files changed, 124 insertions(+), 124 deletions(-) diff --git a/apps/api-documenter/package.json b/apps/api-documenter/package.json index b332ebd8a62..55cddd2cc38 100644 --- a/apps/api-documenter/package.json +++ b/apps/api-documenter/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/api-documenter", - "version": "7.2.0", + "version": "7.2.1", "description": "Read JSON files from api-extractor, generate documentation pages", "repository": { "type": "git", @@ -15,16 +15,16 @@ "api-documenter": "./bin/api-documenter" }, "dependencies": { - "@microsoft/api-extractor-model": "7.1.0", + "@microsoft/api-extractor-model": "7.1.1", "@microsoft/node-core-library": "3.13.0", - "@microsoft/ts-command-line": "4.2.4", + "@microsoft/ts-command-line": "4.2.5", "@microsoft/tsdoc": "0.12.9", "colors": "~1.2.1", "js-yaml": "~3.13.1" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/js-yaml": "3.12.1", "@types/node": "8.5.8", "gulp": "~3.9.1", diff --git a/apps/api-extractor-model/package.json b/apps/api-extractor-model/package.json index 60fb56ad953..46043ea2039 100644 --- a/apps/api-extractor-model/package.json +++ b/apps/api-extractor-model/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/api-extractor-model", - "version": "7.1.0", + "version": "7.1.1", "description": "A helper library for loading and saving the .api.json files created by API Extractor", "repository": { "type": "git", diff --git a/apps/api-extractor/package.json b/apps/api-extractor/package.json index 5264a3e8d9a..19aa0bf869f 100644 --- a/apps/api-extractor/package.json +++ b/apps/api-extractor/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/api-extractor", - "version": "7.1.5", + "version": "7.1.6", "description": "Analyze the exported API for a TypeScript library and generate reviews, documentation, and .d.ts rollups", "keywords": [ "typescript", @@ -35,9 +35,9 @@ "build": "gulp test --clean" }, "dependencies": { - "@microsoft/api-extractor-model": "7.1.0", + "@microsoft/api-extractor-model": "7.1.1", "@microsoft/node-core-library": "3.13.0", - "@microsoft/ts-command-line": "4.2.4", + "@microsoft/ts-command-line": "4.2.5", "@microsoft/tsdoc": "0.12.9", "colors": "~1.2.1", "lodash": "~4.17.5", diff --git a/apps/rush-lib/package.json b/apps/rush-lib/package.json index ee18eda7241..58df7f62fde 100644 --- a/apps/rush-lib/package.json +++ b/apps/rush-lib/package.json @@ -22,9 +22,9 @@ "license": "MIT", "dependencies": { "@microsoft/node-core-library": "3.13.0", - "@microsoft/package-deps-hash": "2.2.152", - "@microsoft/stream-collator": "3.0.67", - "@microsoft/ts-command-line": "4.2.4", + "@microsoft/package-deps-hash": "2.2.153", + "@microsoft/stream-collator": "3.0.68", + "@microsoft/ts-command-line": "4.2.5", "@pnpm/link-bins": "~1.0.1", "@pnpm/logger": "~1.0.1", "@yarnpkg/lockfile": "~1.0.2", @@ -49,8 +49,8 @@ "z-schema": "~3.18.3" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/node": "8.5.8", "@types/node-fetch": "1.6.9", "@types/tar": "4.0.0", diff --git a/apps/rush/package.json b/apps/rush/package.json index 5478e36c732..ffdb4b05eb6 100644 --- a/apps/rush/package.json +++ b/apps/rush/package.json @@ -37,8 +37,8 @@ "semver": "~5.3.0" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/chai": "3.4.34", "@types/mocha": "5.2.5", "@types/node": "8.5.8", diff --git a/build-tests/api-documenter-test/package.json b/build-tests/api-documenter-test/package.json index 41e90127eb1..77921fccc9e 100644 --- a/build-tests/api-documenter-test/package.json +++ b/build-tests/api-documenter-test/package.json @@ -9,8 +9,8 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", - "@microsoft/api-documenter": "7.2.0", + "@microsoft/api-extractor": "7.1.6", + "@microsoft/api-documenter": "7.2.1", "@types/jest": "23.3.11", "@types/node": "8.5.8", "fs-extra": "~7.0.1", diff --git a/build-tests/api-extractor-lib1-test/package.json b/build-tests/api-extractor-lib1-test/package.json index c84fcc5f122..30c84fff390 100644 --- a/build-tests/api-extractor-lib1-test/package.json +++ b/build-tests/api-extractor-lib1-test/package.json @@ -9,7 +9,7 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@types/jest": "23.3.11", "@types/node": "8.5.8", "fs-extra": "~7.0.1", diff --git a/build-tests/api-extractor-lib2-test/package.json b/build-tests/api-extractor-lib2-test/package.json index 4e4c324b81f..6a660d8b4e4 100644 --- a/build-tests/api-extractor-lib2-test/package.json +++ b/build-tests/api-extractor-lib2-test/package.json @@ -9,7 +9,7 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@types/jest": "23.3.11", "@types/node": "8.5.8", "fs-extra": "~7.0.1", diff --git a/build-tests/api-extractor-lib3-test/package.json b/build-tests/api-extractor-lib3-test/package.json index 60dc4400a2a..01314ee3d8c 100644 --- a/build-tests/api-extractor-lib3-test/package.json +++ b/build-tests/api-extractor-lib3-test/package.json @@ -9,7 +9,7 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@types/jest": "23.3.11", "@types/node": "8.5.8", "api-extractor-lib1-test": "1.0.0", diff --git a/build-tests/api-extractor-scenarios/package.json b/build-tests/api-extractor-scenarios/package.json index fc060861ea9..8945c457f6f 100644 --- a/build-tests/api-extractor-scenarios/package.json +++ b/build-tests/api-extractor-scenarios/package.json @@ -9,7 +9,7 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@microsoft/teams-js": "1.3.0-beta.4", "@types/jest": "23.3.11", diff --git a/build-tests/api-extractor-test-01/package.json b/build-tests/api-extractor-test-01/package.json index 4070fcf30b3..1ed5e055e70 100644 --- a/build-tests/api-extractor-test-01/package.json +++ b/build-tests/api-extractor-test-01/package.json @@ -12,7 +12,7 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@types/jest": "23.3.11", "@types/node": "8.5.8", "fs-extra": "~7.0.1", diff --git a/build-tests/api-extractor-test-02/package.json b/build-tests/api-extractor-test-02/package.json index 203b3d7b12e..e92b8026057 100644 --- a/build-tests/api-extractor-test-02/package.json +++ b/build-tests/api-extractor-test-02/package.json @@ -12,7 +12,7 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@types/semver": "5.3.33", "@types/node": "8.5.8", "api-extractor-test-01": "1.0.0", diff --git a/build-tests/api-extractor-test-04/package.json b/build-tests/api-extractor-test-04/package.json index 2abc5ba0037..13d38c921dd 100644 --- a/build-tests/api-extractor-test-04/package.json +++ b/build-tests/api-extractor-test-04/package.json @@ -12,7 +12,7 @@ "build": "node build.js" }, "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "api-extractor-lib1-test": "1.0.0", "fs-extra": "~7.0.1", "typescript": "~3.1.6" diff --git a/build-tests/node-library-build-test/package.json b/build-tests/node-library-build-test/package.json index 5da35f8ac11..5b1721a1464 100644 --- a/build-tests/node-library-build-test/package.json +++ b/build-tests/node-library-build-test/package.json @@ -11,11 +11,11 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", + "@microsoft/node-library-build": "6.0.62", "@types/chai": "3.4.34", "@types/mocha": "5.2.5", "chai": "~3.5.0", "gulp": "~3.9.1", - "@microsoft/rush-stack-compiler-3.2": "0.3.13" + "@microsoft/rush-stack-compiler-3.2": "0.3.14" } } diff --git a/build-tests/rush-stack-compiler-2.4-library-test/package.json b/build-tests/rush-stack-compiler-2.4-library-test/package.json index 1b4c982a9bc..5d61125cf65 100644 --- a/build-tests/rush-stack-compiler-2.4-library-test/package.json +++ b/build-tests/rush-stack-compiler-2.4-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-2.4": "0.6.13", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-2.4": "0.6.14", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-2.7-library-test/package.json b/build-tests/rush-stack-compiler-2.7-library-test/package.json index 3e6155600a5..f8e6641a2c1 100644 --- a/build-tests/rush-stack-compiler-2.7-library-test/package.json +++ b/build-tests/rush-stack-compiler-2.7-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-2.7": "0.6.13", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-2.7": "0.6.14", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-2.8-library-test/package.json b/build-tests/rush-stack-compiler-2.8-library-test/package.json index 6688be59f47..c1325aa15cc 100644 --- a/build-tests/rush-stack-compiler-2.8-library-test/package.json +++ b/build-tests/rush-stack-compiler-2.8-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-2.8": "0.1.0", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-2.8": "0.1.1", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-2.9-library-test/package.json b/build-tests/rush-stack-compiler-2.9-library-test/package.json index d86b667e336..547a3a3e5aa 100644 --- a/build-tests/rush-stack-compiler-2.9-library-test/package.json +++ b/build-tests/rush-stack-compiler-2.9-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-2.9": "0.7.13", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-2.9": "0.7.14", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-3.0-library-test/package.json b/build-tests/rush-stack-compiler-3.0-library-test/package.json index 4c3d79886d8..99bdbb7583c 100644 --- a/build-tests/rush-stack-compiler-3.0-library-test/package.json +++ b/build-tests/rush-stack-compiler-3.0-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-3.0": "0.6.13", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-3.0": "0.6.14", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-3.1-library-test/package.json b/build-tests/rush-stack-compiler-3.1-library-test/package.json index 99247923781..3d1816d58ea 100644 --- a/build-tests/rush-stack-compiler-3.1-library-test/package.json +++ b/build-tests/rush-stack-compiler-3.1-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-3.1": "0.6.13", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-3.1": "0.6.14", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-3.2-library-test/package.json b/build-tests/rush-stack-compiler-3.2-library-test/package.json index e433cb3bc56..43bbc83adca 100644 --- a/build-tests/rush-stack-compiler-3.2-library-test/package.json +++ b/build-tests/rush-stack-compiler-3.2-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-3.3-library-test/package.json b/build-tests/rush-stack-compiler-3.3-library-test/package.json index 88df79db102..68dde9049a1 100644 --- a/build-tests/rush-stack-compiler-3.3-library-test/package.json +++ b/build-tests/rush-stack-compiler-3.3-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-3.3": "0.2.13", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-3.3": "0.2.14", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-compiler-3.4-library-test/package.json b/build-tests/rush-stack-compiler-3.4-library-test/package.json index be816ba05d0..d5ac570b0ca 100644 --- a/build-tests/rush-stack-compiler-3.4-library-test/package.json +++ b/build-tests/rush-stack-compiler-3.4-library-test/package.json @@ -12,8 +12,8 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-3.4": "0.1.0", + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-3.4": "0.1.1", "gulp": "~3.9.1" } } diff --git a/build-tests/rush-stack-library-test/package.json b/build-tests/rush-stack-library-test/package.json index 0eb51f7b51a..9287911d219 100644 --- a/build-tests/rush-stack-library-test/package.json +++ b/build-tests/rush-stack-library-test/package.json @@ -10,7 +10,7 @@ "test": "node_modules/.bin/rush-stack test" }, "dependencies": { - "@microsoft/rush-stack": "0.1.81", - "@microsoft/rush-stack-compiler-3.2": "0.3.13" + "@microsoft/rush-stack": "0.1.82", + "@microsoft/rush-stack-compiler-3.2": "0.3.14" } } diff --git a/build-tests/web-library-build-test/package.json b/build-tests/web-library-build-test/package.json index 2f309dec369..6a06d1e478d 100644 --- a/build-tests/web-library-build-test/package.json +++ b/build-tests/web-library-build-test/package.json @@ -14,9 +14,9 @@ "devDependencies": { "ts-jest": "~22.4.6", "@types/jest": "23.3.11", - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/load-themed-styles": "1.9.1", - "@microsoft/web-library-build": "7.0.38", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/load-themed-styles": "1.9.2", + "@microsoft/web-library-build": "7.0.39", "gulp": "~3.9.1" } } diff --git a/core-build/gulp-core-build-sass/package.json b/core-build/gulp-core-build-sass/package.json index 433427e4ea0..92de9db2436 100644 --- a/core-build/gulp-core-build-sass/package.json +++ b/core-build/gulp-core-build-sass/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/gulp-core-build-sass", - "version": "4.6.34", + "version": "4.6.35", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -17,7 +17,7 @@ }, "dependencies": { "@microsoft/gulp-core-build": "3.9.26", - "@microsoft/load-themed-styles": "1.9.1", + "@microsoft/load-themed-styles": "1.9.2", "@types/node": "8.5.8", "@types/gulp": "3.8.32", "autoprefixer": "~9.1.3", @@ -29,8 +29,8 @@ "@microsoft/node-core-library": "3.13.0" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/glob": "5.0.30", "@types/node-sass": "3.10.32", "@types/clean-css": "4.2.1", diff --git a/core-build/gulp-core-build-serve/package.json b/core-build/gulp-core-build-serve/package.json index b3d13575169..ca68968ed92 100644 --- a/core-build/gulp-core-build-serve/package.json +++ b/core-build/gulp-core-build-serve/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/gulp-core-build-serve", - "version": "3.3.35", + "version": "3.3.36", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -29,8 +29,8 @@ "sudo": "~1.0.3" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/express": "4.11.0", "@types/express-serve-static-core": "4.11.0", "@types/gulp": "3.8.32", diff --git a/core-build/gulp-core-build-typescript/package.json b/core-build/gulp-core-build-typescript/package.json index d59aff5d735..7fc14059685 100644 --- a/core-build/gulp-core-build-typescript/package.json +++ b/core-build/gulp-core-build-typescript/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/gulp-core-build-typescript", - "version": "8.1.11", + "version": "8.1.12", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -25,9 +25,9 @@ "resolve": "1.8.1" }, "devDependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-library-build": "6.0.55", - "@microsoft/rush-stack-compiler-3.1": "0.6.13", + "@microsoft/rush-stack-compiler-3.1": "0.6.14", "@microsoft/rush-stack-compiler-3.2": "0.3.7", "@types/glob": "5.0.30", "@types/resolve": "0.0.8", diff --git a/core-build/gulp-core-build-webpack/package.json b/core-build/gulp-core-build-webpack/package.json index 4f7893cf433..dca493d9866 100644 --- a/core-build/gulp-core-build-webpack/package.json +++ b/core-build/gulp-core-build-webpack/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/gulp-core-build-webpack", - "version": "3.4.102", + "version": "3.4.103", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -24,8 +24,8 @@ "webpack": "~3.11.0" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/orchestrator": "0.0.30", "@types/q": "0.0.32", "@types/source-map": "0.5.0", diff --git a/core-build/node-library-build/package.json b/core-build/node-library-build/package.json index 381dbc96b64..8985d9cbf8f 100644 --- a/core-build/node-library-build/package.json +++ b/core-build/node-library-build/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/node-library-build", - "version": "6.0.61", + "version": "6.0.62", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -18,12 +18,12 @@ "dependencies": { "@microsoft/gulp-core-build": "3.9.26", "@microsoft/gulp-core-build-mocha": "3.5.76", - "@microsoft/gulp-core-build-typescript": "8.1.11", + "@microsoft/gulp-core-build-typescript": "8.1.12", "@types/gulp": "3.8.32", "@types/node": "8.5.8", "gulp": "~3.9.1" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13" + "@microsoft/rush-stack-compiler-3.2": "0.3.14" } } diff --git a/core-build/web-library-build/package.json b/core-build/web-library-build/package.json index c9d34a8dd18..7e3403d6c5e 100644 --- a/core-build/web-library-build/package.json +++ b/core-build/web-library-build/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/web-library-build", - "version": "7.0.38", + "version": "7.0.39", "description": "", "engines": { "npm": "3.10.8" @@ -19,17 +19,17 @@ }, "dependencies": { "@microsoft/gulp-core-build": "3.9.26", - "@microsoft/gulp-core-build-sass": "4.6.34", - "@microsoft/gulp-core-build-serve": "3.3.35", - "@microsoft/gulp-core-build-typescript": "8.1.11", - "@microsoft/gulp-core-build-webpack": "3.4.102", + "@microsoft/gulp-core-build-sass": "4.6.35", + "@microsoft/gulp-core-build-serve": "3.3.36", + "@microsoft/gulp-core-build-typescript": "8.1.12", + "@microsoft/gulp-core-build-webpack": "3.4.103", "@types/gulp": "3.8.32", "@types/node": "8.5.8", "gulp": "~3.9.1", "gulp-replace": "^0.5.4" }, "devDependencies": { - "@microsoft/node-library-build": "6.0.61", - "@microsoft/rush-stack-compiler-3.2": "0.3.13" + "@microsoft/node-library-build": "6.0.62", + "@microsoft/rush-stack-compiler-3.2": "0.3.14" } } diff --git a/libraries/load-themed-styles/package.json b/libraries/load-themed-styles/package.json index 52fc422174d..809f374fcc4 100644 --- a/libraries/load-themed-styles/package.json +++ b/libraries/load-themed-styles/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/load-themed-styles", - "version": "1.9.1", + "version": "1.9.2", "description": "Loads themed styles.", "license": "MIT", "repository": { @@ -14,12 +14,12 @@ "keywords": [], "dependencies": {}, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@types/chai": "3.4.34", "@types/mocha": "5.2.5", "@types/webpack-env": "1.13.0", "chai": "~3.5.0", "gulp": "~3.9.1", - "@microsoft/node-library-build": "6.0.61" + "@microsoft/node-library-build": "6.0.62" } } diff --git a/libraries/package-deps-hash/package.json b/libraries/package-deps-hash/package.json index f9e8143cdfa..1075e95da89 100644 --- a/libraries/package-deps-hash/package.json +++ b/libraries/package-deps-hash/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/package-deps-hash", - "version": "2.2.152", + "version": "2.2.153", "description": "", "main": "lib/index.js", "typings": "dist/package-deps-hash.d.ts", @@ -16,8 +16,8 @@ "build": "gulp test --clean" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@microsoft/node-core-library": "3.13.0", "chai": "~3.5.0", "gulp": "~3.9.1", diff --git a/libraries/rushell/package.json b/libraries/rushell/package.json index f026dbcddd9..8213cc6ab55 100644 --- a/libraries/rushell/package.json +++ b/libraries/rushell/package.json @@ -20,8 +20,8 @@ "@microsoft/node-core-library": "3.13.0" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/jest": "23.3.11", "@types/node": "8.5.8", "gulp": "~3.9.1", diff --git a/libraries/stream-collator/package.json b/libraries/stream-collator/package.json index dd241628674..bb7e6354e17 100644 --- a/libraries/stream-collator/package.json +++ b/libraries/stream-collator/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/stream-collator", - "version": "3.0.67", + "version": "3.0.68", "description": "Display intelligible realtime output from your asynchronous streams", "repository": { "type": "git", @@ -20,12 +20,12 @@ "@types/node": "8.5.8" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@types/chai": "3.4.34", "@types/mocha": "5.2.5", "chai": "~3.5.0", "gulp": "~3.9.1", "mocha": "^5.2.0", - "@microsoft/node-library-build": "6.0.61" + "@microsoft/node-library-build": "6.0.62" } } diff --git a/libraries/ts-command-line/package.json b/libraries/ts-command-line/package.json index 5967799f512..e4266c2d9bd 100644 --- a/libraries/ts-command-line/package.json +++ b/libraries/ts-command-line/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/ts-command-line", - "version": "4.2.4", + "version": "4.2.5", "description": "An object-oriented command-line parser for TypeScript", "repository": { "type": "git", diff --git a/stack/rush-stack-compiler-2.4/package.json b/stack/rush-stack-compiler-2.4/package.json index 141409479b7..d7e99348e27 100644 --- a/stack/rush-stack-compiler-2.4/package.json +++ b/stack/rush-stack-compiler-2.4/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-2.4", - "version": "0.6.13", + "version": "0.6.14", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 2.4.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-2.7/package.json b/stack/rush-stack-compiler-2.7/package.json index 6b5ff6ed52b..51180fd76cb 100644 --- a/stack/rush-stack-compiler-2.7/package.json +++ b/stack/rush-stack-compiler-2.7/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-2.7", - "version": "0.6.13", + "version": "0.6.14", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 2.7.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-2.8/package.json b/stack/rush-stack-compiler-2.8/package.json index 77a1ba70f48..18706e55171 100644 --- a/stack/rush-stack-compiler-2.8/package.json +++ b/stack/rush-stack-compiler-2.8/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-2.8", - "version": "0.1.0", + "version": "0.1.1", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 2.8.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-2.9/package.json b/stack/rush-stack-compiler-2.9/package.json index aa8c21a5bd6..db6e0370045 100644 --- a/stack/rush-stack-compiler-2.9/package.json +++ b/stack/rush-stack-compiler-2.9/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-2.9", - "version": "0.7.13", + "version": "0.7.14", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 2.9.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-3.0/package.json b/stack/rush-stack-compiler-3.0/package.json index ef12b0593c0..26ba558c42c 100644 --- a/stack/rush-stack-compiler-3.0/package.json +++ b/stack/rush-stack-compiler-3.0/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-3.0", - "version": "0.6.13", + "version": "0.6.14", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 3.0.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-3.1/package.json b/stack/rush-stack-compiler-3.1/package.json index a3df31943ad..6e85e9dede0 100644 --- a/stack/rush-stack-compiler-3.1/package.json +++ b/stack/rush-stack-compiler-3.1/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-3.1", - "version": "0.6.13", + "version": "0.6.14", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 3.1.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-3.2/package.json b/stack/rush-stack-compiler-3.2/package.json index e3777a4a6f8..0e96c051db3 100644 --- a/stack/rush-stack-compiler-3.2/package.json +++ b/stack/rush-stack-compiler-3.2/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-3.2", - "version": "0.3.13", + "version": "0.3.14", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 3.2.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-3.3/package.json b/stack/rush-stack-compiler-3.3/package.json index 6aec3de3e7f..0270a92753b 100644 --- a/stack/rush-stack-compiler-3.3/package.json +++ b/stack/rush-stack-compiler-3.3/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-3.3", - "version": "0.2.13", + "version": "0.2.14", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 3.3.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack-compiler-3.4/package.json b/stack/rush-stack-compiler-3.4/package.json index bdfdeb9a108..1d3db7a6d69 100644 --- a/stack/rush-stack-compiler-3.4/package.json +++ b/stack/rush-stack-compiler-3.4/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack-compiler-3.4", - "version": "0.1.0", + "version": "0.1.1", "description": "A plug-in for selecting the compiler used with the @microsoft/rush-stack toolchain. This version selects TypeScript 3.4.", "license": "MIT", "repository": { @@ -18,7 +18,7 @@ "main": "lib/shared/index.js", "typings": "lib/shared/index.d.ts", "dependencies": { - "@microsoft/api-extractor": "7.1.5", + "@microsoft/api-extractor": "7.1.6", "@microsoft/node-core-library": "3.13.0", "@types/node": "8.5.8", "tslint-microsoft-contrib": "~5.2.1", diff --git a/stack/rush-stack/package.json b/stack/rush-stack/package.json index c345a2a2417..3641e7a8d26 100644 --- a/stack/rush-stack/package.json +++ b/stack/rush-stack/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/rush-stack", - "version": "0.1.81", + "version": "0.1.82", "description": "A standardized toolchain for building JavaScript projects in a Rush monorepo", "license": "MIT", "keywords": [ @@ -26,12 +26,12 @@ }, "dependencies": { "@microsoft/node-core-library": "3.13.0", - "@microsoft/ts-command-line": "4.2.4", + "@microsoft/ts-command-line": "4.2.5", "colors": "~1.2.1" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", - "@microsoft/node-library-build": "6.0.61", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", + "@microsoft/node-library-build": "6.0.62", "@types/node": "8.5.8", "gulp": "~3.9.1" } diff --git a/webpack/loader-load-themed-styles/package.json b/webpack/loader-load-themed-styles/package.json index c0e383ac261..fe07a498273 100644 --- a/webpack/loader-load-themed-styles/package.json +++ b/webpack/loader-load-themed-styles/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/loader-load-themed-styles", - "version": "1.7.159", + "version": "1.7.160", "description": "This simple loader wraps the loading of CSS in script equivalent to `require('load-themed-styles').loadStyles( /* css text */ )`. It is designed to be a replacement for style-loader.", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -17,16 +17,16 @@ }, "dependencies": { "loader-utils": "~1.1.0", - "@microsoft/load-themed-styles": "1.9.1" + "@microsoft/load-themed-styles": "1.9.2" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@types/mocha": "5.2.5", "@types/node": "8.5.8", "@types/loader-utils": "1.1.3", "@types/webpack": "4.4.0", "chai": "~3.5.0", "gulp": "~3.9.1", - "@microsoft/node-library-build": "6.0.61" + "@microsoft/node-library-build": "6.0.62" } } diff --git a/webpack/loader-raw-script/package.json b/webpack/loader-raw-script/package.json index 516d83e6f4d..e882785d7d3 100644 --- a/webpack/loader-raw-script/package.json +++ b/webpack/loader-raw-script/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/loader-raw-script", - "version": "1.2.151", + "version": "1.2.152", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -16,12 +16,12 @@ "loader-utils": "~1.1.0" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@types/mocha": "5.2.5", "@types/node": "8.5.8", "chai": "~3.5.0", "gulp": "~3.9.1", "mocha": "^5.2.0", - "@microsoft/node-library-build": "6.0.61" + "@microsoft/node-library-build": "6.0.62" } } diff --git a/webpack/loader-set-webpack-public-path/package.json b/webpack/loader-set-webpack-public-path/package.json index 5d833ef8ece..660825420b3 100644 --- a/webpack/loader-set-webpack-public-path/package.json +++ b/webpack/loader-set-webpack-public-path/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/loader-set-webpack-public-path", - "version": "3.2.153", + "version": "3.2.154", "description": "This loader sets the webpack public path at runtime.", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -14,17 +14,17 @@ }, "dependencies": { "@types/node": "8.5.8", - "@microsoft/set-webpack-public-path-plugin": "2.1.109", + "@microsoft/set-webpack-public-path-plugin": "2.1.110", "loader-utils": "~1.1.0", "lodash": "~4.17.5" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@types/lodash": "4.14.116", "@types/mocha": "5.2.5", "chai": "~3.5.0", "gulp": "~3.9.1", "mocha": "^5.2.0", - "@microsoft/node-library-build": "6.0.61" + "@microsoft/node-library-build": "6.0.62" } } diff --git a/webpack/resolve-chunk-plugin/package.json b/webpack/resolve-chunk-plugin/package.json index a0ee919be41..e33355d1043 100644 --- a/webpack/resolve-chunk-plugin/package.json +++ b/webpack/resolve-chunk-plugin/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/resolve-chunk-plugin", - "version": "2.0.109", + "version": "2.0.110", "description": "This is a webpack plugin that looks for calls to \"resolveChunk\" with a chunk name, and returns the chunk ID.", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -19,11 +19,11 @@ "@types/webpack": "4.4.0" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@types/mocha": "5.2.5", "chai": "~3.5.0", "gulp": "~3.9.1", "mocha": "^5.2.0", - "@microsoft/node-library-build": "6.0.61" + "@microsoft/node-library-build": "6.0.62" } } diff --git a/webpack/set-webpack-public-path-plugin/package.json b/webpack/set-webpack-public-path-plugin/package.json index dadd5d67ff9..98311ee5fd5 100644 --- a/webpack/set-webpack-public-path-plugin/package.json +++ b/webpack/set-webpack-public-path-plugin/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/set-webpack-public-path-plugin", - "version": "2.1.109", + "version": "2.1.110", "description": "This plugin sets the webpack public path at runtime.", "main": "lib/index.js", "typings": "lib/index.d.ts", @@ -23,13 +23,13 @@ "@types/tapable": "1.0.2" }, "devDependencies": { - "@microsoft/rush-stack-compiler-3.2": "0.3.13", + "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@types/lodash": "4.14.116", "@types/mocha": "5.2.5", "@types/uglify-js": "2.6.29", "chai": "~3.5.0", "gulp": "~3.9.1", "mocha": "^5.2.0", - "@microsoft/node-library-build": "6.0.61" + "@microsoft/node-library-build": "6.0.62" } } From 08ec49aa6de6de105f5eabb5d30e752a5244c55c Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Tue, 28 May 2019 14:43:37 -0700 Subject: [PATCH 23/41] Revert "Update minor version." This reverts commit 1e2847f66044b762d59f3e1ccb73cdc4de5dc24c. --- .../jowedeki-hash-fix_2019-05-24-17-37.json | 11 ----------- core-build/gulp-core-build-sass/package.json | 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json diff --git a/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json b/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json deleted file mode 100644 index 6ac5a5a76a9..00000000000 --- a/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-24-17-37.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@microsoft/gulp-core-build-sass", - "comment": "Make class name hashes consistent regardless of path.", - "type": "patch" - } - ], - "packageName": "@microsoft/gulp-core-build-sass", - "email": "halfnibble@users.noreply.github.com" -} \ No newline at end of file diff --git a/core-build/gulp-core-build-sass/package.json b/core-build/gulp-core-build-sass/package.json index 1ccad9b0d21..3b082776a28 100644 --- a/core-build/gulp-core-build-sass/package.json +++ b/core-build/gulp-core-build-sass/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/gulp-core-build-sass", - "version": "4.6.35", + "version": "4.6.34", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", From 407e2effb213c96eb5d82a74677a6b827e151227 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Tue, 28 May 2019 14:43:51 -0700 Subject: [PATCH 24/41] Revert "Make generateModuleStub public too. Both are accessed by exertnal code and should be public. Also update dependencies." This reverts commit 7e5f9240ad129b9c531b916d2ba35b53f593d50b. --- common/config/rush/pnpm-lock.yaml | 4 ---- core-build/gulp-core-build-sass/src/SassTask.ts | 10 +++++----- core-build/web-library-build/package.json | 2 +- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml index 5e6db32dcd8..9c6df8ca159 100644 --- a/common/config/rush/pnpm-lock.yaml +++ b/common/config/rush/pnpm-lock.yaml @@ -9313,15 +9313,12 @@ packages: version: 0.0.0 'file:projects/gulp-core-build-sass.tgz': dependencies: - '@types/chai': 3.4.34 '@types/clean-css': 4.2.1 '@types/glob': 5.0.30 '@types/gulp': 3.8.32 - '@types/mocha': 5.2.5 '@types/node': 8.5.8 '@types/node-sass': 3.10.32 autoprefixer: 9.1.5 - chai: 3.5.0 clean-css: 4.2.1 glob: 7.0.6 gulp: 3.9.1 @@ -9952,7 +9949,6 @@ packages: version: 0.0.0 'file:projects/web-library-build-test.tgz': dependencies: - '@microsoft/gulp-core-build-sass': 4.6.35 '@types/jest': 23.3.11 gulp: 3.9.1 ts-jest: 22.4.6 diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index 5ab66e01b5a..b4394eeeb42 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -90,7 +90,7 @@ export class SassTask extends GulpTask { private _modulePostCssAdditionalPlugins: postcss.AcceptedPlugin[] = [ cssModules({ - getJSON: this.generateModuleStub.bind(this), + getJSON: this._generateModuleStub.bind(this), generateScopedName: this.generateScopedName.bind(this) }) ]; @@ -127,10 +127,6 @@ export class SassTask extends GulpTask { }).then(() => { /* collapse void[] to void */ }); } - public generateModuleStub(cssFileName: string, json: Object): void { - _classMaps[cssFileName] = json; - } - public generateScopedName(name: string, fileName: string, css: string): string { const fileBaseName: string = path.basename(fileName); const hash: string = crypto.createHmac('sha1', fileBaseName) @@ -140,6 +136,10 @@ export class SassTask extends GulpTask { return `${name}_${hash}`; } + private _generateModuleStub(cssFileName: string, json: Object): void { + _classMaps[cssFileName] = json; + } + private _processFile(filePath: string): Promise { // Ignore files that start with underscores if (path.basename(filePath).match(/^\_/)) { diff --git a/core-build/web-library-build/package.json b/core-build/web-library-build/package.json index 09e924e31d3..c9d34a8dd18 100644 --- a/core-build/web-library-build/package.json +++ b/core-build/web-library-build/package.json @@ -19,7 +19,7 @@ }, "dependencies": { "@microsoft/gulp-core-build": "3.9.26", - "@microsoft/gulp-core-build-sass": "4.6.35", + "@microsoft/gulp-core-build-sass": "4.6.34", "@microsoft/gulp-core-build-serve": "3.3.35", "@microsoft/gulp-core-build-typescript": "8.1.11", "@microsoft/gulp-core-build-webpack": "3.4.102", From 24407683782b227d0e0d38fcd05d19e7f36e032d Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Tue, 28 May 2019 19:21:04 -0700 Subject: [PATCH 25/41] Move postcss-modules logic to separate class. Stylistic changes on SassTask. --- .../gulp-core-build-sass/src/CSSModules.ts | 39 +++++ .../gulp-core-build-sass/src/SassTask.ts | 139 ++++++++---------- .../{SassTask.test.ts => CSSModules.test.ts} | 25 +++- 3 files changed, 117 insertions(+), 86 deletions(-) create mode 100644 core-build/gulp-core-build-sass/src/CSSModules.ts rename core-build/gulp-core-build-sass/src/test/{SassTask.test.ts => CSSModules.test.ts} (67%) diff --git a/core-build/gulp-core-build-sass/src/CSSModules.ts b/core-build/gulp-core-build-sass/src/CSSModules.ts new file mode 100644 index 00000000000..7d31aa9e2c5 --- /dev/null +++ b/core-build/gulp-core-build-sass/src/CSSModules.ts @@ -0,0 +1,39 @@ +import * as path from 'path'; + +import * as postcss from 'postcss'; +import * as cssModules from 'postcss-modules'; +import * as crypto from 'crypto'; + +export interface ICSSModules { + getPlugin: () => postcss.AcceptedPlugin; + getCssJSON: () => Object; +} + +export default class CSSModules implements ICSSModules { + private _classMap: Object = {}; + + public getPlugin = () => { + return cssModules({ + getJSON: this.saveJSON, + generateScopedName: this.generateScopedName + }); + } + + public getCssJSON = (): Object => { + return this._classMap; + } + + protected saveJSON = (cssFileName: string, json: Object): void => { + this._classMap = json; + } + + protected generateScopedName = (name: string, fileName: string, css: string) + : string => { + const fileBaseName: string = path.basename(fileName); + const hash: string = crypto.createHmac('sha1', fileBaseName) + .update(css) + .digest('hex') + .substring(0, 8); + return `${name}_${hash}`; + } +} diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index b4394eeeb42..22febdffa42 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -17,8 +17,7 @@ import * as nodeSass from 'node-sass'; import * as postcss from 'postcss'; import * as CleanCss from 'clean-css'; import * as autoprefixer from 'autoprefixer'; -import * as cssModules from 'postcss-modules'; -import * as crypto from 'crypto'; +import CSSModules, { ICSSModules } from './CSSModules'; export interface ISassTaskConfig { /** @@ -27,7 +26,8 @@ export interface ISassTaskConfig { preamble?: string; /** - * An optional parameter for text to include at the end of the generated TypeScript file. + * An optional parameter for text to include at the end of the generated + * TypeScript file. */ postamble?: string; @@ -37,47 +37,48 @@ export interface ISassTaskConfig { sassMatch?: string[]; /** - * If this option is specified, ALL files will be treated as module.sass or module.scss and will - * automatically generate a corresponding TypeScript file. All classes will be - * appended with a hash to help ensure uniqueness on a page. This file can be - * imported directly, and will contain an object describing the mangled class names. + * If this option is specified, ALL files will be treated as module.sass or + * module.scss and will automatically generate a corresponding TypeScript + * file. All classes will be appended with a hash to help ensure uniqueness + * on a page. This file can be imported directly, and will contain an object + * describing the mangled class names. */ useCSSModules?: boolean; /** - * If false, we will set the CSS property naming warning to verbose message while the module generates - * to prevent task exit with exitcode: 1. - * Default value is true + * If false, we will set the CSS property naming warning to verbose message + * while the module generates to prevent task exit with exitcode: 1. + * Default value is true. */ warnOnCssInvalidPropertyName?: boolean; /** - * If true, we will generate a CSS in the lib folder. If false, the CSS is directly embedded - * into the TypeScript file + * If true, we will generate CSS in the lib folder. If false, the CSS is + * directly embedded into the TypeScript file. */ dropCssFiles?: boolean; /** - * If files are matched by sassMatch which do not end in .module.sass or .module.scss, log a warning. + * If files are matched by sassMatch which do not end in .module.sass or + * .module.scss, log a warning. */ warnOnNonCSSModules?: boolean; /** - * If this option is specified, module CSS will be exported using the name provided. If an - * empty value is specified, the styles will be exported using 'export =', rather than a - * named export. By default we use the 'default' export name. + * If this option is specified, module CSS will be exported using the name + * provided. If an empty value is specified, the styles will be exported + * using 'export =', rather than a named export. By default, we use the + * 'default' export name. */ moduleExportName?: string; /** - * Allows the override of the options passed to clean-css. Options such a returnPromise and - * sourceMap will be ignored. + * Allows the override of the options passed to clean-css. Options such a + * returnPromise and sourceMap will be ignored. */ cleanCssOptions?: CleanCss.Options; } -const _classMaps: { [file: string]: Object } = {}; - export class SassTask extends GulpTask { public cleanMatch: string[] = [ 'src/**/*.sass.ts', @@ -88,13 +89,6 @@ export class SassTask extends GulpTask { autoprefixer({ browsers: ['> 1%', 'last 2 versions', 'ie >= 10'] }) ]; - private _modulePostCssAdditionalPlugins: postcss.AcceptedPlugin[] = [ - cssModules({ - getJSON: this._generateModuleStub.bind(this), - generateScopedName: this.generateScopedName.bind(this) - }) - ]; - constructor() { super( 'sass', @@ -127,19 +121,6 @@ export class SassTask extends GulpTask { }).then(() => { /* collapse void[] to void */ }); } - public generateScopedName(name: string, fileName: string, css: string): string { - const fileBaseName: string = path.basename(fileName); - const hash: string = crypto.createHmac('sha1', fileBaseName) - .update(css) - .digest('hex') - .substring(0, 8); - return `${name}_${hash}`; - } - - private _generateModuleStub(cssFileName: string, json: Object): void { - _classMaps[cssFileName] = json; - } - private _processFile(filePath: string): Promise { // Ignore files that start with underscores if (path.basename(filePath).match(/^\_/)) { @@ -148,11 +129,16 @@ export class SassTask extends GulpTask { const isFileModuleCss: boolean = !!filePath.match(/\.module\.s(a|c)ss/); const processAsModuleCss: boolean = isFileModuleCss || !!this.taskConfig.useCSSModules; + const cssModules: ICSSModules = new CSSModules(); - if (!isFileModuleCss && !this.taskConfig.useCSSModules && this.taskConfig.warnOnNonCSSModules) { - // If the file doesn't end with .module.scss and we don't treat all files as module-scss, warn - const relativeFilePath: string = path.relative(this.buildConfig.rootPath, filePath); - this.logWarning(`${relativeFilePath}: filename should end with module.sass or module.scss`); + if (!processAsModuleCss && this.taskConfig.warnOnNonCSSModules) { + const relativeFilePath: string = path.relative( + this.buildConfig.rootPath, filePath + ); + this.logWarning( + `${relativeFilePath}: filename should end with either .module.sass ` + + `or .module.scss` + ); } let cssOutputPath: string | undefined = undefined; @@ -190,10 +176,10 @@ export class SassTask extends GulpTask { }; } - const plugins: postcss.AcceptedPlugin[] = [ - ...this._postCSSPlugins, - ...(processAsModuleCss ? this._modulePostCssAdditionalPlugins : []) - ]; + const plugins: postcss.AcceptedPlugin[] = [...this._postCSSPlugins]; + if (processAsModuleCss) { + plugins.push(cssModules.getPlugin()); + } return postcss(plugins).process(result.css.toString(), options) as PromiseLike; }).then((result: postcss.Result) => { let cleanCssOptions: CleanCss.Options = { level: 1, returnPromise: true }; @@ -210,44 +196,40 @@ export class SassTask extends GulpTask { result.styles.toString() ]; if (result.sourceMap && !this.buildConfig.production) { - const encodedSourceMap: string = Buffer.from(result.sourceMap.toString()).toString('base64'); - generatedFileLines.push(...[ + const encodedSourceMap: string = Buffer.from(result.sourceMap.toString()) + .toString('base64'); + generatedFileLines.push( `/*# sourceMappingURL=data:application/json;base64,${encodedSourceMap} */` - ]); + ); } - FileSystem.writeFile(cssOutputPathAbsolute, generatedFileLines.join(EOL), { ensureFolderExists: true }); + FileSystem.writeFile( + cssOutputPathAbsolute, + generatedFileLines.join(EOL), + { ensureFolderExists: true } + ); } const scssTsOutputPath: string = `${filePath}.ts`; - const classNames: Object = _classMaps[filePath]; + const classMap: Object = cssModules.getCssJSON(); let exportClassNames: string = ''; const content: string | undefined = result.styles; - if (classNames) { - const classNamesLines: string[] = [ - 'const styles = {' - ]; - - const classKeys: string[] = Object.keys(classNames); - classKeys.forEach((key: string, index: number) => { - const value: string = classNames[key]; - let line: string = ''; + if (classMap) { + const classKeys: string[] = Object.keys(classMap); + const styleLines: string[] = []; + classKeys.forEach((key: string) => { + const value: string = classMap[key]; if (key.indexOf('-') !== -1) { - const message: string = `The local CSS class '${key}' is not camelCase and will not be type-safe.`; - this.taskConfig.warnOnCssInvalidPropertyName ? - this.logWarning(message) : + const message: string = `The local CSS class '${key}' is not ` + + `camelCase and will not be type-safe.`; + if (this.taskConfig.warnOnCssInvalidPropertyName) { + this.logWarning(message); + } else { this.logVerbose(message); - line = ` '${key}': '${value}'`; - } else { - line = ` ${key}: '${value}'`; - } - - if ((index + 1) <= classKeys.length) { - line += ','; + } } - - classNamesLines.push(line); + styleLines.push(` ${key}: '${value}'`); }); let exportString: string = 'export default styles;'; @@ -258,17 +240,16 @@ export class SassTask extends GulpTask { // exportString = `export const ${this.taskConfig.moduleExportName} = styles;`; } - classNamesLines.push( + exportClassNames = [ + 'const styles = {', + styleLines.join(`,${EOL}`), '};', '', exportString - ); - - exportClassNames = classNamesLines.join(EOL); + ].join(EOL); } let lines: string[] = []; - lines.push(this.taskConfig.preamble || ''); if (cssOutputPathAbsolute) { diff --git a/core-build/gulp-core-build-sass/src/test/SassTask.test.ts b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts similarity index 67% rename from core-build/gulp-core-build-sass/src/test/SassTask.test.ts rename to core-build/gulp-core-build-sass/src/test/CSSModules.test.ts index 71ba7b900c8..b08fefd80a7 100644 --- a/core-build/gulp-core-build-sass/src/test/SassTask.test.ts +++ b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts @@ -3,7 +3,7 @@ import * as path from 'path'; import { expect } from 'chai'; -import { SassTask } from '../SassTask'; +import CSSModules from '../CSSModules'; interface IScopedNameArgs { name: string; @@ -11,6 +11,17 @@ interface IScopedNameArgs { css: string; } +interface ITestCSSModules { + testGenerateScopedName: (name: string, fileName: string, css: string) => string; +} + +class TestCSSModules extends CSSModules { + public testGenerateScopedName = (name: string, fileName: string, css: string) + : string => { + return this.generateScopedName(name, fileName, css); + } +} + describe('class name hashing', () => { it('will generate different hashes for different content', (done) => { const version1: IScopedNameArgs = { @@ -23,11 +34,11 @@ describe('class name hashing', () => { fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), css: 'color: pink;' }; - const sassTask: SassTask = new SassTask(); - const output1: string = sassTask.generateScopedName( + const cssModules: ITestCSSModules = new TestCSSModules(); + const output1: string = cssModules.testGenerateScopedName( version1.name, version1.fileName, version1.css ); - const output2: string = sassTask.generateScopedName( + const output2: string = cssModules.testGenerateScopedName( version2.name, version2.fileName, version2.css ); expect(output1).to.not.equal(output2); @@ -45,11 +56,11 @@ describe('class name hashing', () => { fileName: path.join(__dirname, 'Suzan', 'workspace', 'src', 'main.sass'), css: 'color: blue;' }; - const sassTask: SassTask = new SassTask(); - const output1: string = sassTask.generateScopedName( + const cssModules: ITestCSSModules = new TestCSSModules(); + const output1: string = cssModules.testGenerateScopedName( version1.name, version1.fileName, version1.css ); - const output2: string = sassTask.generateScopedName( + const output2: string = cssModules.testGenerateScopedName( version2.name, version2.fileName, version2.css ); expect(output1).to.equal(output2); From 623fcab06dc2ab989132c4d90d422d4c496b3ed5 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Tue, 28 May 2019 20:15:20 -0700 Subject: [PATCH 26/41] Refactor. --- .../gulp-core-build-sass/src/CSSModules.ts | 8 ++ .../gulp-core-build-sass/src/SassTask.ts | 74 +++++++++---------- 2 files changed, 45 insertions(+), 37 deletions(-) diff --git a/core-build/gulp-core-build-sass/src/CSSModules.ts b/core-build/gulp-core-build-sass/src/CSSModules.ts index 7d31aa9e2c5..aea5d03a7dd 100644 --- a/core-build/gulp-core-build-sass/src/CSSModules.ts +++ b/core-build/gulp-core-build-sass/src/CSSModules.ts @@ -5,7 +5,15 @@ import * as cssModules from 'postcss-modules'; import * as crypto from 'crypto'; export interface ICSSModules { + /** + * Return a configured postcss plugin that will map class names to a + * consistently generated scoped name. + */ getPlugin: () => postcss.AcceptedPlugin; + + /** + * Return the CSS class map that is stored after postcss-modules runs. + */ getCssJSON: () => Object; } diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index 22febdffa42..bb01057588c 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -212,56 +212,22 @@ export class SassTask extends GulpTask { const scssTsOutputPath: string = `${filePath}.ts`; const classMap: Object = cssModules.getCssJSON(); - let exportClassNames: string = ''; + const stylesExportString: string = this._getStylesExportString(classMap); const content: string | undefined = result.styles; - if (classMap) { - const classKeys: string[] = Object.keys(classMap); - const styleLines: string[] = []; - classKeys.forEach((key: string) => { - const value: string = classMap[key]; - if (key.indexOf('-') !== -1) { - const message: string = `The local CSS class '${key}' is not ` + - `camelCase and will not be type-safe.`; - if (this.taskConfig.warnOnCssInvalidPropertyName) { - this.logWarning(message); - } else { - this.logVerbose(message); - } - } - styleLines.push(` ${key}: '${value}'`); - }); - - let exportString: string = 'export default styles;'; - - if (this.taskConfig.moduleExportName === '') { - exportString = 'export = styles;'; - } else if (!!this.taskConfig.moduleExportName) { - // exportString = `export const ${this.taskConfig.moduleExportName} = styles;`; - } - - exportClassNames = [ - 'const styles = {', - styleLines.join(`,${EOL}`), - '};', - '', - exportString - ].join(EOL); - } - let lines: string[] = []; lines.push(this.taskConfig.preamble || ''); if (cssOutputPathAbsolute) { lines = lines.concat([ `require(${JSON.stringify(`./${path.basename(cssOutputPathAbsolute)}`)});`, - exportClassNames + stylesExportString ]); } else if (!!content) { lines = lines.concat([ 'import { loadStyles } from \'@microsoft/load-themed-styles\';', '', - exportClassNames, + stylesExportString, '', `loadStyles(${JSON.stringify(splitStyles(content))});` ]); @@ -308,4 +274,38 @@ export class SassTask extends GulpTask { return url; } + + private _getStylesExportString(classMap: Object): string { + const classKeys: string[] = Object.keys(classMap); + const styleLines: string[] = []; + classKeys.forEach((key: string) => { + const value: string = classMap[key]; + if (key.indexOf('-') !== -1) { + const message: string = `The local CSS class '${key}' is not ` + + `camelCase and will not be type-safe.`; + if (this.taskConfig.warnOnCssInvalidPropertyName) { + this.logWarning(message); + } else { + this.logVerbose(message); + } + } + styleLines.push(` ${key}: '${value}'`); + }); + + let exportString: string = 'export default styles;'; + + if (this.taskConfig.moduleExportName === '') { + exportString = 'export = styles;'; + } else if (!!this.taskConfig.moduleExportName) { + // exportString = `export const ${this.taskConfig.moduleExportName} = styles;`; + } + + return [ + 'const styles = {', + styleLines.join(`,${EOL}`), + '};', + '', + exportString + ].join(EOL); + } } From d5875e42b6716f7e7ecc4063735f7fbaefd4248c Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Tue, 28 May 2019 20:47:52 -0700 Subject: [PATCH 27/41] Switch to testing with jest. --- .../gulp-core-build-sass/config/jest.json | 3 + core-build/gulp-core-build-sass/gulpfile.js | 1 + core-build/gulp-core-build-sass/package.json | 9 +- .../src/test/CSSModules.test.ts | 83 +++++++++---------- core-build/gulp-core-build-sass/tsconfig.json | 2 +- 5 files changed, 48 insertions(+), 50 deletions(-) create mode 100644 core-build/gulp-core-build-sass/config/jest.json diff --git a/core-build/gulp-core-build-sass/config/jest.json b/core-build/gulp-core-build-sass/config/jest.json new file mode 100644 index 00000000000..b4a7ec97a56 --- /dev/null +++ b/core-build/gulp-core-build-sass/config/jest.json @@ -0,0 +1,3 @@ +{ + "isEnabled": true +} \ No newline at end of file diff --git a/core-build/gulp-core-build-sass/gulpfile.js b/core-build/gulp-core-build-sass/gulpfile.js index bd411a7b85e..296eccbf8a6 100644 --- a/core-build/gulp-core-build-sass/gulpfile.js +++ b/core-build/gulp-core-build-sass/gulpfile.js @@ -1,4 +1,5 @@ 'use strict'; let build = require('@microsoft/node-library-build'); + build.initialize(require('gulp')); diff --git a/core-build/gulp-core-build-sass/package.json b/core-build/gulp-core-build-sass/package.json index 3b082776a28..6abe4bd2b3c 100644 --- a/core-build/gulp-core-build-sass/package.json +++ b/core-build/gulp-core-build-sass/package.json @@ -13,13 +13,11 @@ "url": "https://github.com/Microsoft/web-build-tools/tree/master/core-build/gulp-core-build-sass" }, "scripts": { - "build": "gulp --clean" + "build": "gulp test --clean" }, "dependencies": { "@microsoft/gulp-core-build": "3.9.26", "@microsoft/load-themed-styles": "1.9.1", - "@types/chai": "3.4.34", - "@types/mocha": "5.2.5", "@types/node": "8.5.8", "@types/gulp": "3.8.32", "autoprefixer": "~9.1.3", @@ -36,7 +34,8 @@ "@types/glob": "5.0.30", "@types/node-sass": "3.10.32", "@types/clean-css": "4.2.1", - "chai": "~3.5.0", - "gulp": "~3.9.1" + "gulp": "~3.9.1", + "@types/jest": "23.3.11", + "jest": "~23.6.0" } } diff --git a/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts index b08fefd80a7..58a664e594e 100644 --- a/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts +++ b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts @@ -1,7 +1,6 @@ // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license. // See LICENSE in the project root for license information. import * as path from 'path'; -import { expect } from 'chai'; import CSSModules from '../CSSModules'; @@ -22,48 +21,44 @@ class TestCSSModules extends CSSModules { } } -describe('class name hashing', () => { - it('will generate different hashes for different content', (done) => { - const version1: IScopedNameArgs = { - name: 'Button', - fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), - css: 'color: blue;' - }; - const version2: IScopedNameArgs = { - name: 'Button', - fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), - css: 'color: pink;' - }; - const cssModules: ITestCSSModules = new TestCSSModules(); - const output1: string = cssModules.testGenerateScopedName( - version1.name, version1.fileName, version1.css - ); - const output2: string = cssModules.testGenerateScopedName( - version2.name, version2.fileName, version2.css - ); - expect(output1).to.not.equal(output2); - done(); - }); +test('will generate different hashes for different content', () => { + const version1: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), + css: 'color: blue;' + }; + const version2: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), + css: 'color: pink;' + }; + const cssModules: ITestCSSModules = new TestCSSModules(); + const output1: string = cssModules.testGenerateScopedName( + version1.name, version1.fileName, version1.css + ); + const output2: string = cssModules.testGenerateScopedName( + version2.name, version2.fileName, version2.css + ); + expect(output1).not.toBe(output2); +}); - it('will generate the same hash in a different path', (done) => { - const version1: IScopedNameArgs = { - name: 'Button', - fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), - css: 'color: blue;' - }; - const version2: IScopedNameArgs = { - name: 'Button', - fileName: path.join(__dirname, 'Suzan', 'workspace', 'src', 'main.sass'), - css: 'color: blue;' - }; - const cssModules: ITestCSSModules = new TestCSSModules(); - const output1: string = cssModules.testGenerateScopedName( - version1.name, version1.fileName, version1.css - ); - const output2: string = cssModules.testGenerateScopedName( - version2.name, version2.fileName, version2.css - ); - expect(output1).to.equal(output2); - done(); - }); +test('will generate the same hash in a different path', () => { + const version1: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), + css: 'color: blue;' + }; + const version2: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Suzan', 'workspace', 'src', 'main.sass'), + css: 'color: blue;' + }; + const cssModules: ITestCSSModules = new TestCSSModules(); + const output1: string = cssModules.testGenerateScopedName( + version1.name, version1.fileName, version1.css + ); + const output2: string = cssModules.testGenerateScopedName( + version2.name, version2.fileName, version2.css + ); + expect(output1).toBe(output2); }); diff --git a/core-build/gulp-core-build-sass/tsconfig.json b/core-build/gulp-core-build-sass/tsconfig.json index 177c7384f50..7ce1b56fed8 100644 --- a/core-build/gulp-core-build-sass/tsconfig.json +++ b/core-build/gulp-core-build-sass/tsconfig.json @@ -2,7 +2,7 @@ "extends": "./node_modules/@microsoft/rush-stack-compiler-3.2/includes/tsconfig-node.json", "compilerOptions": { "types": [ - "mocha" + "jest" ] } } From 1c79d023f316106152ec7a780505ca2cb66d7338 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Tue, 28 May 2019 21:31:51 -0700 Subject: [PATCH 28/41] CSS Modules class name hash based on relative path to rootPath. --- .../gulp-core-build-sass/src/CSSModules.ts | 14 +++++++-- .../gulp-core-build-sass/src/SassTask.ts | 2 +- .../src/test/CSSModules.test.ts | 30 +++++++++++++++++-- 3 files changed, 41 insertions(+), 5 deletions(-) diff --git a/core-build/gulp-core-build-sass/src/CSSModules.ts b/core-build/gulp-core-build-sass/src/CSSModules.ts index aea5d03a7dd..3e52ad3870b 100644 --- a/core-build/gulp-core-build-sass/src/CSSModules.ts +++ b/core-build/gulp-core-build-sass/src/CSSModules.ts @@ -18,7 +18,17 @@ export interface ICSSModules { } export default class CSSModules implements ICSSModules { - private _classMap: Object = {}; + private _classMap: Object; + private _rootPath: string; + + constructor(rootPath?: string) { + this._classMap = {}; + if (rootPath) { + this._rootPath = rootPath; + } else { + this._rootPath = process.cwd(); + } + } public getPlugin = () => { return cssModules({ @@ -37,7 +47,7 @@ export default class CSSModules implements ICSSModules { protected generateScopedName = (name: string, fileName: string, css: string) : string => { - const fileBaseName: string = path.basename(fileName); + const fileBaseName: string = path.relative(this._rootPath, fileName); const hash: string = crypto.createHmac('sha1', fileBaseName) .update(css) .digest('hex') diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index bb01057588c..38ddb461bef 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -129,7 +129,7 @@ export class SassTask extends GulpTask { const isFileModuleCss: boolean = !!filePath.match(/\.module\.s(a|c)ss/); const processAsModuleCss: boolean = isFileModuleCss || !!this.taskConfig.useCSSModules; - const cssModules: ICSSModules = new CSSModules(); + const cssModules: ICSSModules = new CSSModules(this.buildConfig.rootPath); if (!processAsModuleCss && this.taskConfig.warnOnNonCSSModules) { const relativeFilePath: string = path.relative( diff --git a/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts index 58a664e594e..ab64853e08c 100644 --- a/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts +++ b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts @@ -42,7 +42,7 @@ test('will generate different hashes for different content', () => { expect(output1).not.toBe(output2); }); -test('will generate the same hash in a different path', () => { +test('will generate the same hash in a different root path', () => { const version1: IScopedNameArgs = { name: 'Button', fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), @@ -53,6 +53,32 @@ test('will generate the same hash in a different path', () => { fileName: path.join(__dirname, 'Suzan', 'workspace', 'src', 'main.sass'), css: 'color: blue;' }; + const cssModules: ITestCSSModules = new TestCSSModules( + path.join(__dirname, 'Sally') + ); + const output1: string = cssModules.testGenerateScopedName( + version1.name, version1.fileName, version1.css + ); + const cssModules2: ITestCSSModules = new TestCSSModules( + path.join(__dirname, 'Suzan', 'workspace') + ); + const output2: string = cssModules2.testGenerateScopedName( + version2.name, version2.fileName, version2.css + ); + expect(output1).toBe(output2); +}); + +test('will generate a different hash in a different src path', () => { + const version1: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'main.sass'), + css: 'color: blue;' + }; + const version2: IScopedNameArgs = { + name: 'Button', + fileName: path.join(__dirname, 'Sally', 'src', 'lib', 'main.sass'), + css: 'color: blue;' + }; const cssModules: ITestCSSModules = new TestCSSModules(); const output1: string = cssModules.testGenerateScopedName( version1.name, version1.fileName, version1.css @@ -60,5 +86,5 @@ test('will generate the same hash in a different path', () => { const output2: string = cssModules.testGenerateScopedName( version2.name, version2.fileName, version2.css ); - expect(output1).toBe(output2); + expect(output1).not.toBe(output2); }); From 1a26bcbd5c61137ad9d0764e25edd46fad09db26 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Tue, 28 May 2019 21:35:32 -0700 Subject: [PATCH 29/41] Rush changelog. --- .../jowedeki-hash-fix_2019-05-29-04-35.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json diff --git a/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json b/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json new file mode 100644 index 00000000000..945d187c07b --- /dev/null +++ b/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "@microsoft/gulp-core-build-sass", + "comment": "Make css modules class hash names consistent relative to root path.", + "type": "minor" + } + ], + "packageName": "@microsoft/gulp-core-build-sass", + "email": "halfnibble@users.noreply.github.com" +} \ No newline at end of file From b2d4f613e43197da003ea7c418f703ad504665f9 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Wed, 29 May 2019 10:22:44 -0700 Subject: [PATCH 30/41] Create more specific typings and name changes and style corrections. --- .../gulp-core-build-sass/src/CSSModules.ts | 20 ++++++++++++++----- .../gulp-core-build-sass/src/SassTask.ts | 9 ++++----- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/core-build/gulp-core-build-sass/src/CSSModules.ts b/core-build/gulp-core-build-sass/src/CSSModules.ts index 3e52ad3870b..0847074c1ed 100644 --- a/core-build/gulp-core-build-sass/src/CSSModules.ts +++ b/core-build/gulp-core-build-sass/src/CSSModules.ts @@ -4,6 +4,10 @@ import * as postcss from 'postcss'; import * as cssModules from 'postcss-modules'; import * as crypto from 'crypto'; +export interface IClassMap { + [className: string]: string; +} + export interface ICSSModules { /** * Return a configured postcss plugin that will map class names to a @@ -14,13 +18,19 @@ export interface ICSSModules { /** * Return the CSS class map that is stored after postcss-modules runs. */ - getCssJSON: () => Object; + getClassMap: () => IClassMap; } export default class CSSModules implements ICSSModules { - private _classMap: Object; + private _classMap: IClassMap; private _rootPath: string; + /** + * CSSModules includes the source file's path relative to the project root + * as part of the class name hashing algorithm. + * This should be configured with `buildConfig.rootPath` for SassTask, but + * will default the process' current working dir. + */ constructor(rootPath?: string) { this._classMap = {}; if (rootPath) { @@ -32,16 +42,16 @@ export default class CSSModules implements ICSSModules { public getPlugin = () => { return cssModules({ - getJSON: this.saveJSON, + getJSON: this.saveJson, generateScopedName: this.generateScopedName }); } - public getCssJSON = (): Object => { + public getClassMap = (): IClassMap => { return this._classMap; } - protected saveJSON = (cssFileName: string, json: Object): void => { + protected saveJson = (cssFileName: string, json: IClassMap): void => { this._classMap = json; } diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index 38ddb461bef..38bf6efdae9 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -17,7 +17,7 @@ import * as nodeSass from 'node-sass'; import * as postcss from 'postcss'; import * as CleanCss from 'clean-css'; import * as autoprefixer from 'autoprefixer'; -import CSSModules, { ICSSModules } from './CSSModules'; +import CSSModules, { ICSSModules, IClassMap } from './CSSModules'; export interface ISassTaskConfig { /** @@ -196,8 +196,7 @@ export class SassTask extends GulpTask { result.styles.toString() ]; if (result.sourceMap && !this.buildConfig.production) { - const encodedSourceMap: string = Buffer.from(result.sourceMap.toString()) - .toString('base64'); + const encodedSourceMap: string = Buffer.from(result.sourceMap.toString()).toString('base64'); generatedFileLines.push( `/*# sourceMappingURL=data:application/json;base64,${encodedSourceMap} */` ); @@ -211,7 +210,7 @@ export class SassTask extends GulpTask { } const scssTsOutputPath: string = `${filePath}.ts`; - const classMap: Object = cssModules.getCssJSON(); + const classMap: IClassMap = cssModules.getClassMap(); const stylesExportString: string = this._getStylesExportString(classMap); const content: string | undefined = result.styles; @@ -275,7 +274,7 @@ export class SassTask extends GulpTask { return url; } - private _getStylesExportString(classMap: Object): string { + private _getStylesExportString(classMap: IClassMap): string { const classKeys: string[] = Object.keys(classMap); const styleLines: string[] = []; classKeys.forEach((key: string) => { From a9b79988feca82c4832d8aba48c55eb9009f63b2 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Wed, 29 May 2019 14:22:17 -0700 Subject: [PATCH 31/41] Fix regression and revert warning message to match current suppressors. --- .gitignore | 3 +++ core-build/gulp-core-build-sass/src/SassTask.ts | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 0542088f0ac..48bfc992e9c 100644 --- a/.gitignore +++ b/.gitignore @@ -67,3 +67,6 @@ temp # Rush files common/temp/** package-deps.json + +# OS X +.DS_Store diff --git a/core-build/gulp-core-build-sass/src/SassTask.ts b/core-build/gulp-core-build-sass/src/SassTask.ts index 38bf6efdae9..17d43f7feb3 100644 --- a/core-build/gulp-core-build-sass/src/SassTask.ts +++ b/core-build/gulp-core-build-sass/src/SassTask.ts @@ -136,8 +136,7 @@ export class SassTask extends GulpTask { this.buildConfig.rootPath, filePath ); this.logWarning( - `${relativeFilePath}: filename should end with either .module.sass ` + - `or .module.scss` + `${relativeFilePath}: filename should end with module.sass or module.scss` ); } @@ -287,6 +286,7 @@ export class SassTask extends GulpTask { } else { this.logVerbose(message); } + key = `'${key}'`; } styleLines.push(` ${key}: '${value}'`); }); From ccfe318665981c9d03db5cb40661d90a683dedc7 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Wed, 29 May 2019 22:19:46 -0700 Subject: [PATCH 32/41] Make public methods member functions. Add return type to getPlugin(). --- core-build/gulp-core-build-sass/src/CSSModules.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core-build/gulp-core-build-sass/src/CSSModules.ts b/core-build/gulp-core-build-sass/src/CSSModules.ts index 0847074c1ed..23b8b285c40 100644 --- a/core-build/gulp-core-build-sass/src/CSSModules.ts +++ b/core-build/gulp-core-build-sass/src/CSSModules.ts @@ -40,14 +40,14 @@ export default class CSSModules implements ICSSModules { } } - public getPlugin = () => { + public getPlugin(): postcss.AcceptedPlugin { return cssModules({ getJSON: this.saveJson, generateScopedName: this.generateScopedName }); } - public getClassMap = (): IClassMap => { + public getClassMap(): IClassMap { return this._classMap; } From 80abb72604764976c1e075a0a9c1b3076617fba2 Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Wed, 29 May 2019 22:55:24 -0700 Subject: [PATCH 33/41] Just make everything use member functions for simplicity. --- core-build/gulp-core-build-sass/src/CSSModules.ts | 14 +++++++------- .../src/test/CSSModules.test.ts | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/core-build/gulp-core-build-sass/src/CSSModules.ts b/core-build/gulp-core-build-sass/src/CSSModules.ts index 23b8b285c40..44149f39178 100644 --- a/core-build/gulp-core-build-sass/src/CSSModules.ts +++ b/core-build/gulp-core-build-sass/src/CSSModules.ts @@ -13,12 +13,12 @@ export interface ICSSModules { * Return a configured postcss plugin that will map class names to a * consistently generated scoped name. */ - getPlugin: () => postcss.AcceptedPlugin; + getPlugin(): postcss.AcceptedPlugin; /** * Return the CSS class map that is stored after postcss-modules runs. */ - getClassMap: () => IClassMap; + getClassMap(): IClassMap; } export default class CSSModules implements ICSSModules { @@ -42,8 +42,8 @@ export default class CSSModules implements ICSSModules { public getPlugin(): postcss.AcceptedPlugin { return cssModules({ - getJSON: this.saveJson, - generateScopedName: this.generateScopedName + getJSON: this.saveJson.bind(this), + generateScopedName: this.generateScopedName.bind(this) }); } @@ -51,12 +51,12 @@ export default class CSSModules implements ICSSModules { return this._classMap; } - protected saveJson = (cssFileName: string, json: IClassMap): void => { + protected saveJson(cssFileName: string, json: IClassMap): void { this._classMap = json; } - protected generateScopedName = (name: string, fileName: string, css: string) - : string => { + protected generateScopedName(name: string, fileName: string, css: string) + : string { const fileBaseName: string = path.relative(this._rootPath, fileName); const hash: string = crypto.createHmac('sha1', fileBaseName) .update(css) diff --git a/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts index ab64853e08c..8b16897a927 100644 --- a/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts +++ b/core-build/gulp-core-build-sass/src/test/CSSModules.test.ts @@ -11,12 +11,12 @@ interface IScopedNameArgs { } interface ITestCSSModules { - testGenerateScopedName: (name: string, fileName: string, css: string) => string; + testGenerateScopedName(name: string, fileName: string, css: string): string; } class TestCSSModules extends CSSModules { - public testGenerateScopedName = (name: string, fileName: string, css: string) - : string => { + public testGenerateScopedName(name: string, fileName: string, css: string) + : string { return this.generateScopedName(name, fileName, css); } } From 944598b9d4c1c6ea62e4a19db69ad949d78c7ff2 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Thu, 30 May 2019 14:06:01 -0700 Subject: [PATCH 34/41] Cleaning up promprs and error messages for "rush change." --- apps/rush-lib/src/cli/actions/ChangeAction.ts | 54 +++++++++---------- apps/rush-lib/src/logic/ChangeFiles.ts | 29 +++++----- 2 files changed, 39 insertions(+), 44 deletions(-) diff --git a/apps/rush-lib/src/cli/actions/ChangeAction.ts b/apps/rush-lib/src/cli/actions/ChangeAction.ts index 8871f7a6f54..7feca05109c 100644 --- a/apps/rush-lib/src/cli/actions/ChangeAction.ts +++ b/apps/rush-lib/src/cli/actions/ChangeAction.ts @@ -96,24 +96,24 @@ export class ChangeAction extends BaseRushAction { parameterLongName: '--target-branch', parameterShortName: '-b', argumentName: 'BRANCH', - description: 'If this parameter is specified, compare current branch with the target branch to get changes. ' + - 'If this parameter is not specified, the current branch is compared against the "master" branch.' + description: 'If this parameter is specified, compare the checked out branch with the specified branch to' + + 'determine which projects were changed. If this parameter is not specified, the checked out branch ' + + 'is compared against the "master" branch.' }); } public run(): Promise { - console.log(`Target branch is ${this._targetBranch}`); + console.log(`The target branch is ${this._targetBranch}`); this._projectHostMap = this._generateHostMap(); if (this._verifyParameter.value) { this._verify(); return Promise.resolve(); } - this._sortedProjectList = this._getChangedPackageNames() - .sort(); + this._sortedProjectList = this._getChangedPackageNames().sort(); if (this._sortedProjectList.length === 0) { - console.log('No change file is needed.'); + console.log('No change descriptions are needed.'); this._warnUncommittedChanges(); return Promise.resolve(); } @@ -124,7 +124,7 @@ export class ChangeAction extends BaseRushAction { return this._promptLoop() .catch((error: Error) => { - throw new Error(`There was an error creating the change file: ${error.toString()}`); + throw new Error(`There was an error creating a change file: ${error.toString()}`); }); } @@ -147,14 +147,15 @@ export class ChangeAction extends BaseRushAction { if (changedPackages.length > 0) { this._validateChangeFile(changedPackages); } else { - console.log('No change is needed.'); + console.log('No change descriptions are needed.'); } } private get _targetBranch(): string { if (!this._targetBranchName) { - this._targetBranchName = this._targetBranchParameter.value || - VersionControl.getRemoteMasterBranch(this.rushConfiguration.repositoryUrl); + this._targetBranchName = ( + this._targetBranchParameter.value || VersionControl.getRemoteMasterBranch(this.rushConfiguration.repositoryUrl) + ); } return this._targetBranchName; @@ -184,9 +185,6 @@ export class ChangeAction extends BaseRushAction { private _validateChangeFile(changedPackages: string[]): void { const files: string[] = this._getChangeFiles(); - if (files.length === 0) { - throw new Error(`No change file is found. Run "rush change" to generate a change file.`); - } ChangeFiles.validate(files, changedPackages); } @@ -221,7 +219,7 @@ export class ChangeAction extends BaseRushAction { return this._askQuestions(this._sortedProjectList.pop()!) .then((answers: IChangeInfo) => { if (answers) { - // Save the info into the changefile + // Save the info into the change file let changeFile: IChangeFile | undefined = this._changeFileData.get(answers.packageName); if (!changeFile) { changeFile = { @@ -417,24 +415,27 @@ export class ChangeAction extends BaseRushAction { } } ]) - .then(({ email }) => { - return email; - }); + .then(({ email }) => email); } private _warnUncommittedChanges(): void { try { if (VersionControl.hasUncommittedChanges()) { - console.log(os.EOL + - colors.yellow('Warning: You have uncommitted changes, which do not trigger a change entry.')); + console.log( + os.EOL + + colors.yellow( + 'Warning: You have uncommitted changes, which do not trigger prompting for change ' + + 'descriptions.' + ) + ); } } catch (error) { - console.log('Ignore the failure of checking uncommitted changes'); + console.log(`An error occurred when detected uncommitted changes: ${error}`); } } /** - * Writes changefile to the common/changes folder. Will prompt for overwrite if file already exists. + * Writes change files to the common/changes folder. Will prompt for overwrite if file already exists. */ private _writeChangeFiles(): void { this._changeFileData.forEach((changeFile: IChangeFile) => { @@ -455,12 +456,11 @@ export class ChangeAction extends BaseRushAction { type: 'confirm', message: `Overwrite ${filePath} ?` } - ]).then(({ overwrite }: { overwrite: string }) => { + ]).then(({ overwrite }) => { if (overwrite) { - return this._writeFile(filePath, output); + this._writeFile(filePath, output); } else { console.log(`Not overwriting ${filePath}...`); - return Promise.resolve(); } }).catch((error) => { console.error(colors.red(error.message)); @@ -474,9 +474,7 @@ export class ChangeAction extends BaseRushAction { * Writes a file to disk, ensuring the directory structure up to that point exists */ private _writeFile(fileName: string, output: string): void { - FileSystem.writeFile(fileName, output, { - ensureFolderExists: true - }); - console.log('Created file: ' + fileName); + FileSystem.writeFile(fileName, output, { ensureFolderExists: true }); + console.log(`Created file: ${fileName}`); } } diff --git a/apps/rush-lib/src/logic/ChangeFiles.ts b/apps/rush-lib/src/logic/ChangeFiles.ts index 161c8af42e4..a1eec86f769 100644 --- a/apps/rush-lib/src/logic/ChangeFiles.ts +++ b/apps/rush-lib/src/logic/ChangeFiles.ts @@ -28,30 +28,27 @@ export class ChangeFiles { newChangeFilePaths: string[], changedPackages: string[] ): void { - const changedSet: Set = new Set(); + const projectsWithChangeDescriptions: Set = new Set(); newChangeFilePaths.forEach((filePath) => { console.log(`Found change file: ${filePath}`); - const changeRequest: IChangeInfo = JsonFile.load(filePath); - if (changeRequest && changeRequest.changes) { - changeRequest.changes!.forEach(change => { - changedSet.add(change.packageName); - }); + const changeFile: IChangeInfo = JsonFile.load(filePath); + if (changeFile && changeFile.changes) { + changeFile.changes.forEach(change => projectsWithChangeDescriptions.add(change.packageName)); } else { throw new Error(`Invalid change file: ${filePath}`); } }); - const requiredSet: Set = new Set(changedPackages); - changedSet.forEach((name) => { - requiredSet.delete(name); - }); - if (requiredSet.size > 0) { - const missingProjects: string[] = []; - requiredSet.forEach(name => { - missingProjects.push(name); - }); - throw new Error(`Change file does not contain ${missingProjects.join(',')}.`); + const projectsMissingChangeDescriptions: Set = new Set(changedPackages); + projectsWithChangeDescriptions.forEach((name) => projectsMissingChangeDescriptions.delete(name)); + if (projectsMissingChangeDescriptions.size > 0) { + const projectsMissingChangeDescriptionsArray: string[] = []; + projectsMissingChangeDescriptions.forEach(name => projectsMissingChangeDescriptionsArray.push(name)); + throw new Error( + `The following projects have been changed, but are missing change descriptions: ` + + `${projectsMissingChangeDescriptionsArray.join(',')}.` + ); } } From c16f6f0d54d4ef57d37d12f0f1adb1b2eb67a5b2 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Thu, 30 May 2019 14:26:14 -0700 Subject: [PATCH 35/41] Formatting improvments. --- .../test/__snapshots__/CommandLineHelp.test.ts.snap | 9 +++++---- apps/rush-lib/src/logic/ChangeFiles.ts | 10 ++++++---- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap b/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap index 49191ab3abf..281fe6fcba0 100644 --- a/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap +++ b/apps/rush-lib/src/cli/test/__snapshots__/CommandLineHelp.test.ts.snap @@ -166,10 +166,11 @@ Optional arguments: --no-fetch Skips fetching the baseline branch before running \\"git diff\\" to detect changes. -b BRANCH, --target-branch BRANCH - If this parameter is specified, compare current - branch with the target branch to get changes. If this - parameter is not specified, the current branch is - compared against the \\"master\\" branch. + If this parameter is specified, compare the checked + out branch with the specified branch todetermine + which projects were changed. If this parameter is not + specified, the checked out branch is compared against + the \\"master\\" branch. " `; diff --git a/apps/rush-lib/src/logic/ChangeFiles.ts b/apps/rush-lib/src/logic/ChangeFiles.ts index a1eec86f769..1cdf0da4519 100644 --- a/apps/rush-lib/src/logic/ChangeFiles.ts +++ b/apps/rush-lib/src/logic/ChangeFiles.ts @@ -45,10 +45,12 @@ export class ChangeFiles { if (projectsMissingChangeDescriptions.size > 0) { const projectsMissingChangeDescriptionsArray: string[] = []; projectsMissingChangeDescriptions.forEach(name => projectsMissingChangeDescriptionsArray.push(name)); - throw new Error( - `The following projects have been changed, but are missing change descriptions: ` + - `${projectsMissingChangeDescriptionsArray.join(',')}.` - ); + throw new Error([ + 'The following projects have been changed and require change descriptions, but are missing them:', + ...projectsMissingChangeDescriptionsArray.map((projectName) => `- ${projectName}`), + 'To resolve this error, run "rush change." This will generate change description files that must be ' + + 'committed to source control.' + ].join(EOL)); } } From adb1eb4549126bc686ccc1de09b05383e7a37a27 Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Thu, 30 May 2019 14:37:23 -0700 Subject: [PATCH 36/41] Improve phrasing. --- apps/rush-lib/src/logic/ChangeFiles.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/rush-lib/src/logic/ChangeFiles.ts b/apps/rush-lib/src/logic/ChangeFiles.ts index 1cdf0da4519..8b3d3060d97 100644 --- a/apps/rush-lib/src/logic/ChangeFiles.ts +++ b/apps/rush-lib/src/logic/ChangeFiles.ts @@ -46,7 +46,8 @@ export class ChangeFiles { const projectsMissingChangeDescriptionsArray: string[] = []; projectsMissingChangeDescriptions.forEach(name => projectsMissingChangeDescriptionsArray.push(name)); throw new Error([ - 'The following projects have been changed and require change descriptions, but are missing them:', + 'The following projects have been changed and require change descriptions, but change descriptions were not ' + + 'detected for them:', ...projectsMissingChangeDescriptionsArray.map((projectName) => `- ${projectName}`), 'To resolve this error, run "rush change." This will generate change description files that must be ' + 'committed to source control.' From 22f5920967beadf19463534d85a2a4139ea7666d Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Thu, 30 May 2019 14:37:29 -0700 Subject: [PATCH 37/41] Rush change. --- .../ianc-improved-change-error_2019-05-30-21-23.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/@microsoft/rush/ianc-improved-change-error_2019-05-30-21-23.json diff --git a/common/changes/@microsoft/rush/ianc-improved-change-error_2019-05-30-21-23.json b/common/changes/@microsoft/rush/ianc-improved-change-error_2019-05-30-21-23.json new file mode 100644 index 00000000000..d6df8decbd8 --- /dev/null +++ b/common/changes/@microsoft/rush/ianc-improved-change-error_2019-05-30-21-23.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "comment": "Clarify \"rush change\" messages.", + "packageName": "@microsoft/rush", + "type": "none" + } + ], + "packageName": "@microsoft/rush", + "email": "iclanton@users.noreply.github.com" +} \ No newline at end of file From 94663e021cf4097c4c182d099af691951b33a9af Mon Sep 17 00:00:00 2001 From: Ian Clanton-Thuon Date: Thu, 30 May 2019 14:44:09 -0700 Subject: [PATCH 38/41] Fix typo. --- apps/rush-lib/src/cli/actions/ChangeAction.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/rush-lib/src/cli/actions/ChangeAction.ts b/apps/rush-lib/src/cli/actions/ChangeAction.ts index 7bc8db52628..95abe922349 100644 --- a/apps/rush-lib/src/cli/actions/ChangeAction.ts +++ b/apps/rush-lib/src/cli/actions/ChangeAction.ts @@ -430,7 +430,7 @@ export class ChangeAction extends BaseRushAction { ); } } catch (error) { - console.log(`An error occurred when detected uncommitted changes: ${error}`); + console.log(`An error occurred when detecting uncommitted changes: ${error}`); } } From e637bfba3ffadd41105ddae6cbd1c89a0cc5eb5f Mon Sep 17 00:00:00 2001 From: Joshua Wedekind Date: Thu, 30 May 2019 16:44:31 -0700 Subject: [PATCH 39/41] Address feedback. --- core-build/gulp-core-build-sass/src/CSSModules.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/core-build/gulp-core-build-sass/src/CSSModules.ts b/core-build/gulp-core-build-sass/src/CSSModules.ts index 44149f39178..66d0cc1bbdc 100644 --- a/core-build/gulp-core-build-sass/src/CSSModules.ts +++ b/core-build/gulp-core-build-sass/src/CSSModules.ts @@ -28,8 +28,10 @@ export default class CSSModules implements ICSSModules { /** * CSSModules includes the source file's path relative to the project root * as part of the class name hashing algorithm. - * This should be configured with `buildConfig.rootPath` for SassTask, but - * will default the process' current working dir. + * This should be configured with the setting: + * {@link @microsoft/gulp-core-build#IBuildConfig.rootPath} + * That is used in {@link ./SassTask#SassTask} + * But will default the process' current working dir. */ constructor(rootPath?: string) { this._classMap = {}; @@ -58,7 +60,8 @@ export default class CSSModules implements ICSSModules { protected generateScopedName(name: string, fileName: string, css: string) : string { const fileBaseName: string = path.relative(this._rootPath, fileName); - const hash: string = crypto.createHmac('sha1', fileBaseName) + const safeFileBaseName: string = fileBaseName.replace(/\\/g, '/'); + const hash: string = crypto.createHmac('sha1', safeFileBaseName) .update(css) .digest('hex') .substring(0, 8); From 10640da67a7062f7eb304de37832ef64d21e6eac Mon Sep 17 00:00:00 2001 From: Rushbot Date: Fri, 31 May 2019 01:13:08 +0000 Subject: [PATCH 40/41] Deleting change files and updating change logs for package updates. --- .../jowedeki-hash-fix_2019-05-29-04-35.json | 11 ----------- core-build/gulp-core-build-sass/CHANGELOG.json | 12 ++++++++++++ core-build/gulp-core-build-sass/CHANGELOG.md | 9 ++++++++- core-build/web-library-build/CHANGELOG.json | 12 ++++++++++++ core-build/web-library-build/CHANGELOG.md | 7 ++++++- 5 files changed, 38 insertions(+), 13 deletions(-) delete mode 100644 common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json diff --git a/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json b/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json deleted file mode 100644 index 945d187c07b..00000000000 --- a/common/changes/@microsoft/gulp-core-build-sass/jowedeki-hash-fix_2019-05-29-04-35.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "changes": [ - { - "packageName": "@microsoft/gulp-core-build-sass", - "comment": "Make css modules class hash names consistent relative to root path.", - "type": "minor" - } - ], - "packageName": "@microsoft/gulp-core-build-sass", - "email": "halfnibble@users.noreply.github.com" -} \ No newline at end of file diff --git a/core-build/gulp-core-build-sass/CHANGELOG.json b/core-build/gulp-core-build-sass/CHANGELOG.json index df7d3c563d7..f7d5c154769 100644 --- a/core-build/gulp-core-build-sass/CHANGELOG.json +++ b/core-build/gulp-core-build-sass/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/gulp-core-build-sass", "entries": [ + { + "version": "4.7.0", + "tag": "@microsoft/gulp-core-build-sass_v4.7.0", + "date": "Fri, 31 May 2019 01:13:07 GMT", + "comments": { + "minor": [ + { + "comment": "Make css modules class hash names consistent relative to root path." + } + ] + } + }, { "version": "4.6.35", "tag": "@microsoft/gulp-core-build-sass_v4.6.35", diff --git a/core-build/gulp-core-build-sass/CHANGELOG.md b/core-build/gulp-core-build-sass/CHANGELOG.md index 0e4782f6057..436c0805178 100644 --- a/core-build/gulp-core-build-sass/CHANGELOG.md +++ b/core-build/gulp-core-build-sass/CHANGELOG.md @@ -1,6 +1,13 @@ # Change Log - @microsoft/gulp-core-build-sass -This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. +This log was last generated on Fri, 31 May 2019 01:13:07 GMT and should not be manually modified. + +## 4.7.0 +Fri, 31 May 2019 01:13:07 GMT + +### Minor changes + +- Make css modules class hash names consistent relative to root path. ## 4.6.35 Mon, 27 May 2019 04:13:44 GMT diff --git a/core-build/web-library-build/CHANGELOG.json b/core-build/web-library-build/CHANGELOG.json index 9903f896ef3..b87016c2457 100644 --- a/core-build/web-library-build/CHANGELOG.json +++ b/core-build/web-library-build/CHANGELOG.json @@ -1,6 +1,18 @@ { "name": "@microsoft/web-library-build", "entries": [ + { + "version": "7.0.40", + "tag": "@microsoft/web-library-build_v7.0.40", + "date": "Fri, 31 May 2019 01:13:07 GMT", + "comments": { + "dependency": [ + { + "comment": "Updating dependency \"@microsoft/gulp-core-build-sass\" from `4.6.35` to `4.7.0`" + } + ] + } + }, { "version": "7.0.39", "tag": "@microsoft/web-library-build_v7.0.39", diff --git a/core-build/web-library-build/CHANGELOG.md b/core-build/web-library-build/CHANGELOG.md index df6bc717f72..f618ec1d117 100644 --- a/core-build/web-library-build/CHANGELOG.md +++ b/core-build/web-library-build/CHANGELOG.md @@ -1,6 +1,11 @@ # Change Log - @microsoft/web-library-build -This log was last generated on Mon, 27 May 2019 04:13:44 GMT and should not be manually modified. +This log was last generated on Fri, 31 May 2019 01:13:07 GMT and should not be manually modified. + +## 7.0.40 +Fri, 31 May 2019 01:13:07 GMT + +*Version update only* ## 7.0.39 Mon, 27 May 2019 04:13:44 GMT From 5d4984083ca319f96b6aa6683724adc41d95dfbb Mon Sep 17 00:00:00 2001 From: Rushbot Date: Fri, 31 May 2019 01:13:09 +0000 Subject: [PATCH 41/41] Applying package updates. --- build-tests/web-library-build-test/package.json | 2 +- core-build/gulp-core-build-sass/package.json | 2 +- core-build/web-library-build/package.json | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/build-tests/web-library-build-test/package.json b/build-tests/web-library-build-test/package.json index 6a06d1e478d..da42f5bb27f 100644 --- a/build-tests/web-library-build-test/package.json +++ b/build-tests/web-library-build-test/package.json @@ -16,7 +16,7 @@ "@types/jest": "23.3.11", "@microsoft/rush-stack-compiler-3.2": "0.3.14", "@microsoft/load-themed-styles": "1.9.2", - "@microsoft/web-library-build": "7.0.39", + "@microsoft/web-library-build": "7.0.40", "gulp": "~3.9.1" } } diff --git a/core-build/gulp-core-build-sass/package.json b/core-build/gulp-core-build-sass/package.json index 8af21fb258b..3ed270a2bba 100644 --- a/core-build/gulp-core-build-sass/package.json +++ b/core-build/gulp-core-build-sass/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/gulp-core-build-sass", - "version": "4.6.35", + "version": "4.7.0", "description": "", "main": "lib/index.js", "typings": "lib/index.d.ts", diff --git a/core-build/web-library-build/package.json b/core-build/web-library-build/package.json index 7e3403d6c5e..9a60598b773 100644 --- a/core-build/web-library-build/package.json +++ b/core-build/web-library-build/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/web-library-build", - "version": "7.0.39", + "version": "7.0.40", "description": "", "engines": { "npm": "3.10.8" @@ -19,7 +19,7 @@ }, "dependencies": { "@microsoft/gulp-core-build": "3.9.26", - "@microsoft/gulp-core-build-sass": "4.6.35", + "@microsoft/gulp-core-build-sass": "4.7.0", "@microsoft/gulp-core-build-serve": "3.3.36", "@microsoft/gulp-core-build-typescript": "8.1.12", "@microsoft/gulp-core-build-webpack": "3.4.103",