Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Design][No Orders API] Review from a first test #4

Closed
raveesh-me opened this issue May 21, 2019 · 5 comments
Closed

[API Design][No Orders API] Review from a first test #4

raveesh-me opened this issue May 21, 2019 · 5 comments
Assignees

Comments

@raveesh-me
Copy link

Hi! I reviewed the plugin live, as I was trying to implement a client project,
Here are my key findings:

  1. Current API surface does not have any way to deal with the orders API
    -> PaymentSuccessResponse has only payment_id, not the best way to deal with this
  2. Callbacks are good, but we could have designed the API in a little better way(promises / async / await)

I have archived the video, but if interested can make it available.
At the same time, am open to discuss a better API surface.

Bests,
Raveesh.

@raveesh-me
Copy link
Author

raveesh-me commented May 21, 2019

Also using callbacks does not allow you to enforce function signatures in the on method either.

@ChintanAcharya
Copy link
Contributor

@raveesh-me We'll be adding support for Orders API soon.

@ChintanAcharya ChintanAcharya self-assigned this May 22, 2019
@ChintanAcharya
Copy link
Contributor

@raveesh-me We've added support for Orders in v1.1.0-alpha.

@raveesh-me
Copy link
Author

Thank you, will check out in the next project.

@ChintanAcharya
Copy link
Contributor

@raveesh-me Did you get a chance to try it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants