You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for posting your fix metadan. I implemented it and it fixed a JS error that quicksand was throwing, but the items were not being animated. I modified your code as follows and it seemed to have fixed it completely.
var bTopWidth = parseFloat($correctionParent.css('border-top-width'));
var bLeftWidth = parseFloat($correctionParent.css('border-left-width'));
if ($correctionParent.css('position') == 'relative') {
if ($correctionParent.get(0).nodeName.toLowerCase() == 'body') {
} else {
if (!isNaN(bTopWidth))
correctionOffset.top += bTopWidth;
if (!isNaN(bLeftWidth))
correctionOffset.left += bLeftWidth;
}
} else {
if (!isNaN(bTopWidth))
correctionOffset.top -= bTopWidth;
if (!isNaN(bLeftWidth))
correctionOffset.left -= bLeftWidth;
correctionOffset.top -= parseFloat($correctionParent.css('margin-top'));
correctionOffset.left -= parseFloat($correctionParent.css('margin-left'));
}
I've integrated quicksand into a site i'm working on and came across this issue...
I've fixed it but how do i submit a fix to the code (if my fix is ok, and it is deemed a bug that is ofcourse)?
Regards,
Dan
BASE:
correctionOffset.top -= parseFloat($correctionParent.css('border-top-width'));
correctionOffset.left -= parseFloat($correctionParent.css('border-left-width'));
FIX:
var bTopWidth = parseFloat($correctionParent.css('border-top-width'));
if ( !isNaN(bTopWidth) ) {
correctionOffset.top -= bTopWidth;
}
var bLeftWidth = parseFloat($correctionParent.css('border-left-width'));
if ( !isNaN(bLeftWidth) ) {
correctionOffset.left -= bLeftWidth;
}
The text was updated successfully, but these errors were encountered: