fix: replace escape condition on falsy values (#309)

sodiray · Jun 26, 2023 · 28f8114 · 28f8114 · vercel · Jun 26, 2023
1 parent 36df87e
commit 28f8114
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/array.ts b/src/array.ts
@@ -180,7 +180,7 @@ export const replace = <T>(
   match: (item: T, idx: number) => boolean
 ): T[] => {
   if (!list) return []
-  if (!newItem) return [...list]
+  if (newItem === undefined) return [...list]
   for (let idx = 0; idx < list.length; idx++) {
     const item = list[idx]
     if (match(item, idx)) {

diff --git a/src/tests/array.test.ts b/src/tests/array.test.ts
@@ -176,10 +176,14 @@ describe('array module', () => {
       )
       assert.deepEqual(result, [])
     })
-    test('returns the list for a null new item', () => {
-      const result = _.replace(['a'], null, () => false)
+    test('returns the list for an undefined new item', () => {
+      const result = _.replace(['a'], undefined, () => true)
       assert.deepEqual(result, ['a'])
     })
+    test('returns replaced item when value is null', () => {
+      const result = _.replace(['a'], null, i => i === 'a')
+      assert.deepEqual(result, [null])
+    })
     test('returns replaced item by index', () => {
       const result = _.replace(
         ['a', 'b', 'c', 'd'],