Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Explicitly test orphan grandchildren dependency when children exit #31875

Closed
rickyyx opened this issue Jan 23, 2023 · 2 comments · Fixed by #33818
Closed

[core] Explicitly test orphan grandchildren dependency when children exit #31875

rickyyx opened this issue Jan 23, 2023 · 2 comments · Fixed by #33818
Assignees
@rickyyx
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core core-worker P1 Issue that should be fixed within a few weeks tech-debt The issue that's due to tech debt

Comments

@rickyyx
Copy link
Contributor

rickyyx commented Jan 23, 2023

What happened + What you expected to happen

It has been found that when a child finishes, the grandchildren tasks if not awaited, will become orphans, and keep running even if the job finishes or grandparent finishes.

Versions / Dependencies

master

Reproduction script

TODO

Issue Severity

None
@rickyyx rickyyx added bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels Jan 23, 2023
@rickyyx rickyyx self-assigned this Jan 23, 2023
@rickyyx rickyyx removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Jan 23, 2023
@rickyyx rickyyx mentioned this issue Jan 23, 2023
Merged
7 tasks
@rkooo567 rkooo567 added tech-debt The issue that's due to tech debt P1.5 Issues that will be fixed in a couple releases. It will be bumped once all P1s are cleared and removed P1 Issue that should be fixed within a few weeks labels Mar 24, 2023
@rkooo567
Copy link
Contributor

rkooo567 commented Apr 7, 2023

@rickyyx this will be done from your PR right?

@rickyyx
Copy link
Contributor Author

rickyyx commented Apr 7, 2023

oh right yes.

@rickyyx rickyyx mentioned this issue Apr 7, 2023
Merged
8 tasks
@rkooo567 rkooo567 added P1 Issue that should be fixed within a few weeks and removed P1.5 Issues that will be fixed in a couple releases. It will be bumped once all P1s are cleared labels Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickyyx rickyyx

Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core core-worker P1 Issue that should be fixed within a few weeks tech-debt The issue that's due to tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Task backend - marking tasks failed on worker death rickyyx/ray
3 participants
@scv119 @rickyyx @rkooo567