Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Disable zero downtime upgrade for a RayService #2397

Open
1 of 2 tasks
smit-kiri opened this issue Sep 23, 2024 · 3 comments
Open
1 of 2 tasks

[Feature] Disable zero downtime upgrade for a RayService #2397

smit-kiri opened this issue Sep 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request triage

Comments

@smit-kiri
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently we have a global flag to disable zero downtime upgrades for ALL RayService resources. It would be great to have a flag in the CRD to disable zero-downtime upgrade for a specific RayService resource.

Use case

We're managing multiple RayService resources, and want to disable zero-downtime upgrade in one of the resources.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@smit-kiri smit-kiri added enhancement New feature or request triage labels Sep 23, 2024
@andrewsykim
Copy link
Collaborator

andrewsykim commented Sep 23, 2024

I would be in favor of a new field in RayService to toggle the upgrade policy. We can default it to zero-downtime upgrade for compatibility. What do you think @kevin85421

@andrewsykim
Copy link
Collaborator

There are some other proposals floating around for supporting N RayCluster per RayService as well, it might be good to revisit this as part of those proposals.

@smit-kiri
Copy link
Author

There are some other proposals floating around for supporting N RayCluster per RayService as well, it might be good to revisit this as part of those proposals.

I would also be in favor of having N RayCluster per RayService!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants