Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use login shell for Submitter Pod command #2209

Open
1 of 2 tasks
mickvangelderen opened this issue Jun 28, 2024 · 0 comments
Open
1 of 2 tasks

Use login shell for Submitter Pod command #2209

mickvangelderen opened this issue Jun 28, 2024 · 0 comments
Labels
1.3.0 discussion Need community members' input enhancement New feature or request rayjob

Comments

@mickvangelderen
Copy link

mickvangelderen commented Jun 28, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

The head and worker pods use a login shell bash -l but the submitter pod command does not.

The documentated preStop lifecycle should probably also use a login shell and bash instead of sh for consistency.

Use case

I'm using pixi inside of Docker and activating the environment requires running pixi's shell hook. I added source shell-hook.sh to .bash_profile so that this happens for login shells.

What I actually would prefer is if ray could use args everywhere, rather than command so that the ENTRYPOINT stays intact.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3.0 discussion Need community members' input enhancement New feature or request rayjob
Projects
None yet
Development

No branches or pull requests

2 participants